From 021a5a0c1f88df846d60f5c6628411626f4836d1 Mon Sep 17 00:00:00 2001 From: Lukas Date: Sat, 7 May 2022 22:58:33 +0200 Subject: [PATCH] fix(argo-cd): use global imagePullSecret value for notifications deployment (#1253) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix(argo-cd): use global imagePullSecret value for notifications deployment Signed-off-by: Höhl, Lukas * chore(argo-cd): rerun helm docs Signed-off-by: Höhl, Lukas * chore(argo-cd): bump version Signed-off-by: Höhl, Lukas * Drop unnecessary newline Signed-off-by: Marco Kilchhofer Co-authored-by: Marco Kilchhofer --- charts/argo-cd/Chart.yaml | 6 ++---- .../argo-cd/templates/argocd-notifications/deployment.yaml | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/charts/argo-cd/Chart.yaml b/charts/argo-cd/Chart.yaml index d2f2bf75..805d249d 100644 --- a/charts/argo-cd/Chart.yaml +++ b/charts/argo-cd/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 appVersion: v2.3.3 description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes. name: argo-cd -version: 4.5.10 +version: 4.5.11 home: https://github.com/argoproj/argo-helm icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png keywords: @@ -21,6 +21,4 @@ dependencies: condition: redis-ha.enabled annotations: artifacthub.io/changes: | - - "[Fixed]: Use global imagePullPolicy for Dex by default" - - "[Fixed]: ApplicationSet imagePullPolicy variable in values.yaml" - - "[Fixed]: Use global imagePullPolicy for ApplicationSet by default" + - "[Fixed]: Use global imagePullSecret value for notfications deployment" diff --git a/charts/argo-cd/templates/argocd-notifications/deployment.yaml b/charts/argo-cd/templates/argocd-notifications/deployment.yaml index a6371a66..faae4d3d 100644 --- a/charts/argo-cd/templates/argocd-notifications/deployment.yaml +++ b/charts/argo-cd/templates/argocd-notifications/deployment.yaml @@ -27,7 +27,7 @@ spec: {{- toYaml . | nindent 8 }} {{- end }} spec: - {{- with .Values.notifications.imagePullSecrets }} + {{- with .Values.notifications.imagePullSecrets | default .Values.global.imagePullSecrets }} imagePullSecrets: {{- toYaml . | nindent 8 }} {{- end }}