DevFW-CICD/argocd-helm
12
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(argo-cd): hard coded .selector.matchLabels (#603)

Browse source 
* fix(argo-cd): hard coded .selector.matchLabels

it fixes #602

Signed-off-by: abdennour <mail@abdennoor.com>

* style(argo-cd): linting circle ci

 error    too many blank lines

it fixes #602

Signed-off-by: abdennour <mail@abdennoor.com>

* chore(argo-cd): adding myself to codeowners

it is related to #602

Signed-off-by: abdennour <mail@abdennoor.com>

* chore(argo-cd): CODEOWNER work by invitation

related to #603 #602

Signed-off-by: abdennour <mail@abdennoor.com>

* fix(argo-cd): Add info in README about labels

Signed-off-by: Sean Johnson <seanson@users.noreply.github.com>

Co-authored-by: Sean Johnson <seanson@users.noreply.github.com>
This commit is contained in:
abdennour 2021-03-08 02:07:12 +03:00 committed by GitHub
parent 22b0811090
commit 0bc4be4e2a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
charts/argo-cd/Chart.yaml
View file

@ -2,7 +2,7 @@ apiVersion: v1
appVersion: 1.8.4 appVersion: 1.8.4
description: A Helm chart for ArgoCD, a declarative, GitOps continuous delivery tool for Kubernetes. description: A Helm chart for ArgoCD, a declarative, GitOps continuous delivery tool for Kubernetes.
name: argo-cd name: argo-cd
version: 2.14.7 version: 2.14.8
home: https://github.com/argoproj/argo-helm home: https://github.com/argoproj/argo-helm
icon: https://raw.githubusercontent.com/argoproj/argo/master/docs/assets/argo.png icon: https://raw.githubusercontent.com/argoproj/argo/master/docs/assets/argo.png
keywords: keywords:

4
charts/argo-cd/README.md
View file

@ -14,6 +14,10 @@ This chart currently installs the non-HA version of ArgoCD.
## Upgrading ## Upgrading
### 2.14.7 and above
The `matchLabels` key in the ArgoCD Appliaction Controller is no longer hard-coded. Note that labels are immutable so caution should be exercised when making changes to this resource.
### 2.10.x to 2.11.0 ### 2.10.x to 2.11.0
The application controller is now available as a `StatefulSet` when the `controller.enableStatefulSet` flag is set to true. Depending on your Helm deployment this may be a downtime or breaking change if enabled when using HA and will become the default in 3.x. The application controller is now available as a `StatefulSet` when the `controller.enableStatefulSet` flag is set to true. Depending on your Helm deployment this may be a downtime or breaking change if enabled when using HA and will become the default in 3.x.

2
charts/argo-cd/templates/argocd-application-controller/deployment.yaml
View file

@ -14,7 +14,7 @@ metadata:
spec: spec:
selector: selector:
matchLabels: matchLabels:
app.kubernetes.io/name: {{ include "argo-cd.name" . }}-application-controller app.kubernetes.io/name: {{ include "argo-cd.name" . }}-{{ .Values.controller.name }}
app.kubernetes.io/instance: {{ .Release.Name }} app.kubernetes.io/instance: {{ .Release.Name }}
{{- if .Values.controller.enableStatefulSet }} {{- if .Values.controller.enableStatefulSet }}
serviceName: {{ template "argo-cd.controller.fullname" . }} serviceName: {{ template "argo-cd.controller.fullname" . }}