From 13653251bd86d68ba37b3897a4ca1298320bb053 Mon Sep 17 00:00:00 2001
From: Dan Tulovsky <dant@lightstep.com>
Date: Sun, 17 Oct 2021 09:14:22 -0400
Subject: [PATCH] Address review comments:

Remove old changes annotation.
Rename serviceType to service.type.

Signed-off-by: Dan Tulovsky <dant@lightstep.com>
---
 charts/argo-rollouts/Chart.yaml                       | 1 -
 charts/argo-rollouts/templates/dashboard/service.yaml | 2 +-
 charts/argo-rollouts/values.yaml                      | 3 ++-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/charts/argo-rollouts/Chart.yaml b/charts/argo-rollouts/Chart.yaml
index a6e59f26..6edff070 100644
--- a/charts/argo-rollouts/Chart.yaml
+++ b/charts/argo-rollouts/Chart.yaml
@@ -11,5 +11,4 @@ maintainers:
   - name: jessesuen
 annotations:
   artifacthub.io/changes: |
-    - "[Changed]: updated rollouts version to 1.1.0 and updated CRDs to reflect the version bump"
     - "[Added]: Ability to set the type of Service on the dashboard Service.
diff --git a/charts/argo-rollouts/templates/dashboard/service.yaml b/charts/argo-rollouts/templates/dashboard/service.yaml
index c950fb3a..b8605c58 100644
--- a/charts/argo-rollouts/templates/dashboard/service.yaml
+++ b/charts/argo-rollouts/templates/dashboard/service.yaml
@@ -11,7 +11,7 @@ metadata:
     {{- toYaml . | nindent 4 }}
   {{- end }}
 spec:
-  type: {{ .Values.dashboard.serviceType | default "ClusterIP" }}
+  type: {{ .Values.dashboard.service.type }}
   ports:
   - name: dashboard
     protocol: TCP
diff --git a/charts/argo-rollouts/values.yaml b/charts/argo-rollouts/values.yaml
index 0ca86c93..a19dde08 100644
--- a/charts/argo-rollouts/values.yaml
+++ b/charts/argo-rollouts/values.yaml
@@ -114,7 +114,8 @@ dashboard:
   podSecurityContext:
     runAsNonRoot: true
   containerSecurityContext: {}
-  serviceType: ClusterIP
+  service:
+   tType: ClusterIP
   serviceAccount:
     create: true
     annotations: {}