fix(argocd-applicationset): Cleanup old CRD installation method (#827)

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

charts/argocd-applicationset/.helmignore

@@ -21,3 +21,4 @@
 .idea/
 *.tmproj
 .vscode/
+ci/

charts/argocd-applicationset/Chart.yaml

@@ -2,10 +2,10 @@ apiVersion: v2
 name: argocd-applicationset
 description: A Helm chart for installing ArgoCD ApplicationSet
 type: application
-version: 0.1.7
+version: 1.0.0
 appVersion: "v0.1.0"
 home: https://github.com/argoproj/argo-helm
-icon: https://raw.githubusercontent.com/argoproj/argo/master/docs/assets/argo.png
+icon: https://argocd-applicationset.readthedocs.io/en/stable/assets/logo.png
 keywords:
   - argoproj
   - appset
@@ -14,4 +14,6 @@ maintainers:
   - name: maruina
 annotations:
   artifacthub.io/changes: |
-    - "[Added]: Initialize Changelog"
+    - "[Removed]: CRD installation via templates folder. CRDs are now only handled via the '/crds' folder in the same way like the ArgoCD chart."
+    - "[Removed]: Exclude '/ci' folder from being packaged into the final chart archive."
+    - "[Changed]: Fix icon url"

charts/argocd-applicationset/README.md

@@ -10,6 +10,11 @@ This is a **community maintained** chart. This chart installs the [applicationse
 
 This chart currently installs the non-HA version of Argo CD ApplicationSet.
 
+## Prerequisites
+
+- Helm v3.0.0+
+- The ApplicationSet controller **must** be installed into the same namespace as the Argo CD it is targetting.
+
 ## Installing the Chart
 
 To install the chart with the release name `my-release`:
@@ -23,10 +28,6 @@ NAME: my-release
 ...
 ```
 
-### Helm v3 Compatibility
-
-Users of Helm v3 should set the `installCRDs` value to `false` to avoid warnings about nonexistent webhooks.
-
 ### Testing
 
 Users can test the chart with [kind](https://kind.sigs.k8s.io/) and [ct](https://github.com/helm/chart-testing).
@@ -38,6 +39,19 @@ kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/st
 ct install --namespace argocd
 ```
 
+## Notes on CRD Installation
+
+Some users would prefer to install the CRDs _outside_ of the chart. You can disable the CRD installation of this chart by using `--skip-crds` when installing the chart.
+
+You then can install the CRDs manually from `crds` folder or via the manifests from the upstream project repo:
+
+```console
+kubectl apply -k https://github.com/argoproj-labs/applicationset.git/manifests/crds?ref=<appVersion>
+
+# Eg. version v0.1.0
+kubectl apply -k https://github.com/argoproj-labs/applicationset.git/manifests/crds?ref=v0.1.0
+```
+
 ## Values
 
 | Key | Type | Default | Description |
@@ -56,7 +70,6 @@ ct install --namespace argocd
 | image.repository | string | `"quay.io/argocdapplicationset/argocd-applicationset"` | If defined, a repository applied to the ApplicationSet deployment. |
 | image.tag | string | `""` | Overrides the image tag whose default is the chart appVersion. |
 | imagePullSecrets | list | `[]` | If defined, uses a Secret to pull an image from a private Docker registry or repository. |
-| installCRDs | bool | `true` | Install Custom Resource Definition |
 | mountSSHKnownHostsVolume | bool | `true` | Mount the `argocd-ssh-known-hosts-cm` volume |
 | mountTLSCertsVolume | bool | `true` | Mount the `argocd-tls-certs-cm` volume |
 | mountGPGKeysVolume | bool | `false` | Mount the `argocd-gpg-keys-cm` volume |

charts/argocd-applicationset/ci/default-values.yaml

@@ -4,8 +4,6 @@
 
 replicaCount: 1
 
-installCRDs: false # this needs to be false with ct
-
 image:
   # The image repository
   repository: quay.io/argocdapplicationset/argocd-applicationset

charts/argocd-applicationset/ci/leader-election-values.yaml

@@ -2,5 +2,3 @@ args:
   enableLeaderElection: true
 
 replicaCount: 3
-
-installCRDs: false

charts/argocd-applicationset/templates/crds.yaml

@@ -1,6 +0,0 @@
-{{- if .Values.installCRDs }}
-{{- range $path, $_ := .Files.Glob "crds/*.yaml" }}
-{{ $.Files.Get $path }}
----
-{{- end }}
-{{- end }}

charts/argocd-applicationset/values.yaml

@@ -4,8 +4,6 @@
 
 replicaCount: 1
 
-installCRDs: true
-
 image:
   # The image repository
   repository: quay.io/argocdapplicationset/argocd-applicationset