From 15d51906734d17f93a49161055fe6a20f0e00155 Mon Sep 17 00:00:00 2001
From: Noam Gal <noam.gal@octopus.com>
Date: Sun, 12 May 2024 17:50:00 +0300
Subject: [PATCH] renamed `cf-notifications` to `cfNotifications`

added default value, updated readme
---
 charts/argo-cd/README.md                               |  1 +
 .../argocd-configs/argocd-notifications-cm.yaml        | 10 +++++-----
 charts/argo-cd/values.yaml                             |  3 +++
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/charts/argo-cd/README.md b/charts/argo-cd/README.md
index 68866a00..00d7b98b 100644
--- a/charts/argo-cd/README.md
+++ b/charts/argo-cd/README.md
@@ -611,6 +611,7 @@ NAME: my-release
 | apiVersionOverrides | object | `{}` |  |
 | applicationVersioning.enabled | bool | `true` | enables the Codefresh application versioning feature |
 | applicationVersioning.useApplicationConfiguration | bool | `true` | use ApplicationConfiguration CRD to manage application versioning |
+| cfNotifications | object | `{}` |  |
 | crds.additionalLabels | object | `{}` | Addtional labels to be added to all CRDs |
 | crds.annotations | object | `{}` | Annotations to be added to all CRDs |
 | crds.install | bool | `true` | Install and upgrade CRDs |
diff --git a/charts/argo-cd/templates/argocd-configs/argocd-notifications-cm.yaml b/charts/argo-cd/templates/argocd-configs/argocd-notifications-cm.yaml
index fefbd3a8..d921402c 100644
--- a/charts/argo-cd/templates/argocd-configs/argocd-notifications-cm.yaml
+++ b/charts/argo-cd/templates/argocd-configs/argocd-notifications-cm.yaml
@@ -12,7 +12,7 @@ data:
     {{- with .Values.notifications.context }}
       {{- toYaml . | nindent 4 }}
     {{- end }}
-    {{- with .Values.cf-notifications.context }}
+    {{- with .Values.cfNotifications.context }}
       {{- toYaml . | nindent 4 }}
     {{- end }}
   {{- with .Values.notifications.notifiers }}
@@ -22,7 +22,7 @@ data:
     {{- with .Values.notifications.subscriptions }}
       {{- toYaml . | nindent 4 }}
     {{- end }}
-    {{- with .Values.cf-notifications.subscriptions }}
+    {{- with .Values.cfNotifications.subscriptions }}
       {{- toYaml . | nindent 4 }}
     {{- end }}
   {{- with .Values.notifications.templates }}
@@ -32,13 +32,13 @@ data:
     {{- toYaml . | nindent 2 }}
   {{- end }}
 
-  {{- with .Values.cf-notifications.notifiers }}
+  {{- with .Values.cfNotifications.notifiers }}
     {{- toYaml . | nindent 2 }}
   {{- end }}
-  {{- with .Values.cf-notifications.templates }}
+  {{- with .Values.cfNotifications.templates }}
     {{- toYaml . | nindent 2 }}
   {{- end }}
-  {{- with .Values.cf-notifications.triggers }}
+  {{- with .Values.cfNotifications.triggers }}
     {{- toYaml . | nindent 2 }}
   {{- end }}
 {{- end }}
diff --git a/charts/argo-cd/values.yaml b/charts/argo-cd/values.yaml
index 205c1e01..af5d3c80 100644
--- a/charts/argo-cd/values.yaml
+++ b/charts/argo-cd/values.yaml
@@ -3543,6 +3543,9 @@ notifications:
     # defaultTriggers: |
     #   - on-sync-status-unknown
 
+## Used by gitops-runtime-helm chart
+cfNotifications: {}
+
 eventReporter:
   # Enabled we need to skip argo-cd chart tests for this component
   enabled: true