From 715a43652ac75d11402c391b37d034d801ad49fe Mon Sep 17 00:00:00 2001 From: kostas-theo Date: Fri, 30 Apr 2021 18:45:38 +0200 Subject: [PATCH 1/2] fix: review recommendation Signed-off-by: kostas-theo --- charts/argo-events/templates/argo-events-sa.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/charts/argo-events/templates/argo-events-sa.yaml b/charts/argo-events/templates/argo-events-sa.yaml index f13b8a1d..9f877b64 100644 --- a/charts/argo-events/templates/argo-events-sa.yaml +++ b/charts/argo-events/templates/argo-events-sa.yaml @@ -5,6 +5,9 @@ kind: ServiceAccount metadata: name: {{ .Values.serviceAccount }} namespace: {{ .Release.Namespace }} + {{- if .Values.serviceAccountAnnotations }} + annotations: {{- toYaml .Values.serviceAccountAnnotations | nindent 4 }} + {{- end }} {{- if .Values.additionalSaNamespaces }} {{ $sa := .Values.serviceAccount }} {{- range $namespace := .Values.additionalSaNamespaces }} From bf91403d70fe82610142bb57efa9e34b6e84ef97 Mon Sep 17 00:00:00 2001 From: kostas-theo Date: Fri, 30 Apr 2021 19:14:20 +0200 Subject: [PATCH 2/2] fix: readd lost commits Signed-off-by: kostas-theo --- charts/argo-events/Chart.yaml | 2 +- charts/argo-events/values.yaml | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/charts/argo-events/Chart.yaml b/charts/argo-events/Chart.yaml index fcea120d..c40f5a6f 100644 --- a/charts/argo-events/Chart.yaml +++ b/charts/argo-events/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v2 description: A Helm chart to install Argo-Events in k8s Cluster name: argo-events -version: 1.2.4 +version: 1.3.4 keywords: - argo-events - sensor-controller diff --git a/charts/argo-events/values.yaml b/charts/argo-events/values.yaml index 05a8d634..6285158d 100644 --- a/charts/argo-events/values.yaml +++ b/charts/argo-events/values.yaml @@ -14,6 +14,9 @@ installCRD: true # ServiceAccount to use for running controller. serviceAccount: argo-events-sa +# Add annotations to the service account for enabling GKE workload identity or any other use case +serviceAccountAnnotations: {} + # Create service accounts in additional namespaces specified # The SA will always be created in the release namespaces additionalSaNamespaces: []