From 1a2c4b6388353db73ab55e482290e32605b04eeb Mon Sep 17 00:00:00 2001
From: reinvantveer <rein.van.t.veer@geodan.nl>
Date: Mon, 12 Jul 2021 14:10:54 +0200
Subject: [PATCH] compress namespaces from controller.workflowNamespaces and
 workflow.namespace into single loop iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
---
 .../templates/controller/workflow-role.yaml     | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/charts/argo-workflows/templates/controller/workflow-role.yaml b/charts/argo-workflows/templates/controller/workflow-role.yaml
index 4dc2e7da..f60c9889 100644
--- a/charts/argo-workflows/templates/controller/workflow-role.yaml
+++ b/charts/argo-workflows/templates/controller/workflow-role.yaml
@@ -28,22 +28,11 @@ rules:
 
 {{- if .Values.workflow.rbac.create -}}
 
-  {{- if .Values.controller.workflowNamespaces }}
-    {{- range .Values.controller.workflowNamespaces}}
-      {{ $namespace := . }}
-      {{- include "workflow-role-base" . }}
-  name: {{ template "argo-workflows.fullname" $ }}-workflow
-  namespace: {{ $namespace }}
-      {{- include "workflow-role-rules" . }}
-    {{- end }}
-
-  {{- else }}
-
+  {{- range $namespace := append .Values.controller.workflowNamespaces .Values.workflow.namespace | compact | uniq }}
+    {{ $namespace := . }}
     {{- include "workflow-role-base" . }}
   name: {{ template "argo-workflows.fullname" $ }}-workflow
-    {{- if .Values.workflow.namespace }}
-  namespace: {{ .Values.workflow.namespace }}
-    {{- end }}
+  namespace: {{ $namespace }}
     {{- include "workflow-role-rules" . }}
   {{- end }}