From 2151f800f24fd81be55315654d765e3d76ea66fa Mon Sep 17 00:00:00 2001 From: Martin Bouillaud Date: Thu, 13 Mar 2025 15:59:12 +0100 Subject: [PATCH] feat(argo-events): Add revisionhistorylimit webhook controller (#3196) * add: webhook & controller revisionHistoryLimit to values.yaml Signed-off-by: Martin Bouillaud Signed-off-by: Martin Bouillaud * add default value to revisionHistoryLimit Signed-off-by: Martin Bouillaud Signed-off-by: Martin Bouillaud * trim default values in deployment Signed-off-by: Martin Bouillaud * fix: webhook typo Signed-off-by: Martin Bouillaud --------- Signed-off-by: Martin Bouillaud Signed-off-by: Martin Bouillaud Co-authored-by: Martin Bouillaud Co-authored-by: Aikawa --- charts/argo-events/Chart.yaml | 6 +++--- charts/argo-events/README.md | 2 ++ .../templates/argo-events-controller/deployment.yaml | 2 +- .../templates/argo-events-webhook/deployment.yaml | 2 +- charts/argo-events/values.yaml | 6 ++++++ 5 files changed, 13 insertions(+), 5 deletions(-) diff --git a/charts/argo-events/Chart.yaml b/charts/argo-events/Chart.yaml index a184cb91..d5a6bb61 100644 --- a/charts/argo-events/Chart.yaml +++ b/charts/argo-events/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 appVersion: v1.9.5 description: A Helm chart for Argo Events, the event-driven workflow automation framework name: argo-events -version: 2.4.13 +version: 2.4.14 home: https://github.com/argoproj/argo-helm icon: https://avatars.githubusercontent.com/u/30269780?s=200&v=4 keywords: @@ -18,5 +18,5 @@ annotations: fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252 url: https://argoproj.github.io/argo-helm/pgp_keys.asc artifacthub.io/changes: | - - kind: changed - description: Bump argo-events to v1.9.5 + - kind: added + description: Add revisionHistoryLimit to values diff --git a/charts/argo-events/README.md b/charts/argo-events/README.md index 7e9f6e37..bc1ad5e8 100644 --- a/charts/argo-events/README.md +++ b/charts/argo-events/README.md @@ -180,6 +180,7 @@ done | controller.readinessProbe.timeoutSeconds | int | `1` | Number of seconds after which the [probe] times out | | controller.replicas | int | `1` | The number of events controller pods to run. | | controller.resources | object | `{}` | Resource limits and requests for the events controller pods | +| controller.revisionHistoryLimit | int | `5` | The number of replicasets history to keep | | controller.serviceAccount.annotations | object | `{}` | Annotations applied to created service account | | controller.serviceAccount.automountServiceAccountToken | bool | `true` | Automount API credentials for the Service Account | | controller.serviceAccount.create | bool | `true` | Create a service account for the events controller | @@ -222,6 +223,7 @@ done | webhook.readinessProbe.timeoutSeconds | int | `1` | Number of seconds after which the [probe] times out | | webhook.replicas | int | `1` | The number of webhook pods to run. | | webhook.resources | object | `{}` | Resource limits and requests for the event controller pods | +| webhook.revisionHistoryLimit | int | `5` | The number of replicasets history to keep | | webhook.serviceAccount.annotations | object | `{}` | Annotations applied to created service account | | webhook.serviceAccount.automountServiceAccountToken | bool | `true` | Automount API credentials for the Service Account | | webhook.serviceAccount.create | bool | `true` | Create a service account for the admission webhook | diff --git a/charts/argo-events/templates/argo-events-controller/deployment.yaml b/charts/argo-events/templates/argo-events-controller/deployment.yaml index 17bf0a6a..12f1faf9 100644 --- a/charts/argo-events/templates/argo-events-controller/deployment.yaml +++ b/charts/argo-events/templates/argo-events-controller/deployment.yaml @@ -10,7 +10,7 @@ spec: selector: matchLabels: {{- include "argo-events.selectorLabels" (dict "context" . "name" .Values.controller.name) | nindent 6 }} - revisionHistoryLimit: 5 + revisionHistoryLimit: {{ .Values.controller.revisionHistoryLimit }} replicas: {{ .Values.controller.replicas }} template: metadata: diff --git a/charts/argo-events/templates/argo-events-webhook/deployment.yaml b/charts/argo-events/templates/argo-events-webhook/deployment.yaml index 0b995ba2..82a1ab59 100644 --- a/charts/argo-events/templates/argo-events-webhook/deployment.yaml +++ b/charts/argo-events/templates/argo-events-webhook/deployment.yaml @@ -11,7 +11,7 @@ spec: selector: matchLabels: {{- include "argo-events.selectorLabels" (dict "context" . "name" .Values.webhook.name) | nindent 6 }} - revisionHistoryLimit: 5 + revisionHistoryLimit: {{ .Values.webhook.revisionHistoryLimit }} replicas: {{ .Values.webhook.replicas }} template: metadata: diff --git a/charts/argo-events/values.yaml b/charts/argo-events/values.yaml index fb9878c9..03429b50 100644 --- a/charts/argo-events/values.yaml +++ b/charts/argo-events/values.yaml @@ -201,6 +201,9 @@ controller: # @default -- `""` (defaults to global.image.imagePullPolicy) imagePullPolicy: "" + # -- The number of replicasets history to keep + revisionHistoryLimit: 5 + # -- The number of events controller pods to run. replicas: 1 @@ -363,6 +366,9 @@ webhook: # @default -- `""` (defaults to global.image.imagePullPolicy) imagePullPolicy: "" + # -- The number of replicasets history to keep + revisionHistoryLimit: 5 + # -- The number of webhook pods to run. replicas: 1