fix: Hotfix server.baseHref value not being used (#261)

This commit is contained in:
Trevor Foster 2020-03-13 11:04:31 -04:00 committed by GitHub
parent 664829aa24
commit 219778eb9d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 3 deletions

View file

@ -2,7 +2,7 @@ apiVersion: v1
appVersion: "v2.6.1" appVersion: "v2.6.1"
description: A Helm chart for Argo Workflows description: A Helm chart for Argo Workflows
name: argo name: argo
version: 0.7.1 version: 0.7.2
icon: https://raw.githubusercontent.com/argoproj/argo/master/docs/assets/argo.png icon: https://raw.githubusercontent.com/argoproj/argo/master/docs/assets/argo.png
home: https://github.com/argoproj/argo-helm home: https://github.com/argoproj/argo-helm
maintainers: maintainers:

View file

@ -59,7 +59,7 @@ spec:
apiVersion: v1 apiVersion: v1
fieldPath: metadata.namespace fieldPath: metadata.namespace
- name: BASE_HREF - name: BASE_HREF
value: / value: {{ .Values.server.baseHref | quote }}
resources: resources:
{{- toYaml .Values.server.resources | nindent 12 }} {{- toYaml .Values.server.resources | nindent 12 }}
{{- with .Values.server.nodeSelector }} {{- with .Values.server.nodeSelector }}

View file

@ -104,7 +104,9 @@ server:
enabled: true enabled: true
# only show workflows where UI installed # only show workflows where UI installed
forceNamespaceIsolation: false forceNamespaceIsolation: false
# UI BASE_HREF env variable # only updates base url of resources on client side,
# it's expected that a proxy server rewrites the request URL and gets rid of this prefix
# https://github.com/argoproj/argo/issues/716#issuecomment-433213190
baseHref: / baseHref: /
image: image:
# Overrides .images.tag if defined. # Overrides .images.tag if defined.