From 3088cf68b29a84733502f978c5a214af6e048a57 Mon Sep 17 00:00:00 2001 From: Michiel De Mey Date: Mon, 22 Nov 2021 10:40:42 +0100 Subject: [PATCH] feat(argo-workflows): Include pod name in key format for GCS logs (#915) * feat(argo-workflows) Include pod name in key format for GCS logs A better default would be to add the `pod.name` to the key format of the Argo logs. I noticed that when not including the pod name, it would constantly overwrite the same log from from different pods. Including it makes sure that each pod will have its own log file. Signed-off-by: Michiel De Mey * Bump chart version and added changelog Signed-off-by: Michiel De Mey Co-authored-by: Marco Kilchhofer --- charts/argo-workflows/Chart.yaml | 4 ++-- charts/argo-workflows/values.yaml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/argo-workflows/Chart.yaml b/charts/argo-workflows/Chart.yaml index ed425839..39a1cf1f 100644 --- a/charts/argo-workflows/Chart.yaml +++ b/charts/argo-workflows/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: argo-workflows description: A Helm chart for Argo Workflows type: application -version: 0.9.0 +version: 0.9.1 appVersion: v3.2.4 icon: https://raw.githubusercontent.com/argoproj/argo-workflows/master/docs/assets/argo.png home: https://github.com/argoproj/argo-helm @@ -15,4 +15,4 @@ maintainers: - name: benjaminws annotations: artifacthub.io/changes: | - - "[Added]: support resourceRateLimit config" + - "[Changed]: Changed default GCP keyFormat" diff --git a/charts/argo-workflows/values.yaml b/charts/argo-workflows/values.yaml index 6548ead4..abc3f6d2 100644 --- a/charts/argo-workflows/values.yaml +++ b/charts/argo-workflows/values.yaml @@ -476,7 +476,7 @@ artifactRepository: # @default -- `{}` (See [values.yaml]) gcs: {} # bucket: -argo - # keyFormat: "{{workflow.namespace}}/{{workflow.name}}/" + # keyFormat: "{{workflow.namespace}}/{{workflow.name}}/{{pod.name}}" # serviceAccountKeySecret is a secret selector. # It references the k8s secret named 'my-gcs-credentials'. # This secret is expected to have have the key 'serviceAccountKey',