diff --git a/charts/argo-workflows/Chart.yaml b/charts/argo-workflows/Chart.yaml index 0aafb850..0c3dbf47 100644 --- a/charts/argo-workflows/Chart.yaml +++ b/charts/argo-workflows/Chart.yaml @@ -3,7 +3,7 @@ appVersion: v3.4.2 name: argo-workflows description: A Helm chart for Argo Workflows type: application -version: 0.20.3 +version: 0.20.4 icon: https://raw.githubusercontent.com/argoproj/argo-workflows/master/docs/assets/argo.png home: https://github.com/argoproj/argo-helm sources: @@ -13,4 +13,4 @@ maintainers: url: https://argoproj.github.io/ annotations: artifacthub.io/changes: | - - "[Changed]: Update ArgoWorkflows to v3.4.2" + - "[Changed]: Enable to set different imagePullPolicy for mainContainer and executor" diff --git a/charts/argo-workflows/README.md b/charts/argo-workflows/README.md index 492f073e..3d9c4d10 100644 --- a/charts/argo-workflows/README.md +++ b/charts/argo-workflows/README.md @@ -142,7 +142,7 @@ Fields to note: | Key | Type | Default | Description | |-----|------|---------|-------------| | mainContainer.env | list | `[]` | Adds environment variables for the Workflow main container | -| mainContainer.imagePullPolicy | string | `"Always"` | imagePullPolicy to apply to Workflow main container | +| mainContainer.imagePullPolicy | string | `""` | imagePullPolicy to apply to Workflow main container. Defaults to `.Values.images.pullPolicy`. | | mainContainer.resources | object | `{}` | Resource limits and requests for the Workflow main container | | mainContainer.securityContext | object | `{}` | sets security context for the Workflow main container | @@ -151,6 +151,7 @@ Fields to note: | Key | Type | Default | Description | |-----|------|---------|-------------| | executor.env | list | `[]` | Adds environment variables for the executor. | +| executor.image.pullPolicy | string | `""` | Image PullPolicy to use for the Workflow Executors. Defaults to `.Values.images.pullPolicy`. | | executor.image.registry | string | `"quay.io"` | Registry to use for the Workflow Executors | | executor.image.repository | string | `"argoproj/argoexec"` | Repository to use for the Workflow Executors | | executor.image.tag | string | `""` | Image tag for the workflow executor. Defaults to `.Values.images.tag`. | diff --git a/charts/argo-workflows/templates/controller/workflow-controller-config-map.yaml b/charts/argo-workflows/templates/controller/workflow-controller-config-map.yaml index c0130ba7..0e79514c 100644 --- a/charts/argo-workflows/templates/controller/workflow-controller-config-map.yaml +++ b/charts/argo-workflows/templates/controller/workflow-controller-config-map.yaml @@ -27,7 +27,7 @@ data: {{- end }} {{- if or .Values.mainContainer.resources .Values.mainContainer.env .Values.mainContainer.securityContext}} mainContainer: - imagePullPolicy: {{ .Values.images.pullPolicy }} + imagePullPolicy: {{ default (.Values.images.pullPolicy) .Values.mainContainer.imagePullPolicy }} {{- with .Values.mainContainer.resources }} resources: {{- toYaml . | nindent 8 }} {{- end }} @@ -40,7 +40,7 @@ data: {{- end }} {{- if or .Values.executor.resources .Values.executor.env .Values.executor.securityContext}} executor: - imagePullPolicy: {{ .Values.images.pullPolicy }} + imagePullPolicy: {{ default (.Values.images.pullPolicy) .Values.executor.image.pullPolicy }} {{- with .Values.executor.resources }} resources: {{- toYaml . | nindent 8 }} {{- end }} diff --git a/charts/argo-workflows/values.yaml b/charts/argo-workflows/values.yaml index f32ebd32..1e2faa30 100644 --- a/charts/argo-workflows/values.yaml +++ b/charts/argo-workflows/values.yaml @@ -287,8 +287,8 @@ controller: # mainContainer adds default config for main container that could be overriden in workflows template mainContainer: - # -- imagePullPolicy to apply to Workflow main container - imagePullPolicy: Always + # -- imagePullPolicy to apply to Workflow main container. Defaults to `.Values.images.pullPolicy`. + imagePullPolicy: "" # -- Resource limits and requests for the Workflow main container resources: {} # -- Adds environment variables for the Workflow main container @@ -305,6 +305,8 @@ executor: repository: argoproj/argoexec # -- Image tag for the workflow executor. Defaults to `.Values.images.tag`. tag: "" + # -- Image PullPolicy to use for the Workflow Executors. Defaults to `.Values.images.pullPolicy`. + pullPolicy: "" # -- Resource limits and requests for the Workflow Executors resources: {} # -- Adds environment variables for the executor.