DevFW-CICD/argocd-helm
14
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(argo-cd): Parameterizing dex ports names due to istio 403 errors (#889)

Browse source 
* refactor: Parameterizing dex ports names due to istio 403 errors

Signed-off-by: Piotr Kowalczyk <kowalczyk.p.4@pg.com>

* fix: updating default http port name to http

Signed-off-by: Piotr Kowalczyk <kowalczyk.p.4@pg.com>
This commit is contained in:
Piotr Kowalczyk 2021-08-23 19:23:07 +02:00 committed by GitHub
parent 573a7494d4
commit 3a4baae95d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
charts/argo-cd/Chart.yaml
View file

@ -2,7 +2,7 @@ apiVersion: v2
appVersion: 2.1.0 appVersion: 2.1.0
description: A Helm chart for ArgoCD, a declarative, GitOps continuous delivery tool for Kubernetes. description: A Helm chart for ArgoCD, a declarative, GitOps continuous delivery tool for Kubernetes.
name: argo-cd name: argo-cd
version: 3.13.1 version: 3.13.2
home: https://github.com/argoproj/argo-helm home: https://github.com/argoproj/argo-helm
icon: https://argoproj.github.io/argo-cd/assets/logo.png icon: https://argoproj.github.io/argo-cd/assets/logo.png
keywords: keywords:
@ -21,4 +21,4 @@ dependencies:
condition: redis-ha.enabled condition: redis-ha.enabled
annotations: annotations:
artifacthub.io/changes: | artifacthub.io/changes: |
- "[Fixed]: Updated README.md for ArgoCD" - "[Changed]: Parameterized dex service port names for istio-ingress 403 error"

2
charts/argo-cd/README.md
View file

@ -397,7 +397,9 @@ NAME: my-release
| dex.serviceAccount.create | Create dex service account | `true` | | dex.serviceAccount.create | Create dex service account | `true` |
| dex.serviceAccount.name | Dex service account name | `"argocd-dex-server"` | | dex.serviceAccount.name | Dex service account name | `"argocd-dex-server"` |
| dex.servicePortGrpc | Server GRPC port | `5557` | | dex.servicePortGrpc | Server GRPC port | `5557` |
| dex.servicePortGrpcName | Server GRPC port name | `grpc` |
| dex.servicePortHttp | Server HTTP port | `5556` | | dex.servicePortHttp | Server HTTP port | `5556` |
| dex.servicePortHttpName | Server GRPC port name | `http` |
| dex.tolerations | [Tolerations for use with node taints](https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/) | `[]` | | dex.tolerations | [Tolerations for use with node taints](https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/) | `[]` |
| dex.volumeMounts | Dex volume mounts | `"/shared"` | | dex.volumeMounts | Dex volume mounts | `"/shared"` |
| dex.volumes | Dex volumes | `{}` | | dex.volumes | Dex volumes | `{}` |

4
charts/argo-cd/templates/dex/service.yaml
View file

@ -16,11 +16,11 @@ metadata:
{{- end }} {{- end }}
spec: spec:
ports: ports:
- name: http - name: {{ .Values.dex.servicePortHttpName }}
protocol: TCP protocol: TCP
port: {{ .Values.dex.servicePortHttp }} port: {{ .Values.dex.servicePortHttp }}
targetPort: http targetPort: http
- name: grpc - name: {{ .Values.dex.servicePortGrpcName }}
protocol: TCP protocol: TCP
port: {{ .Values.dex.servicePortGrpc }} port: {{ .Values.dex.servicePortGrpc }}
targetPort: grpc targetPort: grpc

2
charts/argo-cd/values.yaml
View file

@ -280,8 +280,10 @@ dex:
## Dex deployment container ports ## Dex deployment container ports
containerPortHttp: 5556 containerPortHttp: 5556
servicePortHttp: 5556 servicePortHttp: 5556
servicePortHttpName: http
containerPortGrpc: 5557 containerPortGrpc: 5557
servicePortGrpc: 5557 servicePortGrpc: 5557
servicePortGrpcName: grpc
containerPortMetrics: 5558 containerPortMetrics: 5558
servicePortMetrics: 5558 servicePortMetrics: 5558