From 3c148bc247c9b12f9d096882cf6fd91667fc65e9 Mon Sep 17 00:00:00 2001 From: Andy Feller Date: Wed, 3 Jun 2020 07:41:32 -0400 Subject: [PATCH] Updated testing notes, linting changes --- CONTRIBUTING.md | 10 ++++++++++ charts/argocd-notifications/Chart.yaml | 2 ++ charts/argocd-notifications/values.yaml | 4 ++-- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ba764f3c..72303016 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -51,6 +51,16 @@ argocd app create guestbook --dest-namespace default --dest-server https://kuber argocd app sync guestbook ``` +## Testing Argo CD Notification Changes + +Thorough testing of argocd-notifications would require one or more notification services (Slack, OpsGenie, etc), however +minimal testing mostly consists of successful Helm chart installation and the argocd-notifications controller having +access to the `Application` resources in the same namespace that Argo CD is installed. + +``` +helm install argocd-notifications charts/argocd-notifications --namespace argocd +``` + ## New Application Versions When raising application versions ensure you make the following changes: diff --git a/charts/argocd-notifications/Chart.yaml b/charts/argocd-notifications/Chart.yaml index 0fbf6b8f..0700ce4c 100644 --- a/charts/argocd-notifications/Chart.yaml +++ b/charts/argocd-notifications/Chart.yaml @@ -10,3 +10,5 @@ keywords: - argoproj - argocd - argocd-notifications +maintainers: + - name: alexmt diff --git a/charts/argocd-notifications/values.yaml b/charts/argocd-notifications/values.yaml index 9d0c27f2..362156df 100644 --- a/charts/argocd-notifications/values.yaml +++ b/charts/argocd-notifications/values.yaml @@ -22,10 +22,10 @@ secret: notifiers: # For more information: https://argoproj-labs.github.io/argocd-notifications/services/overview/ - + slack: # For more information: https://argoproj-labs.github.io/argocd-notifications/services/slack/ - + # Specifies whether Slack notifier should be configured enabled: false # OAuth Access Token