DevFW-CICD/argocd-helm
16
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(argo-workflows): Support images property to workflow-controller-configmap for emissary executor (#1708)

Browse source 
* feat(argo-workflows): Support images property to workflow-controller-configmap for emissary executor
Signed-off-by: yu-croco <yu.croco@gmail.com>

* chore(argo-workflows): adopt concise name
Signed-off-by: yu-croco <yu.croco@gmail.com>
This commit is contained in:
Aikawa 2022-12-19 08:41:56 +09:00 committed by GitHub
parent 3dcd161bf1
commit 3c8ad7be89
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
charts/argo-workflows/Chart.yaml
View file

@ -3,7 +3,7 @@ appVersion: v3.4.4
name: argo-workflows name: argo-workflows
description: A Helm chart for Argo Workflows description: A Helm chart for Argo Workflows
type: application type: application
version: 0.22.1 version: 0.22.2
icon: https://raw.githubusercontent.com/argoproj/argo-workflows/master/docs/assets/argo.png icon: https://raw.githubusercontent.com/argoproj/argo-workflows/master/docs/assets/argo.png
home: https://github.com/argoproj/argo-helm home: https://github.com/argoproj/argo-helm
sources: sources:
@ -13,5 +13,4 @@ maintainers:
url: https://argoproj.github.io/ url: https://argoproj.github.io/
annotations: annotations:
artifacthub.io/changes: | artifacthub.io/changes: |
- "[Fixed]: avoid app.kubernetes.io/version kubernetes label from exceeding maximum length (63) - "[Added]: Support images property to workflow-controller-configmap for emissary executor"
- "[Fixed]: generated value for app.kubernetes.io/version label is now valid even when defining a controller/server/executor.image.tag with a SHA digest"

1
charts/argo-workflows/README.md
View file

@ -45,6 +45,7 @@ Fields to note:
| crds.install | bool | `true` | Install and upgrade CRDs | | crds.install | bool | `true` | Install and upgrade CRDs |
| crds.keep | bool | `true` | Keep CRDs on chart uninstall | | crds.keep | bool | `true` | Keep CRDs on chart uninstall |
| createAggregateRoles | bool | `true` | Create clusterroles that extend existing clusterroles to interact with argo-cd crds | | createAggregateRoles | bool | `true` | Create clusterroles that extend existing clusterroles to interact with argo-cd crds |
| emissary.images | list | `[]` | The command/args for each image on workflow, needed when the command is not specified and the emissary executor is used. |
| extraObjects | list | `[]` | Array of extra K8s manifests to deploy | | extraObjects | list | `[]` | Array of extra K8s manifests to deploy |
| fullnameOverride | string | `nil` | String to fully override "argo-workflows.fullname" template | | fullnameOverride | string | `nil` | String to fully override "argo-workflows.fullname" template |
| images.pullPolicy | string | `"Always"` | imagePullPolicy to apply to all containers | | images.pullPolicy | string | `"Always"` | imagePullPolicy to apply to all containers |

3
charts/argo-workflows/templates/controller/workflow-controller-config-map.yaml
View file

@ -170,3 +170,6 @@ data:
{{- with .Values.controller.retentionPolicy }} {{- with .Values.controller.retentionPolicy }}
retentionPolicy: {{- toYaml . | nindent 6 }} retentionPolicy: {{- toYaml . | nindent 6 }}
{{- end }} {{- end }}
{{- with .Values.emissary.images }}
images: {{- toYaml . | nindent 6 }}
{{- end }}

9
charts/argo-workflows/values.yaml
View file

@ -630,3 +630,12 @@ customArtifactRepository: {}
# passwordSecret: # passwordSecret:
# name: artifactory-creds # name: artifactory-creds
# key: password # key: password
emissary:
# -- The command/args for each image on workflow, needed when the command is not specified and the emissary executor is used.
## See more: https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary
images: []
# argoproj/argosay:v2:
# cmd: [/argosay]
# docker/whalesay:latest:
# cmd: [/bin/bash]