From 45ed060c2b1c986a0f60e937e9d3f255fe902fdd Mon Sep 17 00:00:00 2001 From: amaury ravanel Date: Mon, 28 Mar 2022 23:01:54 +0200 Subject: [PATCH] fix(argo-cd): Correct ApplicationSet controller port (#1200) * Add default value for the applicationSet controller container port Signed-off-by: amaury ravanel * Apply suggestions from code review Signed-off-by: Marco Kilchhofer Co-authored-by: Marco Kilchhofer --- charts/argo-cd/Chart.yaml | 4 ++-- charts/argo-cd/templates/argocd-applicationset/service.yaml | 2 +- charts/argo-cd/values.yaml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/charts/argo-cd/Chart.yaml b/charts/argo-cd/Chart.yaml index 591f4655..bc32a964 100644 --- a/charts/argo-cd/Chart.yaml +++ b/charts/argo-cd/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 appVersion: v2.3.2 description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes. name: argo-cd -version: 4.2.3 +version: 4.2.4 home: https://github.com/argoproj/argo-helm icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png keywords: @@ -21,4 +21,4 @@ dependencies: condition: redis-ha.enabled annotations: artifacthub.io/changes: | - - "[Fixed]: Correct ArgoCD notification subscriptions type" + - "[Fixed]: Correct ArgoCD applicationset controller port" diff --git a/charts/argo-cd/templates/argocd-applicationset/service.yaml b/charts/argo-cd/templates/argocd-applicationset/service.yaml index db836f04..4d2fd4eb 100644 --- a/charts/argo-cd/templates/argocd-applicationset/service.yaml +++ b/charts/argo-cd/templates/argocd-applicationset/service.yaml @@ -15,7 +15,7 @@ spec: ports: - name: {{ .Values.applicationSet.service.portName }} port: {{ .Values.applicationSet.service.port }} - targetPort: {{ .Values.applicationSet.containerPort }} + targetPort: webhook selector: {{- include "argo-cd.selectorLabels" (dict "context" . "name" .Values.applicationSet.name) | nindent 4 }} {{- end }} diff --git a/charts/argo-cd/values.yaml b/charts/argo-cd/values.yaml index ca34549e..2a207250 100755 --- a/charts/argo-cd/values.yaml +++ b/charts/argo-cd/values.yaml @@ -1896,7 +1896,7 @@ applicationSet: # -- Additional containers to be added to the applicationset controller pod extraContainers: [] - ## Metrics service configuration + ## Metrics service configuration metrics: # -- Deploy metrics service enabled: false