Removes controller.enabled

As suggested, the controller should always be enabled.

charts/argo-cd/README.md

@@ -50,7 +50,6 @@ $ helm install --name my-release argo/argo-cd
 | controller.args.operationProcessors | define the controller `--operation-processors` | `"10"` |
 | controller.args.statusProcessors | define the controller `--status-processors` | `"20"` |
 | controller.containerPort | Controller listening port. | `8082` |
-| controller.enabled | Enable ArgoCD Controller | `true` |
 | controller.extraArgs | Additional arguments for the controller. | `[]` |
 | controller.image.repository | Repository to use for the controller | `global.image.repository` |
 | controller.image.imagePullPolicy | Image pull policy for the controller | `global.image.imagePullPolicy` |

charts/argo-cd/templates/argocd-application-controller/clusterrole.yaml

@@ -1,4 +1,3 @@
-{{- if .Values.controller.enabled }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
@@ -20,5 +19,4 @@ rules:
 - nonResourceURLs:
   - '*'
   verbs:
-  - '*'
+  - '*'
-{{- end }}

charts/argo-cd/templates/argocd-application-controller/clusterrolebinding.yaml

@@ -1,4 +1,3 @@
-{{- if .Values.controller.enabled }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
@@ -17,5 +16,4 @@ roleRef:
 subjects:
 - kind: ServiceAccount
   name: {{ template "argo-cd.controllerServiceAccountName" . }}
-  namespace: {{ .Release.Namespace }}
+  namespace: {{ .Release.Namespace }}
-{{- end -}}

charts/argo-cd/templates/argocd-application-controller/deployment.yaml

@@ -1,4 +1,3 @@
-{{- if .Values.controller.enabled }}
 apiVersion: apps/v1
 kind: Deployment
 metadata:
@@ -102,5 +101,4 @@ spec:
 {{- if .Values.controller.volumes }}
       volumes:
 {{- toYaml .Values.controller.volumes | nindent 8 }}
-{{- end }}
 {{- end }}

charts/argo-cd/templates/argocd-application-controller/role.yaml

@@ -1,4 +1,3 @@
-{{- if .Values.controller.enabled }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
@@ -39,5 +38,4 @@ rules:
   - events
   verbs:
   - create
-  - list
+  - list
-{{- end }}

charts/argo-cd/templates/argocd-application-controller/rolebinding.yaml

@@ -1,4 +1,3 @@
-{{- if .Values.controller.enabled }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
@@ -17,5 +16,4 @@ roleRef:
 subjects:
 - kind: ServiceAccount
   name: {{ template "argo-cd.controllerServiceAccountName" . }}
-  namespace: {{ .Release.Namespace }}
+  namespace: {{ .Release.Namespace }}
-{{- end }}

charts/argo-cd/templates/argocd-application-controller/service.yaml

@@ -1,4 +1,3 @@
-{{- if .Values.controller.enabled }}
 apiVersion: v1
 kind: Service
 metadata:
@@ -23,5 +22,4 @@ spec:
     targetPort: {{ .Values.controller.containerPort }}
   selector:
     app.kubernetes.io/instance: {{ .Release.Name }}
-    app.kubernetes.io/name: {{ include "argo-cd.name" . }}-{{ .Values.controller.name }}
+    app.kubernetes.io/name: {{ include "argo-cd.name" . }}-{{ .Values.controller.name }}
-{{- end }}

charts/argo-cd/templates/argocd-application-controller/serviceaccount.yaml

@@ -1,4 +1,3 @@
-{{- if .Values.controller.enabled }}
 apiVersion: v1
 kind: ServiceAccount
 metadata:
@@ -9,5 +8,4 @@ metadata:
     app.kubernetes.io/instance: {{ .Release.Name }}
     app.kubernetes.io/managed-by: {{ .Release.Service }}
     app.kubernetes.io/part-of: {{ include "argo-cd.name" . }}
-    app.kubernetes.io/component: {{ .Values.controller.name }}
+    app.kubernetes.io/component: {{ .Values.controller.name }}
-{{- end }}

charts/argo-cd/values.yaml

@@ -11,7 +11,6 @@ global:
 
 ## Controller
 controller:
-  enabled: true
   name: application-controller
 
   image: {}