From 5744ad8c6c915fe893e80348e13debed661b3296 Mon Sep 17 00:00:00 2001
From: kostas-theo <ktheo@oneconcern.com>
Date: Tue, 25 May 2021 16:29:48 +0200
Subject: [PATCH] fix: review recommendations

Signed-off-by: kostas-theo <ktheo@oneconcern.com>
---
 charts/argo-events/Chart.yaml                    | 2 +-
 charts/argo-events/templates/argo-events-sa.yaml | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/charts/argo-events/Chart.yaml b/charts/argo-events/Chart.yaml
index b0770954..8a5a85b5 100644
--- a/charts/argo-events/Chart.yaml
+++ b/charts/argo-events/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v2
 description: A Helm chart to install Argo-Events in k8s Cluster
 name: argo-events
-version: 1.4.2
+version: 1.5.0
 keywords:
   - argo-events
   - sensor-controller
diff --git a/charts/argo-events/templates/argo-events-sa.yaml b/charts/argo-events/templates/argo-events-sa.yaml
index 5042b4b8..d99ab765 100644
--- a/charts/argo-events/templates/argo-events-sa.yaml
+++ b/charts/argo-events/templates/argo-events-sa.yaml
@@ -5,8 +5,8 @@ kind: ServiceAccount
 metadata:
   name: {{ .Values.serviceAccount }}
   namespace: {{ .Release.Namespace }}
-  {{- if .Values.serviceAccountAnnotations }}
-  annotations: {{- toYaml .Values.serviceAccountAnnotations | nindent 4 }}
+  {{- with .Values.serviceAccountAnnotations }}
+  annotations: {{- toYaml .| nindent 4 }}
   {{- end }}
 {{- if .Values.additionalSaNamespaces }}
 {{ $annotations := .Values.serviceAccountAnnotations }}
@@ -18,8 +18,8 @@ kind: ServiceAccount
 metadata:
   name: {{ $sa }}
   namespace: {{ $namespace }}
-  {{- if $annotations }}
-  annotations: {{- toYaml $annotations | nindent 4 }}
+  {{- with $annotations }}
+  annotations: {{- toYaml . | nindent 4 }}
   {{- end }}
 {{- end }}
 {{- end }}