inline "define" templates with simple values now that controller.workflowNamespaces and workflow.namespace are unified into a single "range" iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

charts/argo-workflows/templates/controller/workflow-rb.yaml

@@ -1,34 +1,18 @@
-{{- define "workflow-rb-base" }}
+{{- if .Values.workflow.rbac.create -}}
+  {{- range $namespace := append .Values.controller.workflowNamespaces .Values.workflow.namespace | compact | uniq }}
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
-{{- end }}
+  name: {{ template "argo-workflows.fullname" }}-workflow
-
+  namespace: {{ $namespace }}
-{{- define "workflow-rb-roleref" }}
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
-{{- end }}
+  name: {{ template "argo-workflows.fullname" $ }}-workflow
-
-{{- define "workflow-rb-subjects" }}
 subjects:
   - kind: ServiceAccount
-{{- end }}
-
-{{- if .Values.workflow.rbac.create -}}
-  {{- range $namespace := append .Values.controller.workflowNamespaces .Values.workflow.namespace | compact | uniq }}
-
-    {{ include "workflow-rb-base" . }}
-  name: {{ template "argo-workflows.fullname" }}-workflow
-  namespace: {{ $namespace }}
-
-    {{- include "workflow-rb-roleref" . }}
-  name: {{ template "argo-workflows.fullname" $ }}-workflow
-
-    {{- include "workflow-rb-subjects" . }}
     name: {{ $.Values.workflow.serviceAccount.name }}
     namespace: {{ $namespace }}
   {{- end }}
-
 {{- end }}