From 69feaadde74e46bf9fa412b451d00f2c3849976f Mon Sep 17 00:00:00 2001 From: Chris Reiche <35380634+creiche@users.noreply.github.com> Date: Fri, 16 Dec 2022 19:45:25 -0500 Subject: [PATCH] feat(argo-events): Add the ability to change the port for argo-events webhook (#1712) --- charts/argo-events/Chart.yaml | 4 ++-- charts/argo-events/README.md | 1 + .../argo-events/templates/argo-events-webhook/deployment.yaml | 4 +++- charts/argo-events/values.yaml | 3 +++ 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/charts/argo-events/Chart.yaml b/charts/argo-events/Chart.yaml index 39bf0659..fa40f90f 100644 --- a/charts/argo-events/Chart.yaml +++ b/charts/argo-events/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 appVersion: v1.7.3 description: A Helm chart for Argo Events, the event-driven workflow automation framework name: argo-events -version: 2.0.8 +version: 2.0.9 home: https://github.com/argoproj/argo-helm icon: https://argoproj.github.io/argo-events/assets/logo.png keywords: @@ -15,4 +15,4 @@ maintainers: url: https://argoproj.github.io/ annotations: artifacthub.io/changes: | - - "[Fixed]: use policy/v1 for poddisruptionbudgets, when available + - "[Added]: Ability to specify port for webhook deployment" diff --git a/charts/argo-events/README.md b/charts/argo-events/README.md index 9a66aa06..30f26f30 100644 --- a/charts/argo-events/README.md +++ b/charts/argo-events/README.md @@ -155,6 +155,7 @@ done | webhook.pdb.labels | object | `{}` | Labels to be added to admission webhook pdb | | webhook.podAnnotations | object | `{}` | Annotations to be added to event controller pods | | webhook.podLabels | object | `{}` | Labels to be added to event controller pods | +| webhook.port | int | `443` | Port to listen on | | webhook.priorityClassName | string | `""` | Priority class for the event controller pods | | webhook.readinessProbe.failureThreshold | int | `3` | Minimum consecutive failures for the [probe] to be considered failed after having succeeded | | webhook.readinessProbe.initialDelaySeconds | int | `10` | Number of seconds after the container has started before [probe] is initiated | diff --git a/charts/argo-events/templates/argo-events-webhook/deployment.yaml b/charts/argo-events/templates/argo-events-webhook/deployment.yaml index b030bc7c..2f0478af 100644 --- a/charts/argo-events/templates/argo-events-webhook/deployment.yaml +++ b/charts/argo-events/templates/argo-events-webhook/deployment.yaml @@ -50,6 +50,8 @@ spec: valueFrom: fieldRef: fieldPath: metadata.namespace + - name: PORT + value: "{{ .Values.webhook.port }}" {{- with .Values.webhook.env }} {{- toYaml . | nindent 8 }} {{- end }} @@ -63,7 +65,7 @@ spec: {{- end }} ports: - name: webhook - containerPort: 443 + containerPort: {{ .Values.webhook.port }} protocol: TCP livenessProbe: tcpSocket: diff --git a/charts/argo-events/values.yaml b/charts/argo-events/values.yaml index 87c6ccf0..094a3638 100644 --- a/charts/argo-events/values.yaml +++ b/charts/argo-events/values.yaml @@ -315,6 +315,9 @@ webhook: # -- Labels to be added to event controller pods podLabels: {} + # -- Port to listen on + port: 443 + # -- Event controller container-level security context containerSecurityContext: {} # capabilities: