From 8adbe5b4399a60329f5c11e844f7e4cecb6b57a1 Mon Sep 17 00:00:00 2001 From: Richard Johansson Date: Fri, 20 Jan 2023 16:10:12 +0100 Subject: [PATCH] Corrected inline comments Signed-off-by: Richard Johansson --- charts/argo-rollouts/README.md | 4 ++-- charts/argo-rollouts/templates/controller/clusterrole.yaml | 2 +- charts/argo-rollouts/templates/controller/role.yaml | 2 ++ charts/argo-rollouts/values.yaml | 4 ++-- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/charts/argo-rollouts/README.md b/charts/argo-rollouts/README.md index 59f17eec..73581f4e 100644 --- a/charts/argo-rollouts/README.md +++ b/charts/argo-rollouts/README.md @@ -55,9 +55,9 @@ If dashboard is installed by `--set dashboard.enabled=true`, checkout the argo-r | notifications.secret.items | object | `{}` | Generic key:value pairs to be inserted into the notifications secret | | notifications.templates | object | `{}` | Notification templates | | notifications.triggers | object | `{}` | The trigger defines the condition when the notification should be sent | -| providerRBAC.enabled | bool | `true` | Enables addition of provider-specific RBAC rules to the controller Role and ClusterRole | +| providerRBAC.enabled | bool | `true` | Toggles addition of provider-specific RBAC rules to the controller Role and ClusterRole | | providerRBAC.providers.ambassador | bool | `true` | Adds RBAC rules for the Ambassador provider | -| providerRBAC.providers.apisix | bool | `true` | Adds RBAC rules for the Traefik provider | +| providerRBAC.providers.apisix | bool | `true` | Adds RBAC rules for the Apisix provider | | providerRBAC.providers.awsAppMesh | bool | `true` | Adds RBAC rules for the AWS App Mesh provider | | providerRBAC.providers.awsLoadBalancerController | bool | `true` | Adds RBAC rules for the AWS Load Balancer Controller provider | | providerRBAC.providers.istio | bool | `true` | Adds RBAC rules for the Istio provider | diff --git a/charts/argo-rollouts/templates/controller/clusterrole.yaml b/charts/argo-rollouts/templates/controller/clusterrole.yaml index f44ac4b8..fe1c0486 100644 --- a/charts/argo-rollouts/templates/controller/clusterrole.yaml +++ b/charts/argo-rollouts/templates/controller/clusterrole.yaml @@ -244,7 +244,7 @@ rules: - update {{- end }} {{- if .Values.providerRBAC.providers.apisix }} -# Traefik access needed when using the Traefik provider +# Traefik access needed when using the Apisix provider - apiGroups: - apisix.apache.org resources: diff --git a/charts/argo-rollouts/templates/controller/role.yaml b/charts/argo-rollouts/templates/controller/role.yaml index 1347b110..1f7892eb 100644 --- a/charts/argo-rollouts/templates/controller/role.yaml +++ b/charts/argo-rollouts/templates/controller/role.yaml @@ -233,6 +233,7 @@ rules: - patch {{- end }} {{- if .Values.providerRBAC.providers.traefik }} +# Traefik access needed when using the Traefik provider - apiGroups: - traefik.containo.us resources: @@ -243,6 +244,7 @@ rules: - update {{- end }} {{- if .Values.providerRBAC.providers.apisix }} +# Traefik access needed when using the Apisix provider - apiGroups: - apisix.apache.org resources: diff --git a/charts/argo-rollouts/values.yaml b/charts/argo-rollouts/values.yaml index 2092cf8b..eb077221 100644 --- a/charts/argo-rollouts/values.yaml +++ b/charts/argo-rollouts/values.yaml @@ -191,7 +191,7 @@ imagePullSecrets: [] # - name: argo-pull-secret providerRBAC: - # -- Enables addition of provider-specific RBAC rules to the controller Role and ClusterRole + # -- Toggles addition of provider-specific RBAC rules to the controller Role and ClusterRole enabled: true # providerRBAC.enabled must be true in order to toggle the individual providers providers: @@ -207,7 +207,7 @@ providerRBAC: awsAppMesh: true # -- Adds RBAC rules for the Traefik provider traefik: true - # -- Adds RBAC rules for the Traefik provider + # -- Adds RBAC rules for the Apisix provider apisix: true dashboard: