From 8bb95c35421ee9660f141bc90123ec73d98c38f0 Mon Sep 17 00:00:00 2001
From: Hui Kang <hui.kang@salesforce.com>
Date: Thu, 12 Aug 2021 10:31:01 -0400
Subject: [PATCH] fix: Documentation on dashboard values, change annotations

Signed-off-by: Hui Kang <hui.kang@salesforce.com>
---
 charts/argo-rollouts/Chart.yaml  |  3 +--
 charts/argo-rollouts/README.md   | 14 ++++++++++++++
 charts/argo-rollouts/values.yaml |  7 +++----
 3 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/charts/argo-rollouts/Chart.yaml b/charts/argo-rollouts/Chart.yaml
index 647243ca..7bdb6ea9 100644
--- a/charts/argo-rollouts/Chart.yaml
+++ b/charts/argo-rollouts/Chart.yaml
@@ -11,5 +11,4 @@ maintainers:
   - name: jessesuen
 annotations:
   artifacthub.io/changes: |
-    - "[Fixed]: Add missing liveness and readiness probes"
-    - "[Changed]: Fix icon url"
+    - "[Added]: Dashboard manifests"
diff --git a/charts/argo-rollouts/README.md b/charts/argo-rollouts/README.md
index b35168f7..9fcd862a 100644
--- a/charts/argo-rollouts/README.md
+++ b/charts/argo-rollouts/README.md
@@ -57,6 +57,20 @@ If dashboard is installed by `--set dashboard.enabled=true`, checkout the argo-r
 | podSecurityContext | object | `{"runAsNonRoot": true}` | Security Context to set on pod level |
 | containerSecurityContext | object | `{}` | Security Context to set on container level |
 | dashboard.enabled | bool | `false` | Deploy dashboard server |
+| dashboard.component | string | `"rollouts-dashboard"` | Value of label `app.kubernetes.io/component` |
+| dashboard.image.pullPolicy | string | `"IfNotPresent"` | Image pull policy |
+| dashboard.image.registry | string | `quay.io` | Registry to use |
+| dashboard.image.repository | string | `"argoproj/kubectl-argo-rollouts"` | Repository to use |
+| dashboard.image.tag | string | `""` | Overrides the image tag (default is the chart appVersion) |
+| dashboard.resources | object | `{}` | Resource limits and requests for the dashboard pods. |
+| dashboard.tolerations | list | `[]` | [Tolerations for use with node taints](https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/) |
+| dashboard.affinity | object | `{}` | [Assign custom affinity rules to the deployment](https://kubernetes.io/docs/concepts/configuration/assign-pod-node/) |
+| dashboard.nodeSelector | object | `{}` | [Node selector](https://kubernetes.io/docs/user-guide/node-selection/) |
+| dashboard.podSecurityContext | object | `{"runAsNonRoot": true}` | Security Context to set on pod level |
+| dashboard.containerSecurityContext | object | `{}` | Security Context to set on container level |
+| dashboard.serviceAccount.create | bool | `true` | Specifies whether a dashboard service account should be created |
+| dashboard.serviceAccount.annotations | object | `{}` | Annotations to add to the dashboard service account |
+| dashboard.serviceAccount.name | string | `""` | The name of the dashboard service account to use. If not set and create is true, a name is generated using the fullname template |
 
 ## Upgrading
 
diff --git a/charts/argo-rollouts/values.yaml b/charts/argo-rollouts/values.yaml
index 2aa997b5..4c288b98 100644
--- a/charts/argo-rollouts/values.yaml
+++ b/charts/argo-rollouts/values.yaml
@@ -25,7 +25,7 @@ controller:
   #    memory: 64Mi
 
   metrics:
-    enabled: true
+    enabled: false
     serviceMonitor:
       enabled: false
       additionalLabels: {}
@@ -110,9 +110,8 @@ dashboard:
     tag: ""
     pullPolicy: IfNotPresent
   resources: {}
-  podSecurityContext: {}
-  #  Enable runAsNonRoot after image version v1.0.1
-  #  runAsNonRoot: true
+  podSecurityContext:
+    runAsNonRoot: true
   containerSecurityContext: {}
   serviceAccount:
     create: true