feat(argocd-apps): finalizers for applicationset (#2952)

This commit is contained in:
Maneesh Singh 2024-09-30 23:03:26 -07:00 committed by GitHub
parent c38d299f01
commit 994838a2ef
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 11 additions and 3 deletions

View file

@ -2,7 +2,7 @@ apiVersion: v2
name: argocd-apps name: argocd-apps
description: A Helm chart for managing additional Argo CD Applications and Projects description: A Helm chart for managing additional Argo CD Applications and Projects
type: application type: application
version: 2.0.1 version: 2.0.2
home: https://github.com/argoproj/argo-helm home: https://github.com/argoproj/argo-helm
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
keywords: keywords:
@ -17,5 +17,5 @@ annotations:
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252 fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
url: https://argoproj.github.io/argo-helm/pgp_keys.asc url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: | artifacthub.io/changes: |
- kind: fixed - kind: added
description: not rendering empty app description description: allow setting applicationset finalizers

View file

@ -4,6 +4,8 @@ applicationsets:
applicationset: applicationset:
additionalLabels: {} additionalLabels: {}
additionalAnnotations: {} additionalAnnotations: {}
finalizers:
- resources-finalizer.argocd.argoproj.io
# See PR #10026 (ArgoCD v2.5 or later) # See PR #10026 (ArgoCD v2.5 or later)
# goTemplate: false # goTemplate: false
generators: generators:

View file

@ -17,6 +17,10 @@ metadata:
{{- with $appSetData.namespace }} {{- with $appSetData.namespace }}
namespace: {{ . }} namespace: {{ . }}
{{- end }} {{- end }}
{{- with $appSetData.finalizers }}
finalizers:
{{- toYaml . | nindent 4 }}
{{- end }}
spec: spec:
{{- if hasKey $appSetData "goTemplate" }} {{- if hasKey $appSetData "goTemplate" }}
goTemplate: {{ $appSetData.goTemplate }} goTemplate: {{ $appSetData.goTemplate }}

View file

@ -97,6 +97,8 @@ applicationsets: {}
# namespace: argocd # namespace: argocd
# additionalLabels: {} # additionalLabels: {}
# additionalAnnotations: {} # additionalAnnotations: {}
# finalizers:
# - resources-finalizer.argocd.argoproj.io
# # See PR #10026 (ArgoCD v2.5 or later) # # See PR #10026 (ArgoCD v2.5 or later)
# # goTemplate: false # # goTemplate: false
# generators: # generators: