From af0d6b895790b1e3a4d5c0343ecc7fc7552d5d7b Mon Sep 17 00:00:00 2001 From: Marco Kilchhofer Date: Wed, 31 Mar 2021 19:35:48 +0200 Subject: [PATCH] chore: Update PR template to include notes on DCO (#642) Argo Project has moved from the CLA to the DCO: - https://github.com/argoproj/argoproj/pull/24 - https://github.com/argoproj/argo-cd/pull/4966 Signed-off-by: Marco Kilchhofer --- .github/pull_request_template.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 1ed7a9f2..67fe55f4 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,9 +1,13 @@ +Note on DCO: + +If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the *Details* link next to the DCO action for instructions on how to resolve this. + Checklist: * [ ] I have updated the chart version in `Chart.yaml` following Semantic Versioning. * [ ] Any new values are backwards compatible and/or have sensible default. * [ ] I have followed the testing instructions in the [contributing guide](https://github.com/argoproj/argo-helm/blob/master/CONTRIBUTING.md). -* [ ] I have signed the CLA and the build is green. -* [ ] I will test my changes again once merged to master and published. +* [ ] I have signed off all my commits as required by [DCO](https://github.com/argoproj/argoproj/tree/master/community#contributing-to-argo). +* [ ] My build is green ([troubleshooting builds](https://argoproj.github.io/argo-cd/developer-guide/ci/)). Changes are automatically published when merged to `master`. They are not published on branches.