feat(argo-rollouts): Support extraArgs for controller and dashboard

Adding support for additional arguments that are passed to the controller and the dashboard.
Following the pattern of other Argo charts by re-using the name `extraArgs` for the value.

Refs: https://github.com/argoproj/argo-helm/issues/969
Signed-off-by: Sebastian J <zeeman@zeeman.de>
This commit is contained in:
Sebastian J 2021-10-17 11:42:28 -04:00
parent a992c96053
commit b3a6bb42a8
No known key found for this signature in database
GPG key ID: 96DF230FDC0EC9C6
4 changed files with 17 additions and 3 deletions

View file

@ -2,7 +2,7 @@ apiVersion: v2
appVersion: "v1.1.0" appVersion: "v1.1.0"
description: A Helm chart for Argo Rollouts description: A Helm chart for Argo Rollouts
name: argo-rollouts name: argo-rollouts
version: 2.2.1 version: 2.2.2
icon: https://argoproj.github.io/argo-rollouts/assets/logo.png icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
home: https://github.com/argoproj/argo-helm home: https://github.com/argoproj/argo-helm
maintainers: maintainers:
@ -11,4 +11,4 @@ maintainers:
- name: jessesuen - name: jessesuen
annotations: annotations:
artifacthub.io/changes: | artifacthub.io/changes: |
- "[Changed]: Reorganize files in repo, move controller-specific things into subfolder." - "[Feature]: Add support for extraArgs for controller and dashboard"

View file

@ -32,10 +32,13 @@ spec:
serviceAccountName: {{ include "argo-rollouts.serviceAccountName" . }} serviceAccountName: {{ include "argo-rollouts.serviceAccountName" . }}
containers: containers:
- image: "{{ .Values.controller.image.registry }}/{{ .Values.controller.image.repository }}:{{ default .Chart.AppVersion .Values.controller.image.tag }}" - image: "{{ .Values.controller.image.registry }}/{{ .Values.controller.image.repository }}:{{ default .Chart.AppVersion .Values.controller.image.tag }}"
{{- if not .Values.clusterInstall }}
args: args:
{{- if not .Values.clusterInstall }}
- --namespaced - --namespaced
{{- end }} {{- end }}
{{- with .Values.controller.extraArgs }}
{{- . | toYaml | nindent 8 }}
{{- end }}
imagePullPolicy: {{ .Values.controller.image.pullPolicy }} imagePullPolicy: {{ .Values.controller.image.pullPolicy }}
name: argo-rollouts name: argo-rollouts
ports: ports:

View file

@ -34,6 +34,10 @@ spec:
containers: containers:
- image: "{{ .Values.dashboard.image.registry }}/{{ .Values.dashboard.image.repository }}:{{ default .Chart.AppVersion .Values.dashboard.image.tag }}" - image: "{{ .Values.dashboard.image.registry }}/{{ .Values.dashboard.image.repository }}:{{ default .Chart.AppVersion .Values.dashboard.image.tag }}"
imagePullPolicy: {{ .Values.dashboard.image.pullPolicy }} imagePullPolicy: {{ .Values.dashboard.image.pullPolicy }}
args:
{{- with .Values.dashboard.extraArgs }}
{{- . | toYaml | nindent 8 }}
{{- end }}
name: argo-rollouts-dashboard name: argo-rollouts-dashboard
ports: ports:
- containerPort: 3100 - containerPort: 3100

View file

@ -17,6 +17,10 @@ controller:
tag: "" tag: ""
pullPolicy: IfNotPresent pullPolicy: IfNotPresent
## Additional command line arguments to pass to rollouts-controller
##
extraArgs: []
resources: {} resources: {}
# limits: # limits:
# cpu: 100m # cpu: 100m
@ -110,6 +114,9 @@ dashboard:
repository: argoproj/kubectl-argo-rollouts repository: argoproj/kubectl-argo-rollouts
tag: "" tag: ""
pullPolicy: IfNotPresent pullPolicy: IfNotPresent
## Additional command line arguments to pass to rollouts-dashboard
##
extraArgs: []
resources: {} resources: {}
podSecurityContext: podSecurityContext:
runAsNonRoot: true runAsNonRoot: true