From bf2420767bfb49ce28c92094f2234e9e5012d7fb Mon Sep 17 00:00:00 2001 From: Aikawa Date: Mon, 26 Sep 2022 10:49:33 +0900 Subject: [PATCH] fix(argo-workflows): change default type of `.mainContainer.env` and `.executor.env` from object to array (#1487) Signed-off-by: yu-croco --- charts/argo-workflows/Chart.yaml | 4 ++-- charts/argo-workflows/README.md | 4 ++-- charts/argo-workflows/values.yaml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/charts/argo-workflows/Chart.yaml b/charts/argo-workflows/Chart.yaml index 36a595f6..925e8af9 100644 --- a/charts/argo-workflows/Chart.yaml +++ b/charts/argo-workflows/Chart.yaml @@ -3,7 +3,7 @@ appVersion: v3.4.0 name: argo-workflows description: A Helm chart for Argo Workflows type: application -version: 0.19.2 +version: 0.19.3 icon: https://raw.githubusercontent.com/argoproj/argo-workflows/master/docs/assets/argo.png home: https://github.com/argoproj/argo-helm sources: @@ -13,4 +13,4 @@ maintainers: url: https://argoproj.github.io/ annotations: artifacthub.io/changes: | - - "[Fixed]: Set only used values on SSO configuration" + - "[Fixed]: Change default type of `.mainContainer.env` and `.executor.env` from object to array" diff --git a/charts/argo-workflows/README.md b/charts/argo-workflows/README.md index a0bec699..8cf04457 100644 --- a/charts/argo-workflows/README.md +++ b/charts/argo-workflows/README.md @@ -139,7 +139,7 @@ Fields to note: | Key | Type | Default | Description | |-----|------|---------|-------------| -| mainContainer.env | object | `{}` | Adds environment variables for the Workflow main container | +| mainContainer.env | list | `[]` | Adds environment variables for the Workflow main container | | mainContainer.imagePullPolicy | string | `"Always"` | imagePullPolicy to apply to Workflow main container | | mainContainer.resources | object | `{}` | Resource limits and requests for the Workflow main container | | mainContainer.securityContext | object | `{}` | sets security context for the Workflow main container | @@ -148,7 +148,7 @@ Fields to note: | Key | Type | Default | Description | |-----|------|---------|-------------| -| executor.env | object | `{}` | Adds environment variables for the executor. | +| executor.env | list | `[]` | Adds environment variables for the executor. | | executor.image.registry | string | `"quay.io"` | Registry to use for the Workflow Executors | | executor.image.repository | string | `"argoproj/argoexec"` | Repository to use for the Workflow Executors | | executor.image.tag | string | `""` | Image tag for the workflow executor. Defaults to `.Values.images.tag`. | diff --git a/charts/argo-workflows/values.yaml b/charts/argo-workflows/values.yaml index 0d661b6c..b961bcdd 100644 --- a/charts/argo-workflows/values.yaml +++ b/charts/argo-workflows/values.yaml @@ -283,7 +283,7 @@ mainContainer: # -- Resource limits and requests for the Workflow main container resources: {} # -- Adds environment variables for the Workflow main container - env: {} + env: [] # -- sets security context for the Workflow main container securityContext: {} @@ -299,7 +299,7 @@ executor: # -- Resource limits and requests for the Workflow Executors resources: {} # -- Adds environment variables for the executor. - env: {} + env: [] # -- sets security context for the executor container securityContext: {}