From bfd9eaa013adc2638d1c516e5bacf6139a602845 Mon Sep 17 00:00:00 2001 From: reinvantveer Date: Wed, 14 Jul 2021 18:53:40 +0200 Subject: [PATCH] drop validations: considering cases of `workflowNamespaces`, `namespace` and `singleNamespace` Signed-off-by: reinvantveer --- .../templates/controller/workflow-sa.yaml | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/charts/argo-workflows/templates/controller/workflow-sa.yaml b/charts/argo-workflows/templates/controller/workflow-sa.yaml index c3881e40..f88d01dd 100644 --- a/charts/argo-workflows/templates/controller/workflow-sa.yaml +++ b/charts/argo-workflows/templates/controller/workflow-sa.yaml @@ -1,23 +1,4 @@ {{- if .Values.workflow.serviceAccount.create -}} - - {{- /* - Cardinality-check the namespaces/namespace variables - This type check is done only once, here. It would be overkill to perform it for other RBAC resources as well. - */}} - {{- if and .Values.controller.workflowNamespaces .Values.workflow.namespace }} - {{- fail "Please set either controller.workflowNamespaces or workflow.namespace for the service account, not both" }} - {{- end }} - - {{- /* - Type-check the namespaces variable for being a list ("slice") - This type check is done only once, here. It would be overkill to perform it for other RBAC resources as well. - */}} - {{- if .Values.controller.workflowNamespaces }} - {{- if not ( kindIs "slice" .Values.controller.workflowNamespaces ) }} - {{- fail ( printf "workflow.namespaces is a slice, got %s %s" ( kindOf .Values.controller.workflowNamespaces ) .Values.controller.workflowNamespaces ) }} - {{- end }} - {{- end }} - {{ range $namespace := append .Values.controller.workflowNamespaces .Values.workflow.namespace | compact | uniq }} --- apiVersion: v1