diff --git a/charts/argo-rollouts/README.md b/charts/argo-rollouts/README.md index 2b9b105f..4647c419 100644 --- a/charts/argo-rollouts/README.md +++ b/charts/argo-rollouts/README.md @@ -51,6 +51,7 @@ For full list of changes please check ArtifactHub [changelog]. | fullnameOverride | string | `nil` | String to fully override "argo-rollouts.fullname" template | | global.deploymentAnnotations | object | `{}` | Annotations for all deployed Deployments | | global.deploymentLabels | object | `{}` | Labels for all deployed Deployments | +| global.revisionHistoryLimit | int | `10` | Number of old deployment ReplicaSets to retain. The rest will be garbage collected. | | imagePullSecrets | list | `[]` | Secrets with credentials to pull images from a private registry. Registry secret names as an array. | | installCRDs | bool | `true` | Install and upgrade CRDs | | keepCRDs | bool | `true` | Keep CRD's on helm uninstall | @@ -121,7 +122,6 @@ For full list of changes please check ArtifactHub [changelog]. | controller.readinessProbe | object | See [values.yaml] | Configure readiness [probe] for the controller | | controller.replicas | int | `2` | The number of controller pods to run | | controller.resources | object | `{}` | Resource limits and requests for the controller pods. | -| controller.revisionHistoryLimit | int | `10` | The number of revisions to keep | | controller.tolerations | list | `[]` | [Tolerations] for use with node taints | | controller.topologySpreadConstraints | list | `[]` | Assign custom [TopologySpreadConstraints] rules to the controller | | controller.trafficRouterPlugins | object | `{}` | Configures 3rd party traffic router plugins for controller | @@ -176,7 +176,6 @@ For full list of changes please check ArtifactHub [changelog]. | dashboard.readonly | bool | `false` | Set cluster role to readonly | | dashboard.replicas | int | `1` | The number of dashboard pods to run | | dashboard.resources | object | `{}` | Resource limits and requests for the dashboard pods. | -| dashboard.revisionHistoryLimit | int | `10` | The number of revisions to keep | | dashboard.service.annotations | object | `{}` | Service annotations | | dashboard.service.externalIPs | list | `[]` | Dashboard service external IPs | | dashboard.service.labels | object | `{}` | Service labels | diff --git a/charts/argo-rollouts/templates/controller/deployment.yaml b/charts/argo-rollouts/templates/controller/deployment.yaml index 416a4d02..2bfdb912 100644 --- a/charts/argo-rollouts/templates/controller/deployment.yaml +++ b/charts/argo-rollouts/templates/controller/deployment.yaml @@ -23,7 +23,7 @@ spec: strategy: type: Recreate replicas: {{ .Values.controller.replicas }} - revisionHistoryLimit: {{ .Values.controller.revisionHistoryLimit }} + revisionHistoryLimit: {{ .Values.global.revisionHistoryLimit }} template: metadata: {{- with (mergeOverwrite (deepCopy .Values.podAnnotations) .Values.controller.podAnnotations) }} diff --git a/charts/argo-rollouts/templates/dashboard/deployment.yaml b/charts/argo-rollouts/templates/dashboard/deployment.yaml index b0451d35..ec0114ba 100644 --- a/charts/argo-rollouts/templates/dashboard/deployment.yaml +++ b/charts/argo-rollouts/templates/dashboard/deployment.yaml @@ -24,7 +24,7 @@ spec: strategy: type: Recreate replicas: {{ .Values.dashboard.replicas }} - revisionHistoryLimit: {{ .Values.dashboard.revisionHistoryLimit }} + revisionHistoryLimit: {{ .Values.global.revisionHistoryLimit }} template: metadata: {{- with (mergeOverwrite (deepCopy .Values.podAnnotations) .Values.dashboard.podAnnotations) }} diff --git a/charts/argo-rollouts/values.yaml b/charts/argo-rollouts/values.yaml index e5c2cd63..64181c99 100644 --- a/charts/argo-rollouts/values.yaml +++ b/charts/argo-rollouts/values.yaml @@ -43,6 +43,8 @@ global: deploymentAnnotations: {} # -- Labels for all deployed Deployments deploymentLabels: {} + # -- Number of old deployment ReplicaSets to retain. The rest will be garbage collected. + revisionHistoryLimit: 10 controller: # -- Value of label `app.kubernetes.io/component` @@ -90,8 +92,6 @@ controller: tag: "" # -- Image pull policy pullPolicy: IfNotPresent - # -- The number of revisions to keep - revisionHistoryLimit: 10 # -- Additional command line arguments to pass to rollouts-controller. A list of flags. extraArgs: [] @@ -338,8 +338,6 @@ dashboard: tag: "" # -- Image pull policy pullPolicy: IfNotPresent - # -- The number of revisions to keep - revisionHistoryLimit: 10 # -- Additional command line arguments to pass to rollouts-dashboard. A list of flags. extraArgs: [] # -- Additional environment variables for rollouts-dashboard. A list of name/value maps.