From c3f6c2626daffe7db5f2c5fd6c0a01af2f49b322 Mon Sep 17 00:00:00 2001 From: Lukasz Lempart Date: Mon, 24 Sep 2018 19:43:26 -0700 Subject: [PATCH] Disable deploying ui service when ui is disabled **Why** We had previoulsy removed the UI deployment, but not the service. This potentially poses a security hole. --- charts/argo/Chart.yaml | 2 +- charts/argo/templates/ui-service.yaml | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/charts/argo/Chart.yaml b/charts/argo/Chart.yaml index 0616b08c..324cd011 100644 --- a/charts/argo/Chart.yaml +++ b/charts/argo/Chart.yaml @@ -1,4 +1,4 @@ apiVersion: v1 description: A Helm chart for Kubernetes name: argo -version: 0.2.0 +version: 0.2.1 diff --git a/charts/argo/templates/ui-service.yaml b/charts/argo/templates/ui-service.yaml index 96e2c38f..d6e29180 100644 --- a/charts/argo/templates/ui-service.yaml +++ b/charts/argo/templates/ui-service.yaml @@ -1,3 +1,4 @@ +{{ if .Values.ui.enabled }} apiVersion: v1 kind: Service metadata: @@ -15,3 +16,4 @@ spec: app: {{ .Release.Name }}-{{ .Values.uiName}} sessionAffinity: None type: {{ .Values.uiServiceType }} +{{ end }}