From c8b602eb9710d15d844447e214c7e1dfcd7c3676 Mon Sep 17 00:00:00 2001 From: Derek Brown <6845676+DerekTBrown@users.noreply.github.com> Date: Mon, 13 Jan 2025 09:08:18 -0800 Subject: [PATCH] address comments Signed-off-by: Derek Brown <6845676+DerekTBrown@users.noreply.github.com> --- charts/argo-rollouts/Chart.yaml | 6 ++---- charts/argo-rollouts/templates/controller/deployment.yaml | 4 +--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/charts/argo-rollouts/Chart.yaml b/charts/argo-rollouts/Chart.yaml index 5d7cbaf8..3254c3ed 100644 --- a/charts/argo-rollouts/Chart.yaml +++ b/charts/argo-rollouts/Chart.yaml @@ -18,7 +18,5 @@ annotations: fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252 url: https://argoproj.github.io/argo-helm/pgp_keys.asc artifacthub.io/changes: | - - kind: added - description: Add lifecycle settings for controller - - kind: added - description: Add terminationGracePeriodSeconds for controller + - kind: changed + description: argo-rollouts will re-deploy if changes are made to the argo-rollouts configmap. diff --git a/charts/argo-rollouts/templates/controller/deployment.yaml b/charts/argo-rollouts/templates/controller/deployment.yaml index c290e177..954453f0 100644 --- a/charts/argo-rollouts/templates/controller/deployment.yaml +++ b/charts/argo-rollouts/templates/controller/deployment.yaml @@ -31,9 +31,7 @@ spec: {{- range $key, $value := . }} {{ $key }}: {{ $value | quote }} {{- end }} - {{/* Add the checksum of the ConfigMap to the annotations */}} - {{/* This ensures that ConfigMap changes trigger a rolling update */}} - configmap-checksum: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }} + checksum/cm: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }} {{- end }} labels: {{- include "argo-rollouts.selectorLabels" . | nindent 8 }}