From d44be217f2f7024cb861358bc6482ce4ce033b29 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C4=81nis=20Orlovs?= <janis@cwise.eu>
Date: Tue, 1 Oct 2024 13:58:16 +0300
Subject: [PATCH] Added chart values deprecation parameters. This will simplify
 updates for changes in charts.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Pattern copied from https://github.com/jenkinsci/helm-charts/blob/jenkins-5.7.1/charts/jenkins/templates/deprecation.yaml

Signed-off-by: Jānis Orlovs <janis@cwise.eu>
---
 charts/argo-cd/Chart.yaml                               | 2 +-
 charts/argo-cd/README.md                                | 1 +
 charts/argo-cd/templates/argocd-server/deprecation.yaml | 5 +++++
 charts/argo-cd/values.yaml                              | 4 ++++
 4 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 charts/argo-cd/templates/argocd-server/deprecation.yaml

diff --git a/charts/argo-cd/Chart.yaml b/charts/argo-cd/Chart.yaml
index 16b11ae6..4d7047db 100644
--- a/charts/argo-cd/Chart.yaml
+++ b/charts/argo-cd/Chart.yaml
@@ -3,7 +3,7 @@ appVersion: v2.12.4
 kubeVersion: ">=1.25.0-0"
 description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
 name: argo-cd
-version: 7.6.7
+version: 7.7.0
 home: https://github.com/argoproj/argo-helm
 icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
 sources:
diff --git a/charts/argo-cd/README.md b/charts/argo-cd/README.md
index b44bb431..eb1b8e7e 100644
--- a/charts/argo-cd/README.md
+++ b/charts/argo-cd/README.md
@@ -670,6 +670,7 @@ NAME: my-release
 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
 | apiVersionOverrides | object | `{}` |  |
+| checkDeprecation | bool | `true` | Checks if any deprecated values are used |
 | crds.additionalLabels | object | `{}` | Addtional labels to be added to all CRDs |
 | crds.annotations | object | `{}` | Annotations to be added to all CRDs |
 | crds.install | bool | `true` | Install and upgrade CRDs |
diff --git a/charts/argo-cd/templates/argocd-server/deprecation.yaml b/charts/argo-cd/templates/argocd-server/deprecation.yaml
new file mode 100644
index 00000000..587cc519
--- /dev/null
+++ b/charts/argo-cd/templates/argocd-server/deprecation.yaml
@@ -0,0 +1,5 @@
+{{- if .Values.checkDeprecation }}
+   {{- if .Values.server.config }}
+      {{ fail "`server.config` does no longer exist. It has been renamed to `configs`" }}
+   {{- end }}
+{{- end }}
\ No newline at end of file
diff --git a/charts/argo-cd/values.yaml b/charts/argo-cd/values.yaml
index 70dfb347..8438d441 100644
--- a/charts/argo-cd/values.yaml
+++ b/charts/argo-cd/values.yaml
@@ -3721,3 +3721,7 @@ notifications:
     # For more information: https://argo-cd.readthedocs.io/en/stable/operator-manual/notifications/triggers/#default-triggers
     # defaultTriggers: |
     #   - on-sync-status-unknown
+
+# -- Checks if any deprecated values are used
+checkDeprecation: true
+