diff --git a/.github/workflows/lint-and-test.yml b/.github/workflows/lint-and-test.yml index 1ede7931..88fcf2df 100644 --- a/.github/workflows/lint-and-test.yml +++ b/.github/workflows/lint-and-test.yml @@ -1,7 +1,7 @@ ## Reference: https://github.com/helm/chart-testing-action name: Linting and Testing on: pull_request -jobs: +jobs: chart-test: runs-on: ubuntu-latest steps: @@ -37,7 +37,7 @@ jobs: fi - name: Run chart-testing (lint) run: ct lint --debug --config ./.github/configs/ct-lint.yaml --lint-conf ./.github/configs/lintconf.yaml - + - name: Run docs-testing (helm-docs) id: helm-docs run: | @@ -60,7 +60,7 @@ jobs: if: | contains(steps.list-changed.outputs.changed_charts, 'argocd-image-updater') run: | - kubectl apply -f charts/argo-cd/crds + kubectl apply -f charts/argo-cd/templates/crds - name: Skip HPA tests of ArgoCD if: contains(steps.list-changed.outputs.changed_charts, 'argo-cd') diff --git a/charts/argo-cd/Chart.yaml b/charts/argo-cd/Chart.yaml index 0eb2ebe4..21704899 100644 --- a/charts/argo-cd/Chart.yaml +++ b/charts/argo-cd/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 appVersion: v2.4.11 description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes. name: argo-cd -version: 5.1.0 +version: 5.2.0 home: https://github.com/argoproj/argo-helm icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png keywords: @@ -21,4 +21,4 @@ dependencies: condition: redis-ha.enabled annotations: artifacthub.io/changes: | - - "[Added]: Ability to customize HPAs spec.behavior field" + - "[Changed]: manage CRD by Helm" diff --git a/charts/argo-cd/README.md b/charts/argo-cd/README.md index 17abd65f..885529d5 100644 --- a/charts/argo-cd/README.md +++ b/charts/argo-cd/README.md @@ -81,15 +81,17 @@ cd argo-cd git diff v1.8.7 v2.0.0 -- manifests/install.yaml ``` -Changes in the `CustomResourceDefinition` resources shall be fixed easily by copying 1:1 from the [`manifests/crds` folder](https://github.com/argoproj/argo-cd/tree/master/manifests/crds) into this [`charts/argo-cd/crds` folder](https://github.com/argoproj/argo-helm/tree/master/charts/argo-cd/crds). +Changes in the `CustomResourceDefinition` resources shall be fixed easily by copying 1:1 from the [`manifests/crds` folder](https://github.com/argoproj/argo-cd/tree/master/manifests/crds) into this [`charts/argo-cd/templates/crds` folder](https://github.com/argoproj/argo-helm/tree/master/charts/argo-cd/templates/crds). ## Upgrading ### Custom resource definitions +Some users would prefer to install the CRDs _outside_ of the chart. You can disable the CRD installation of this chart by using `--set crds.install=false` when installing the chart. + Helm cannot upgrade custom resource definitions [by design](https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#some-caveats-and-explanations). -Please use `kubectl` to upgrade CRDs manually from [crds](crds/) folder or via the manifests from the upstream project repo: +Please use `kubectl` to upgrade CRDs manually from [templates/crds](templates/crds/) folder or via the manifests from the upstream project repo: ```bash kubectl apply -k "https://github.com/argoproj/argo-cd/manifests/crds?ref=" @@ -98,6 +100,23 @@ kubectl apply -k "https://github.com/argoproj/argo-cd/manifests/crds?ref=" @@ -98,6 +100,23 @@ kubectl apply -k "https://github.com/argoproj/argo-cd/manifests/crds?ref=