From 248d6d25550812557712be588c17eeb798eb6062 Mon Sep 17 00:00:00 2001 From: Marco Kilchhofer Date: Mon, 27 Sep 2021 17:09:43 +0200 Subject: [PATCH 1/2] chore(argo-rollouts): Define 2 separate tests (#949) Signed-off-by: Marco Kilchhofer --- charts/argo-rollouts/Chart.yaml | 4 ++-- charts/argo-rollouts/ci/default-values.yaml | 1 + charts/argo-rollouts/ci/enable-dashboard-values.yaml | 6 ++++++ charts/argo-rollouts/ci/test-values.yaml | 2 -- 4 files changed, 9 insertions(+), 4 deletions(-) create mode 100644 charts/argo-rollouts/ci/default-values.yaml create mode 100644 charts/argo-rollouts/ci/enable-dashboard-values.yaml delete mode 100644 charts/argo-rollouts/ci/test-values.yaml diff --git a/charts/argo-rollouts/Chart.yaml b/charts/argo-rollouts/Chart.yaml index e6634acb..a71abd6b 100644 --- a/charts/argo-rollouts/Chart.yaml +++ b/charts/argo-rollouts/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 appVersion: "v1.0.2" description: A Helm chart for Argo Rollouts name: argo-rollouts -version: 2.1.0 +version: 2.1.1 icon: https://argoproj.github.io/argo-rollouts/assets/logo.png home: https://github.com/argoproj/argo-helm maintainers: @@ -11,4 +11,4 @@ maintainers: - name: jessesuen annotations: artifacthub.io/changes: | - - "[Added]: Keep CRDs on Helm uninstall by default, add corresponding option" + - "[Added]: Two separate tests. One for default values and one for dashboard enabled." diff --git a/charts/argo-rollouts/ci/default-values.yaml b/charts/argo-rollouts/ci/default-values.yaml new file mode 100644 index 00000000..507f1e54 --- /dev/null +++ b/charts/argo-rollouts/ci/default-values.yaml @@ -0,0 +1 @@ +# Test with default values diff --git a/charts/argo-rollouts/ci/enable-dashboard-values.yaml b/charts/argo-rollouts/ci/enable-dashboard-values.yaml new file mode 100644 index 00000000..5c0a1c04 --- /dev/null +++ b/charts/argo-rollouts/ci/enable-dashboard-values.yaml @@ -0,0 +1,6 @@ +# Test with dashboard enabled +# Do not deploy the CRDs as they are already present from the previous test +installCRDs: false + +dashboard: + enabled: true diff --git a/charts/argo-rollouts/ci/test-values.yaml b/charts/argo-rollouts/ci/test-values.yaml deleted file mode 100644 index 7ea0c4c8..00000000 --- a/charts/argo-rollouts/ci/test-values.yaml +++ /dev/null @@ -1,2 +0,0 @@ -dashboard: - enabled: true From 098d59cbd797ee5f7211459f92738e0c1f02b4a6 Mon Sep 17 00:00:00 2001 From: Marco Kilchhofer Date: Mon, 27 Sep 2021 17:17:50 +0200 Subject: [PATCH 2/2] chore(argo-workflows): Also test with default values (#950) Signed-off-by: Marco Kilchhofer --- charts/argo-workflows/Chart.yaml | 4 ++-- charts/argo-workflows/ci/default-values.yaml | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 charts/argo-workflows/ci/default-values.yaml diff --git a/charts/argo-workflows/Chart.yaml b/charts/argo-workflows/Chart.yaml index 591b3aaf..a36c9cb2 100644 --- a/charts/argo-workflows/Chart.yaml +++ b/charts/argo-workflows/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: argo-workflows description: A Helm chart for Argo Workflows type: application -version: 0.7.0 +version: 0.7.1 appVersion: "v3.1.8" icon: https://raw.githubusercontent.com/argoproj/argo-workflows/master/docs/assets/argo.png home: https://github.com/argoproj/argo-helm @@ -15,4 +15,4 @@ maintainers: - name: benjaminws annotations: artifacthub.io/changes: | - - "[Added]: Add server.serviceNodePort parameter" + - "[Added]: Also test with default values" diff --git a/charts/argo-workflows/ci/default-values.yaml b/charts/argo-workflows/ci/default-values.yaml new file mode 100644 index 00000000..507f1e54 --- /dev/null +++ b/charts/argo-workflows/ci/default-values.yaml @@ -0,0 +1 @@ +# Test with default values