From f8d3f4dccc12c771a3e6395f5edc5c3768b32141 Mon Sep 17 00:00:00 2001
From: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Date: Tue, 10 Aug 2021 11:28:54 +0200
Subject: [PATCH] Apply suggestions from code review

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
---
 charts/argo-cd/testhelm.yaml                                    | 0
 charts/argo-rollouts/Chart.yaml                                 | 1 +
 charts/argo-rollouts/templates/dashboard/clusterrole.yaml       | 2 +-
 .../argo-rollouts/templates/dashboard/clusterrolebinding.yaml   | 2 +-
 charts/argo-rollouts/templates/dashboard/sa.yaml                | 2 +-
 5 files changed, 4 insertions(+), 3 deletions(-)
 create mode 100644 charts/argo-cd/testhelm.yaml

diff --git a/charts/argo-cd/testhelm.yaml b/charts/argo-cd/testhelm.yaml
new file mode 100644
index 00000000..e69de29b
diff --git a/charts/argo-rollouts/Chart.yaml b/charts/argo-rollouts/Chart.yaml
index f2b3c16f..5d5c546e 100644
--- a/charts/argo-rollouts/Chart.yaml
+++ b/charts/argo-rollouts/Chart.yaml
@@ -4,6 +4,7 @@ description: A Helm chart for Argo Rollouts
 name: argo-rollouts
 version: 1.1.0
 icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
+)
 home: https://github.com/argoproj/argo-helm
 maintainers:
   - name: alexmt
diff --git a/charts/argo-rollouts/templates/dashboard/clusterrole.yaml b/charts/argo-rollouts/templates/dashboard/clusterrole.yaml
index a5d45de0..071ba962 100644
--- a/charts/argo-rollouts/templates/dashboard/clusterrole.yaml
+++ b/charts/argo-rollouts/templates/dashboard/clusterrole.yaml
@@ -1,4 +1,4 @@
-{{- if and ( eq .Values.dashboard.enabled true) ( eq .Values.clusterInstall true) }}
+{{- if and .Values.dashboard.enabled .Values.clusterInstall }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
diff --git a/charts/argo-rollouts/templates/dashboard/clusterrolebinding.yaml b/charts/argo-rollouts/templates/dashboard/clusterrolebinding.yaml
index 3e0b3497..331fbe4e 100644
--- a/charts/argo-rollouts/templates/dashboard/clusterrolebinding.yaml
+++ b/charts/argo-rollouts/templates/dashboard/clusterrolebinding.yaml
@@ -1,4 +1,4 @@
-{{- if and ( eq .Values.dashboard.enabled true) ( eq .Values.clusterInstall true) }}
+{{- if and .Values.dashboard.enabled .Values.clusterInstall }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
diff --git a/charts/argo-rollouts/templates/dashboard/sa.yaml b/charts/argo-rollouts/templates/dashboard/sa.yaml
index 9a67acce..ff0c7300 100644
--- a/charts/argo-rollouts/templates/dashboard/sa.yaml
+++ b/charts/argo-rollouts/templates/dashboard/sa.yaml
@@ -1,4 +1,4 @@
-{{- if and ( eq .Values.dashboard.enabled true) ( eq .Values.dashboard.serviceAccount.create true) }}
+{{- if and .Values.dashboard.enabled .Values.dashboard.serviceAccount.create }}
 apiVersion: v1
 kind: ServiceAccount
 metadata: