Commit graph

100 commits

Author SHA1 Message Date
Marco Maurer (-Kilchhofer)
c77cb712e0
feat(argo-cd): Update to Argo CD 2.14 (#3155)
* feat(argo-cd): Update to Argo CD 2.14

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>

* fix: Add more customization options to commit-server

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>

* fix: Bump appVersion to v2.14.1

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>

* fix: Add 'resources' to commit-server

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>

* chore: Drop commitServer.service.type

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>

* fix: Add ability to disable the commit-server

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>

* chore: Drop commitServer.replicas since there are no upstream docs

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>

* feat: Allow adding extraVolume and mounts

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>

* chore: Disable commit-server by default

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>

* feat: Dedicated metrics service with basic customization options

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>

---------

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
2025-02-04 12:25:53 +01:00
Bhavin Kotak
07c5b5df98
fix(argo-cd): Fix REDIS_PASSWORD optional flag (#3058)
* fix(argo-cd): Fix REDIS_PASSWORD optional flag

Signed-off-by: Bhavin Kotak <kotak.bhavin@gmail.com>

* update charge version

Signed-off-by: Bhavin Kotak <kotak.bhavin@gmail.com>

---------

Signed-off-by: Bhavin Kotak <kotak.bhavin@gmail.com>
2024-11-28 09:41:56 +09:00
d3adb5
133e70a9ea
feat(argo-cd): allow setting runtime class name (#2930)
Allow chart users to set a runtime class name for all Argo CD
components.

Signed-off-by: d3adb5 <me@d3adb5.net>
2024-09-20 08:59:01 +01:00
Aikawa
817182bdb0
fix(argo-cd): Fix Redis race condition due to optional REDIS_PASSWORD (#2839)
Signed-off-by: yu-croco <yu.croco@gmail.com>
2024-08-08 16:02:08 +01:00
Petr Drastil
97a3db19cf
feat(argo-cd): Upgrade to Argo CD 2.12.0 (#2820) 2024-08-05 17:21:48 +02:00
shlomi tubul
9cefbb3daf
fix(argo-cd): Make REDIS_PASSWORD environment variables optional always (#2800) 2024-06-29 06:52:17 +09:00
shlomi tubul
171177ab77
feat(argo-cd): add support for passing redis - sentinel credentials (#2492)
* feat: add support for passing redis - sentinel credentials

Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai>

* feat: add changelog annotations

Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai>

* Update Chart.yaml

Signed-off-by: shlomi tubul <33376277+shlomitubul@users.noreply.github.com>

* Update Chart.yaml

Signed-off-by: shlomi tubul <33376277+shlomitubul@users.noreply.github.com>

* Update Chart.yaml

Signed-off-by: shlomi tubul <33376277+shlomitubul@users.noreply.github.com>

---------

Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai>
Signed-off-by: shlomi tubul <33376277+shlomitubul@users.noreply.github.com>
2024-06-26 12:28:42 +01:00
smcavallo
02949b14b1
fix(argo-cd): Default repo-server init container resources to empty (#2786) 2024-06-21 23:01:27 +02:00
Marco Maurer (-Kilchhofer)
fcee9a6046
fix(argo-cd): Enable Redis authentication in the default installation (#2705) 2024-05-21 18:36:32 +02:00
Andres Vara
7be9b016fb
feat(argo-cd): Support ability to set .Values.namespaceOverride (#2679)
* feat(argo-workflows): Allow adding additional ServiceAccounts to RoleBinding (#2676)

remove unnecessary if statements

Signed-off-by: Daniel Beilin <daniel.beilin@outlook.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
Signed-off-by: Andres Vara Parsegov <andres.vara@chase.com>

* feat(argo-cd): Support ability to set .Values.namespaceOverride

Signed-off-by: Andres Vara Parsegov <andres.vara@chase.com>

* fix(argo-cd): typo

Signed-off-by: Andres Vara Parsegov <andres.vara@chase.com>

* chore(deps): update actions/create-github-app-token action to v1.10.0 (#2677)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Signed-off-by: Andres Vara Parsegov <andres.vara@chase.com>

* feat(argo-rollouts): Add podLabels at the controller & dashboard level (#2678)

Signed-off-by: Andres Vara Parsegov <andres.vara@chase.com>

* feat(argo-cd): Support ability to set .Values.namespaceOverride

Signed-off-by: Andres Vara Parsegov <andres.vara@chase.com>

* fix(argo-cd): typo

Signed-off-by: Andres Vara Parsegov <andres.vara@chase.com>

* fix(argo-cd): autocorrection

Signed-off-by: Andres Vara Parsegov <andres.vara@chase.com>

* fix(argo-cd): typos

Signed-off-by: Andres Vara Parsegov <andres.vara@chase.com>

* fix(argo-cd): typos

Signed-off-by: Andres Vara Parsegov <andres.vara@chase.com>

* removed auota

Signed-off-by: Andres Vara Parsegov <andres.vara@chase.com>

* Update Chart.yaml

Signed-off-by: Andres Vara <46708607+andres-vara@users.noreply.github.com>

---------

Signed-off-by: Daniel Beilin <daniel.beilin@outlook.com>
Signed-off-by: Andres Vara Parsegov <andres.vara@chase.com>
Signed-off-by: Andres Vara <46708607+andres-vara@users.noreply.github.com>
Co-authored-by: Daniel Beilin <144586547+dbeilin@users.noreply.github.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
Co-authored-by: Andres Vara Parsegov <andres.vara@chase.com>
Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: mitchell amihod <mitchell@amihod.com>
2024-05-14 16:17:31 +01:00
Ilia Lazebnik
1098ce1287
feat(argo-cd): Upgrade argocd to 2.11.0 + crd changes (#2681) 2024-05-08 08:21:09 +02:00
Stefan Caraiman
f42e0e1fd5
fix(argo-cd): make automountServiceAccountToken configurable (#2625) 2024-04-10 22:05:47 +02:00
Pierre Blais
72f0a50d70
feat(argo-cd): Add sizeLimit parameters on emptyDir (#2607)
* feat(argo-cd): Add sizeLimit parameters on emptyDir

Signed-off-by: Pierre BLAIS <pierreblais@hotmail.fr>

* feat(argo-cd): Bumping chart version

Signed-off-by: Pierre BLAIS <pierreblais@hotmail.fr>

* Fix(argo-cd): Add missing new line

Signed-off-by: Pierre BLAIS <pierreblais@hotmail.fr>

---------

Signed-off-by: Pierre BLAIS <pierreblais@hotmail.fr>
Signed-off-by: Pierre Blais <109473352+pierreblais@users.noreply.github.com>
Co-authored-by: Tim Collins <45351296+tico24@users.noreply.github.com>
2024-04-02 14:36:34 +01:00
Oscar Wieman
7c8fab5a7f
feat(argo-cd): Add support for application controller dynamic cluster distribution. (#2539)
* Add support for application controller dynamic cluster distribution.

Signed-off-by: Oscar Wieman <oscar@oscarr.nl>

* Added env variables to handle the non-standard names generated by the helm chart.
https://argo-cd.readthedocs.io/en/release-2.9/user-guide/environment-variables/
99723143b9/common/common.go (L252)

Signed-off-by: Oscar Wieman <oscar@oscarr.nl>

---------

Signed-off-by: Oscar Wieman <oscar@oscarr.nl>
2024-02-25 12:47:00 +00:00
Petr Drastil
79a24410b5
chore(argo-cd): Remove server.config leftovers (#2504) 2024-02-13 12:13:41 +01:00
Petr Drastil
b8212e0b30
chore(argo-cd): Remove deprecated features and redesign Ingress (#2407)
* chore(argo-cd): Remove deprecated features

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Remove wildcard catch all ingress rule

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Add ingress extra rules

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Remove unnecessary ingress variables

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Improve documentation

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Replace ingress paths and hosts with single backend service

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Use only port number to support all ingress controllers

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Minor gRPC fixes

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Simplify TLS configuration

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Decouple AWS and GKE ALB from generic ingress

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Remove map nesting for ApplicationSet ingress

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Use example.com domain

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Remove fallback for argocd-cm checksum annotation

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Add revisionHistoryLimit for controller

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Update README

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Update README

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

---------

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
2024-02-07 21:40:05 +00:00
Petr Drastil
0b79f5e5c1
feat(argo-cd): Upgrade Argo CD to 2.10.0 (#2476)
* chore(argo-cd): Update dependency argoproj/argo-cd to v2.10.0

* Apply automatic changes

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update CRDs to v2.10.0

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Add variables for new features

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Fix version in Chart.yaml

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
2024-02-07 08:10:12 +01:00
Michele Sacchetti
508162f1cc
feat(argo-cd): Add optional mapping of argocd-repo-server emptydir to custom volumes (#2410)
* Add optional volumes to replace emptydir

Provide user-driven option to replace emptydir volumes with desired solution

Signed-off-by: Michele Sacchetti <michele.sacchetti@aroundthecode.org>

* existingVolumes default values

provide default values with empy object to ensure default behavior is backward-compatible

Signed-off-by: Michele Sacchetti <michele.sacchetti@aroundthecode.org>

* Update Chart.yaml

bump version

Signed-off-by: Michele Sacchetti <michele.sacchetti@aroundthecode.org>

* Update Chart.yaml

add changelog

Signed-off-by: Michele Sacchetti <michele.sacchetti@aroundthecode.org>

* fix docs

fix docs on new entry

Signed-off-by: Michele Sacchetti <michele.sacchetti@aroundthecode.org>

* fix readme

Signed-off-by: Michele Sacchetti <michele.sacchetti@aroundthecode.org>

* Update README.md.gotmpl

Signoff commit

Signed-off-by: Michele Sacchetti <michele.sacchetti@aroundthecode.org>

* fix readme

Signed-off-by: Michele Sacchetti <michele.sacchetti@aroundthecode.org>

* fixCamelCase
Signed-off-by: Michele Sacchetti <michele.sacchetti@aroundthecode.org>

---------

Signed-off-by: Michele Sacchetti <michele.sacchetti@aroundthecode.org>
2024-01-18 14:56:33 +01:00
Petr Drastil
107bd3bc53
chore(argo-cd): DRY cleanup of ServiceAccounts (#2409)
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
2024-01-05 12:56:59 +00:00
Petr Drastil
f634cf6e9c
feat(argo-cd): Upgrade Argo CD to 2.9.0 (#2318)
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
2023-11-06 13:54:34 +01:00
gussan
a41b70b59c
feat(argo-cd): add terminationGracePeriodSeconds (#2310)
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
2023-10-27 10:43:52 +01:00
sibucan
7a17fc2dc9
fix(argo-cd): Add checksum for CMP ConfigMap in repo-server Pod annotations (#2275)
Add checksum for CMP ConfigMap in repo-server

This helm chart defines the plugins as ConfigMaps -- according to the docs, when the CM is modified, the repo-server Pod must be restarted to have the sidecars pick up the latest changes:

https://argo-cd.readthedocs.io/en/stable/operator-manual/config-management-plugins/#debugging-a-cmp

The changes in this helm chart allow for a checksum to be calculated from the ConfigMap and added as a Pod annotation so whenever the CM values are modified, the Pod is restarted automatically.

Signed-off-by: sibucan <luis.ramirez.rivera92@gmail.com>
2023-09-19 10:01:42 +01:00
Andrew Hamilton
eebb8c8d48
feat(argo-cd): adds toggle for helm-working-dir (#2249)
- Adds a toggle to be able to turn off the helm-working-dir for the
  repo server deployment. Using a shared helm repo storage directory can
  cause issues when multiple helm commands are being run in parallel.
  The repo server also has the ability to rebuild the repos and do
  updates in the normal flow for checking the status of an application
  so it won't cause issues if it's disabled.

Signed-off-by: Andrew Hamilton <ahamilton55@gmail.com>
2023-09-09 17:55:47 +09:00
Aikawa
95310f995b
fix(argo-cd): Restart Repo Server and Application Controller as following the change of Argo CD CM (#2235)
* fix(argo-cd): Restart Repo Server and Application Controller as following the change of Argo CD CM

Signed-off-by: yu-croco <yu.croco@gmail.com>

* fix(argo-cd): Aligne condition to argocd-cm

Signed-off-by: yu-croco <yu.croco@gmail.com>

---------

Signed-off-by: yu-croco <yu.croco@gmail.com>
2023-09-08 15:02:25 +01:00
Petr Drastil
3e35b0c7f7
feat(argo-cd): Upgrade Argo CD to 2.8.0 (#2170)
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
2023-08-08 23:35:41 +09:00
Joe Lee
49c2ca2548
feat(argo-cd): Add "global.env" for all deployed containers (#2096)
* add global env for argo-cd

Signed-off-by: Joe Lee <lj_2005@163.com>

* update readme

Signed-off-by: Joe Lee <lj_2005@163.com>

* fix typo

Signed-off-by: Joe Lee <lj_2005@163.com>

* feat(argo-cd): Add "global.env" for all deployed containers

Signed-off-by: Joe Lee <lj_2005@163.com>

* update doc

Signed-off-by: Joe Lee <lj_2005@163.com>

* remove note

Signed-off-by: Joe Lee <lj_2005@163.com>

* update changes

Signed-off-by: Joe Lee <lj_2005@163.com>

---------

Signed-off-by: Joe Lee <lj_2005@163.com>
2023-06-07 17:52:02 +09:00
Wim Fournier
cd4c291e47
fix(argo-cd): Allow to disable containerSecurityContext (#2072)
* Allow to disable containerSecurityContext

Add a `enabled` property to allow the whole containerSecurityContext to be disabled.
Fixes https://github.com/argoproj/argo-helm/issues/2071

Signed-off-by: wim.fournier <github@fournier.nl>
Signed-off-by: Wim Fournier <github@fournier.nl>

* fix missing space

Signed-off-by: Wim Fournier <github@fournier.nl>

* remove enabled key

Signed-off-by: Wim Fournier <github@fournier.nl>

* fix typo

Signed-off-by: Wim Fournier <github@fournier.nl>

* missed one

Signed-off-by: Wim Fournier <github@fournier.nl>

* simplify using `with`, thx @pborn-ionos!

Signed-off-by: wim.fournier <wim.fournier@adevinta.com>

* missed one

Signed-off-by: wim.fournier <wim.fournier@adevinta.com>

---------

Signed-off-by: wim.fournier <github@fournier.nl>
Signed-off-by: Wim Fournier <github@fournier.nl>
Signed-off-by: wim.fournier <wim.fournier@adevinta.com>
Co-authored-by: wim.fournier <wim.fournier@adevinta.com>
2023-05-23 15:29:26 -05:00
GoshaDozoretz
05bc6a236d
feat(argo-cd): add lifecycle hooks to repo server (#1922)
* add lifesycle webhook to repo server

Signed-off-by: goshado <goshatoo@gmail.com>

* add lifesycle webhook to repo server

Signed-off-by: goshado <goshatoo@gmail.com>

* add lifesycle webhook to repo server

Signed-off-by: goshado <goshatoo@gmail.com>

---------

Signed-off-by: goshado <goshatoo@gmail.com>
Signed-off-by: GoshaDozoretz <106976988+gosharo@users.noreply.github.com>
Co-authored-by: goshado <goshatoo@gmail.com>
2023-05-17 15:40:18 +02:00
Aikawa
decfc73a3f
feat(argo-cd): Use tini as the ENTRYPOINT (#1991) 2023-05-02 07:29:30 -05:00
Jakub Oskera
88d690ef62
fix(argo-cd): add namespace field for namespace scoped resources (#1937) 2023-04-13 09:08:34 -05:00
Laurent Lavaud
4ea0119321
feat(argo-cd): Add support for custom Deployment strategy (#1918)
Signed-off-by: Laurent Lavaud <l.lavaud@gmail.com>
2023-04-03 10:58:50 +01:00
Gergely Czuczy
3c24d55fa4
feat(argo-cd): Entrypoint can be configured now (#1898)
* Entrypoint can be configured now

Signed-off-by: Gergely Czuczy <gergely.czuczy@sap.com>

* Updated charts.lock after following master

Signed-off-by: Gergely Czuczy <gergely.czuczy@sap.com>

* Bump version

Signed-off-by: Gergely Czuczy <gergely.czuczy@sap.com>

---------

Signed-off-by: Gergely Czuczy <gergely.czuczy@sap.com>
Signed-off-by: Gergely Czuczy <gergely.czuczy@harmless.hu>
2023-03-30 17:33:14 +01:00
LucasBoisserie
d34a376568
fix(argo-cd): Disable hostNetwork field when is set to false (#1934)
* fix(argo-cd): fix host network configuration

Signed-off-by: LucasBoisserie <lucas.boisserie@gmail.com>

* update changelog

Signed-off-by: LucasBoisserie <lucas.boisserie@gmail.com>

---------

Signed-off-by: LucasBoisserie <lucas.boisserie@gmail.com>
2023-03-28 14:48:09 +01:00
Petr Drastil
053a338ea9
feat(argo-cd): Add additional global parameters for scheduling (#1846)
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
2023-03-02 23:28:23 +09:00
Petr Drastil
88b92909e6
chore(argo-cd): Add missing hostAliases to all components (#1848)
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
2023-02-23 19:11:54 +01:00
Petr Drastil
51386c69be
feat(argo-cd): Add global affinity configuration (#1794) 2023-02-17 10:38:17 -06:00
Loris
d59ae7bd75
feat(argo-cd): Add dnsConfig and dnsPolicy for pods (#1773)
feat(argo-cd): Add dnsConfig and dnsPolicy for pods (#1771)

Signed-off-by: Loris Torikian <loris_torikian@hotmail.fr>
Co-authored-by: Loris Torikian <loris.torikian@square-sense.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2023-02-15 09:11:16 +09:00
Tone
05c79e322a
feat(argo-cd): Configurable dnsPolicy / hostNetwork (#1821) 2023-02-05 22:40:13 -06:00
Petr Drastil
58f587618f
fix(argo-cd): Consolidate and fix container ports (#1788)
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
2023-01-21 13:07:14 +01:00
Petr Drastil
31242020c4
feat(argo-cd): Allow templated values for init and extra containers (#1749) 2023-01-10 06:31:57 -06:00
John Stewart
b97e652f63
feat(argo-cd): Add ability to annotate Deployments and StatefulSets (#1608)
* feat(argo-cd): Add ability to annotate Deployments and StatefulSets

Signed-off-by: John Stewart <jstewart@rentpath.com>

* fix: Controller and AppSet controller was mixed

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Signed-off-by: John Stewart <jstewart@rentpath.com>
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2022-12-01 00:25:22 +01:00
Karl Parry
a0784fddac
fix(argo-cd): Rename tls secret to include the -secret suffix (#1676)
- "[Fixed]: TLS secret name so Dex correctly generates the checksum for argocd-dex-server-tls."
- "[Fixed]: Standardise the naming convention of the TLS secret manifests."
- "[Added]: Add checksum to Repo-Server for the argocd-repo-server-tls secret."

Signed-off-by: Karl Parry <karl.parry@imbursepayments.com>
2022-11-30 22:38:04 +01:00
Petr Drastil
1b2e7ca984
feat(argo-cd): Add revisionHistoryLimit (#1599)
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
2022-11-01 20:26:44 +01:00
Petr Drastil
3d9e2f35a6
feat(argo-cd): Set container security contexts (#1579)
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
2022-10-30 20:12:46 +01:00
Petr Drastil
7e30521dd2
feat(argo-cd): Upgrade Argo CD to 2.5.0 (#1568)
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
2022-10-25 23:22:22 +02:00
Petr Drastil
3351b30ee6
chore(argo-cd): Use same resources for repo-server copyutil (#1531)
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
2022-10-11 16:11:15 +02:00
Petr Drastil
ba733e921d
fix(argo-cd): Rendering of node selector for repoServer (#1484)
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
2022-09-22 10:52:41 +02:00
Petr Drastil
edf29d2e15
Add argocd-cmd-params-cm (#1267)
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
2022-09-21 13:48:37 +02:00
Marco
0bac122e98
fix(argo-cd): Add automountServiceAccountToken to repoServer (#1436)
Signed-off-by: Marco Lecheler <marco@task.media>
2022-09-04 10:48:13 +02:00
Mathieu Parent
71da4e98f2
fix(argo-cd): Remove version labels to avoid invalid characters (#1432) 2022-08-30 17:30:29 +02:00