* docs(github): comment out notational pieces of PR template (#1969)
github: comment out notational pieces of PR template
- the DCO and publishing sentences are not filled out during PRs
and are purely notational
- comment them out with HTML comments, as is common practice
- example from a repo I maintain: f6db59613a/.github/issue_template.md (L2)
- I copied that from other repos too
- these comments are still visible to the PR author, just not visible
when rendered, keeping the PR more concise
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Tal Yitzhak <talyi@jfrog.com>
* Added missing permissions for argo rollouts dashboard cluster role - for config map, should be able to get
Signed-off-by: Tal Yitzhak <talyi@jfrog.com>
* Added missing permissions for argo rollouts dashboard cluster role - for config map, should be able to get
Signed-off-by: Tal Yitzhak <talyi@jfrog.com>
---------
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Tal Yitzhak <talyi@jfrog.com>
Signed-off-by: Tal Yitzhak <yitzhtal@gmail.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Tal Yitzhak <talyi@jfrog.com>
* feat(argo-rollouts): Add flag to optionally disable the creation of cluster roles (even when running in cluster mode)
Signed-off-by: Joshua Helton <jdoghelton@gmail.com>
* fix README.md with helm-docs.sh
Signed-off-by: Joshua Helton <jdoghelton@gmail.com>
Signed-off-by: Joshua Helton <jdoghelton@gmail.com>
Co-authored-by: JM <jmeridth@gmail.com>
* feat(argo-rollouts): add dashboard permission on Deployments
- needed for Rollouts with workload referencing
Signed-off-by: Ben Poland <ben.poland@faire.com>
* Add podtemplates to match controller role
Signed-off-by: Ben Poland <ben.poland@faire.com>
* feat(argo-rollouts): add dashboard deployment and service
credit: the implemention is inspired by the work from
Andrii Perenesenko <andrii.perenesenko@gmail.com>.
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
* Apply suggestions from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Add components to selectlabels
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
* Bump major version and add upgrading note
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
* fix: Documentation on dashboard values, change annotations
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
* feat: Enable dashboard during chart testing
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Hui Kang <hui.kang@salesforce.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
