James Slater
03c26fc21f
fix(argo-workflows): Fix trailing whitespace in controller ConfigMap ( #2451 )
...
This commit addresses two places where trailing whitespace may be
generated in the workflow-controller ConfigMap.
When the value `.resourceRateLimit` is not null, a trailing whitespace
is added after "resourceRateLimit:". This commit trims that whitespace.
When the value `.sso.redirectUrl` is left as the default of empty string,
a trailing whitespace is left after "redirectUrl:" as this value is not
quoted. This commit pipes this value through `quote` to ensure this
whitespace is no longer trailing and instead followed by `"` pair.
The main motivation of this commit is to generate a workflow-controller
ConfigMap that is properly pretty-printed, which trailing whitespace
prevents.
Signed-off-by: James Slater <SlaterByte@users.noreply.github.com>
Co-authored-by: James Slater <SlaterByte@users.noreply.github.com>
2024-01-25 08:57:56 +09:00
Josia
c962ee500c
fix(argo-workflows): Prevent extra whitespace in controller ConfigMap ( #2399 )
...
Signed-off-by: Josia <josiarodriguez@gmail.com>
2023-12-24 09:28:35 +09:00
Neile Havens
77a4196fc3
fix(argo-workflows): Remove duplication in aggregated admin ClusterRole ( #2389 )
...
Signed-off-by: Neile Havens <neilehavens@gmail.com>
2023-12-15 16:45:22 +09:00
Ilia Lazebnik
9ca3f06dcf
feat(argo-workflows): add hostAliases to server ( #2387 )
...
* workflow server hostalises
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
* Update Chart.yaml
Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com>
* workflow server hostalises
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
---------
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com>
2023-12-14 07:56:27 +00:00
workwithprashant
e07f69fee6
fix(argo-workflows): fix helm lint error when extraObjects is defined ( #2384 )
2023-12-12 06:27:39 +00:00
Neile Havens
a9e31c82fd
feat(argo-workflows): Add support for sso filterGroupsRegex ( #2379 )
...
According to https://argoproj.github.io/argo-workflows/argo-server-sso/#filtering-groups
Resolves #2378
Signed-off-by: Neile Havens <neilehavens@gmail.com>
2023-12-09 07:44:59 +09:00
Aikawa
2c046f9a9a
fix(argo-workflows): Add missing permission to workflow role ( #2367 )
2023-12-05 05:55:10 +00:00
qa-florian-wende
7261decaf8
feat(argo-workflows): Make workflow controller ConfigMap optional ( #2354 )
2023-11-27 17:44:58 +00:00
Aikawa
9496f2f1e6
fix(argo-workflows): Align version label ( #2342 )
...
* fix(argo-workflows): Aligne version label
Signed-off-by: yu-croco <yu.croco@gmail.com>
* fix(argo-workflows): fix typo
Signed-off-by: yu-croco <yu.croco@gmail.com>
---------
Signed-off-by: yu-croco <yu.croco@gmail.com>
2023-11-15 13:32:49 +00:00
Matt Dainty
737b9724de
fix(argo-workflows): Add parameters for tuning revisionHistoryLimit and emptyDir volumes ( #2346 )
2023-11-15 07:17:09 -06:00
Aikawa
9840ebedc6
fix(argo-workflows): Accept multi auth mode for server ( #2336 )
...
* fix(argo-workflows): Accept multi auth mode for server
Signed-off-by: yu-croco <yu.croco@gmail.com>
* chore(argo-workflows): improve description of authMode
Signed-off-by: yu-croco <yu.croco@gmail.com>
* chore(argo-workflows): keep the older value valid for now as compatibility.
Signed-off-by: yu-croco <yu.croco@gmail.com>
---------
Signed-off-by: yu-croco <yu.croco@gmail.com>
2023-11-09 01:04:58 +09:00
Ujin
a67424d0c4
feat(argo-workflows): Updated supported workers parameters ( #2297 )
...
* feat(argo-workflows): Updated supported workers parameters
Change
------
Based on argo-workflows [scaling documents](https://argoproj.github.io/argo-workflows/scaling/ )
it's possible to set following workers values: `--workflow-workers`, `--workflow-ttl-workers`, `--pod-cleanup-workers`
and statring 3.5 `--cron-workflow-workers`. This change allows chart
consumers to take advatage of _all_ these parameters.
Testing
-------
```
helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep workers
helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers
- "--workflow-workers"
- "10"
helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers
- "--workflow-workers"
- "10"
- "--workflow-ttl-workers"
- "20"
helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers
- "--workflow-workers"
- "10"
- "--workflow-ttl-workers"
- "20"
- "--pod-cleanup-workers"
- "30"
helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers
- "--workflow-workers"
- "10"
- "--workflow-ttl-workers"
- "20"
- "--pod-cleanup-workers"
- "30"
- "--cron-workflow-workers"
- "40"
```
Signed-off-by: Evgeny Khatko <owen.tko@gmail.com>
Signed-off-by: Evgeny Khatko <ekhatko@paypal.com>
* Addressing PR feedback.
Signed-off-by: Evgeny Khatko <ekhatko@paypal.com>
* newline
Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com>
* Update Chart.yaml
Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com>
* Update Chart.yaml
Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com>
---------
Signed-off-by: Evgeny Khatko <owen.tko@gmail.com>
Signed-off-by: Evgeny Khatko <ekhatko@paypal.com>
Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com>
Co-authored-by: Evgeny Khatko <ekhatko@paypal.com>
Co-authored-by: Tim Collins <45351296+tico24@users.noreply.github.com>
2023-10-24 13:34:49 +01:00
Jonathan Raymond
575ee244b2
fix(argo-workflows): add all crds to aggregate-roles template ( #2301 )
...
fix: add all crds to aggregate-roles
Signed-off-by: Jonathan Raymond <jonwraymond@gmail.com>
2023-10-18 08:53:16 +09:00
Koen van Zuijlen
8c72bed779
feat(argo-workflows): Added commonLabels ( #2300 )
2023-10-17 10:40:33 -05:00
Jason Meridth
df9ee892b5
chore(argo-workflows): Upgrade argo-workflows to 3.5.0 ( #2228 )
...
Diff based on the rc1 branch currently here [3.4.10...3.5.0](https://github.com/argoproj/argo-workflows/compare/v3.4.10...v3.5.0 )
Signed-off-by: jmeridth <jmeridth@gmail.com>
2023-10-13 22:59:02 +01:00
Aikawa
2730dc24c7
feat(argo-workflows): Configure declarative server auth mode ( #2291 )
2023-10-12 09:14:41 -05:00
Fuochi
dc56fa63f3
feat(argo-workflows): add imagePullSecret for workflow sa ( #2226 )
...
Signed-off-by: Fuochi <ffuochi@hotmail.com>
2023-08-17 13:08:03 +01:00
Anton Gilgur
a64615414d
fix(argo-workflows): Server only needs get Secrets ( #2211 )
...
- as of aa366db345https://github.com/argoproj/argo-workflows/blob/master/CHANGELOG.md#v340-rc1-2022-08-09 ), and the current version of the chart uses v3.4.9 (per `Chart.yaml#appVersion`)
- `update` is not needed either for SSO secret
- manifests RBAC: a68ea0feab/manifests/cluster-install/argo-server-rbac/argo-server-clusterole.yaml (L18)20d0923611/server/auth/sso/sso.go (L140)20d0923611/server/auth/sso/sso.go (L151)20d0923611/server/auth/sso/sso.go (L127)20d0923611/server/auth/sso/sso.go (L106)
2023-08-11 10:14:54 +09:00
Andy Cobaugh
98da71eb87
feat(argo-workflows): allow setting executor args ( #2177 )
2023-07-27 08:57:46 -05:00
gussan
5ec59e90fa
feat(argo-workflows): Add support for artifactRepositoryRef ( #2135 )
...
Signed-off-by: tomoki-yamaguchi <toyamagu2021@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
Co-authored-by: Tim Collins <45351296+tico24@users.noreply.github.com>
2023-07-11 13:07:08 +01:00
toyamagu
f1526ec558
fix(argo-workflows): artifactRepository will not be configured by default ( #2132 ) ( #2134 )
2023-06-24 17:28:46 -05:00
frauniki
490ffa574c
fix(argo-workflows): Change argo-workflows-server crb creation conditions ( #2124 )
...
Change server's crb creation conditions
Signed-off-by: frauniki <frauniki@sinoa.jp>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
2023-06-23 11:35:01 -05:00
Simon Hewitt
e7c3090cbf
feat(argo-workflows): Add support for UI columns configuration ( #2098 )
2023-06-07 22:48:05 -05:00
Aikawa
5fb6688bcb
chore(argo-workflows): Declare SSO configuration explicitly on values.yaml ( #2089 )
...
Signed-off-by: yu-croco <yu.croco@gmail.com>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
2023-06-03 09:40:50 -05:00
Aikawa
23b94151c6
chore(argo-workflows): Enable to configure Service Monitor port ( #2076 )
2023-05-25 07:30:48 -05:00
Julien Michaud
5766533626
feat(argo-workflows): support google ManagedCertificate, FrontendConfig & BackendConfig for gce ingress ( #2066 )
...
* feat: add gke stuff
Signed-off-by: julien.michaud <julien.michaud@mirakl.com>
* update readme and chart.yaml file
Signed-off-by: julien.michaud <julien.michaud@mirakl.com>
* fix readme
Signed-off-by: julien.michaud <julien.michaud@mirakl.com>
* docs: Apply changes from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
---------
Signed-off-by: julien.michaud <julien.michaud@mirakl.com>
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2023-05-19 11:35:33 +01:00
Cyril Jouve
5873a1bc33
feat(argo-workflows): allow extraObjects to contain string template ( #1995 )
...
[argo-workflows] allow extraObjects to contain string template
Signed-off-by: Cyril Jouve <jv.cyril@gmail.com>
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2023-05-11 15:39:17 +09:00
PidgeyBE
f6d44750b8
fix(argo-workflows): Fix templating in several places ( #2026 )
...
* Add artifacthub changes
Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>
* fix templating list of yamls
Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>
* Bump version and fix templating for gcs and azure as well
Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>
---------
Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>
Co-authored-by: Aikawa <yu.croco@gmail.com>
2023-05-11 09:09:33 +09:00
PidgeyBE
cc64b0c9f5
fix(argo-workflows): fix clusterworkflowtemplates disabled flag ( #2033 )
...
* fix clusterworkflowtemplates disabled flag
Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>
* Bump chart version and add artifacthub changes
Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>
---------
Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
2023-05-10 19:16:14 +09:00
ryanpark0203
c8b47cf060
fix(argo-workflows): Fix Helm chart to correctly reference Kubernetes version in conditional check for HPA apiVersion ( #2029 )
...
* add a fix for argo workflows hpa
Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>
* add description for the fix
Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>
* update readme
Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>
* remove apiVersionOverrides from readme
Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>
* fix linting
Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>
---------
Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
2023-05-09 12:41:54 +09:00
Jason Meridth
2197c8e040
fix(argo-workflows): Drop .Values.useDefaultArtifactRepo flag to simplify usage ( #2002 )
...
Fixes #1140
- [x] remove `.Values.useDefaultArtifactRepo` to ensure if items populated they get into the configmap.
- [x] change structure of `.Values.customArtifactRepository` to only include the custom information
Signed-off-by: jmeridth <jmeridth@gmail.com>
2023-05-05 09:30:53 -05:00
Jason Meridth
513df3df8f
fix(argo-workflows): Add missing argo-workflows.apiVersion.autoscaling helper function for HPA configuration ( #2001 )
...
fix: Add missing argo-workflows.apiVersion.autoscaling helper function for HPA configuration
Signed-off-by: jmeridth <jmeridth@gmail.com>
2023-05-05 15:13:41 +01:00
Stefan Tertan
00e585342a
feat(argo-workflows): add Prometheus ServiceMonitor relabelings, metricRelabelings & targetLabels ( #1977 )
...
* feat(argo-workflows): add Prometheus ServiceMonitor relabelings, metricRelabelings & targetLabels
Signed-off-by: Stefan Tertan <stefan.tertan@fundingcircle.com>
* chore(argo-workflows): bump Helm chart patch version
Signed-off-by: Stefan Tertan <stefan.tertan@fundingcircle.com>
* docs(argo-workflows): update README.md via `helm-docs`
Signed-off-by: Stefan Tertan <stefan.tertan@fundingcircle.com>
* chore(argo-workflows): update changelog via chart annotation
Signed-off-by: Stefan Tertan <stefan.tertan@fundingcircle.com>
* chore(argo-workflows): remove URLs from README
Signed-off-by: Stefan Tertan <stefan.tertan@fundingcircle.com>
---------
Signed-off-by: Stefan Tertan <stefan.tertan@fundingcircle.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
2023-04-24 11:57:36 -05:00
Anton Gilgur
aef554340f
feat(argo-workflows): add optional HPA to Server ( #1974 )
2023-04-24 00:47:18 -05:00
Tim Collins
22356c77af
feat(argo-workflows): Add option for controller to read all secrets ( #1967 )
2023-04-14 08:53:40 -05:00
Aikawa
7eeb70f711
fix(argo-workflows): Add namespace field to all namespace scoped resources ( #1956 )
...
Reason: `helm template` doesn't add the namespace field automatically
* fix(argo-workflows): Add namespace field to all namespace scoped resources because `helm template` doesn't add the namespace filed automatically
Signed-off-by: yu-croco <yu.croco@gmail.com>
* chore(argo-workflows): bump minor version
Signed-off-by: yu-croco <yu.croco@gmail.com>
* refactor(argo-workflows): reflect review points
Signed-off-by: yu-croco <yu.croco@gmail.com>
2023-04-13 11:25:06 +02:00
Justin Sievenpiper
56136f6518
feat(argo-workflows): add the ability to declare initContainers ( #1923 )
...
feat(argo-workflows): add the ability to declare initContainers to server and controller deployments
Signed-off-by: Justin Sievenpiper <justin@sievenpiper.co>
2023-04-07 08:43:01 +09:00
Emil Smoleński
2d193be5c0
feat(argo-workflows): Add ability to use memoization ( #1924 )
2023-03-23 02:09:03 -05:00
Jonathan Muller
f66c40319a
chore(argo-workflows): expose option to control the log format/level ( #1855 )
...
* Allow to change the log format to json
Signed-off-by: Jonathan Muller <koren@pukogames.com>
* Documentation, version
Signed-off-by: Jonathan Muller <koren@pukogames.com>
---------
Signed-off-by: Jonathan Muller <koren@pukogames.com>
2023-02-24 15:56:41 -06:00
Vlad Losev
c08fc230d7
fix(argo-workflows): clean subresource permissions ( #1835 )
2023-02-09 23:31:49 -06:00
Jason Meridth
7992b5d04b
feat(argo-workflows): Add helper function to determine image value, minus tag ( #1754 )
...
We have a situation where we want to exclude the registry so that images can
be pulled from in-network mirrors. Currently when you exclude the registry,
you get stuck with a prefixing forward slash.
Had to keep the tags in the manifest files because helm template requires
a colon in the image value. Otherwise I'd move it into the helper function.
image entries changed: server, controller, executor
Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: jmeridth <jmeridth@gmail.com>
2023-01-09 18:03:26 -06:00
Aikawa
4b8703db75
chore(argo-workflows): Support podGCDeleteDelayDuration and podGCGracePeriodSeconds ( #1728 )
...
Signed-off-by: yu-croco <yu.croco@gmail.com>
2023-01-03 10:46:01 +09:00
huiwq1990
5bd70fbd24
feat(argo-workflows): add envFrom for main container ( #1736 )
...
Signed-off-by: huiwq1990 <huiwq1990@163.com>
Signed-off-by: huiwq1990 <huiwq1990@163.com>
2022-12-29 23:20:47 -06:00
Aikawa
10e3af1bcf
chore(argo-workflows): Remove legacy API versions for PDBs ( #1741 )
...
Signed-off-by: yu-croco <yu.croco@gmail.com>
Co-authored-by: Petr Drastil <petr.drastil@gmail.com>
2022-12-29 17:31:39 +01:00
Aikawa
56f3b77fd1
chore(argo-workflows): Support missing configurations to workflow controller cm ( #1716 )
...
Signed-off-by: yu-croco <yu.croco@gmail.com>
2022-12-19 18:07:44 +09:00
Aikawa
3c8ad7be89
feat(argo-workflows): Support images property to workflow-controller-configmap for emissary executor ( #1708 )
...
* feat(argo-workflows): Support images property to workflow-controller-configmap for emissary executor
Signed-off-by: yu-croco <yu.croco@gmail.com>
* chore(argo-workflows): adopt concise name
Signed-off-by: yu-croco <yu.croco@gmail.com>
2022-12-19 08:41:56 +09:00
Pedro
5b15810e2d
fix(argo-workflows): avoid label exceeding maximum length ( #1692 )
...
fix(argo-workflows): generated value for app.kubernetes.io/version label for argo-workflows will not exceed maximum length and support image tags with a SHA digest.
Signed-off-by: Pedro Salgado <steenzout@users.noreply.github.com>
Signed-off-by: Pedro Salgado <steenzout@users.noreply.github.com>
2022-12-09 15:50:05 +09:00
Daniel Iziourov
216a52d341
fix(argo-workflows): missing artifact GC rbac ( #1680 )
...
According to the documentation:
https://argoproj.github.io/argo-workflows/walk-through/artifacts/#artifact-garbage-collection
Signed-off-by: danmx <daniel@iziourov.info>
Signed-off-by: danmx <daniel@iziourov.info>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
2022-12-02 22:49:50 +09:00
Daniel Iziourov
48e16abc42
chore(argo-workflows): removed deprecated Role rbac ( #1681 )
...
Signed-off-by: danmx <daniel@iziourov.info>
Signed-off-by: danmx <daniel@iziourov.info>
2022-12-02 19:29:25 +09:00
Aikawa
77d8a11dd8
chore(argo-workflows): Support workflow retention ( #1668 )
...
Signed-off-by: yu-croco <yu.croco@gmail.com>
2022-11-26 10:08:11 +09:00
