Commit graph

93 commits

Author SHA1 Message Date
Fuochi
dc56fa63f3
feat(argo-workflows): add imagePullSecret for workflow sa (#2226)
Signed-off-by: Fuochi <ffuochi@hotmail.com>
2023-08-17 13:08:03 +01:00
Anton Gilgur
a64615414d
fix(argo-workflows): Server only needs get Secrets (#2211)
- as of aa366db345, the Server no longer needs `list` or `watch` and only uses `get`
  - this was released as part of [v3.4.0](https://github.com/argoproj/argo-workflows/blob/master/CHANGELOG.md#v340-rc1-2022-08-09), and the current version of the chart uses v3.4.9 (per `Chart.yaml#appVersion`)

- `update` is not needed either for SSO secret
  - manifests RBAC: a68ea0feab/manifests/cluster-install/argo-server-rbac/argo-server-clusterole.yaml (L18)
  - SSO source code only uses [`create`](20d0923611/server/auth/sso/sso.go (L140)) and [`get`](20d0923611/server/auth/sso/sso.go (L151))
    - (also some `get`s above that for [`clientID`](20d0923611/server/auth/sso/sso.go (L127)) and [`clientSecret`](20d0923611/server/auth/sso/sso.go (L106)) as well)

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
2023-08-11 10:14:54 +09:00
Andy Cobaugh
98da71eb87
feat(argo-workflows): allow setting executor args (#2177) 2023-07-27 08:57:46 -05:00
gussan
5ec59e90fa
feat(argo-workflows): Add support for artifactRepositoryRef (#2135)
Signed-off-by: tomoki-yamaguchi <toyamagu2021@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
Co-authored-by: Tim Collins <45351296+tico24@users.noreply.github.com>
2023-07-11 13:07:08 +01:00
toyamagu
f1526ec558
fix(argo-workflows): artifactRepository will not be configured by default (#2132) (#2134) 2023-06-24 17:28:46 -05:00
frauniki
490ffa574c
fix(argo-workflows): Change argo-workflows-server crb creation conditions (#2124)
Change server's crb creation conditions

Signed-off-by: frauniki <frauniki@sinoa.jp>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
2023-06-23 11:35:01 -05:00
Simon Hewitt
e7c3090cbf
feat(argo-workflows): Add support for UI columns configuration (#2098) 2023-06-07 22:48:05 -05:00
Aikawa
5fb6688bcb
chore(argo-workflows): Declare SSO configuration explicitly on values.yaml (#2089)
Signed-off-by: yu-croco <yu.croco@gmail.com>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
2023-06-03 09:40:50 -05:00
Aikawa
23b94151c6
chore(argo-workflows): Enable to configure Service Monitor port (#2076) 2023-05-25 07:30:48 -05:00
Julien Michaud
5766533626
feat(argo-workflows): support google ManagedCertificate, FrontendConfig & BackendConfig for gce ingress (#2066)
* feat: add gke stuff

Signed-off-by: julien.michaud <julien.michaud@mirakl.com>

* update readme and chart.yaml file

Signed-off-by: julien.michaud <julien.michaud@mirakl.com>

* fix readme

Signed-off-by: julien.michaud <julien.michaud@mirakl.com>

* docs: Apply changes from code review

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

---------

Signed-off-by: julien.michaud <julien.michaud@mirakl.com>
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2023-05-19 11:35:33 +01:00
Cyril Jouve
5873a1bc33
feat(argo-workflows): allow extraObjects to contain string template (#1995)
[argo-workflows] allow extraObjects to contain string template

Signed-off-by: Cyril Jouve <jv.cyril@gmail.com>
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2023-05-11 15:39:17 +09:00
PidgeyBE
f6d44750b8
fix(argo-workflows): Fix templating in several places (#2026)
* Add artifacthub changes

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>

* fix templating list of yamls

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>

* Bump version and fix templating for gcs and azure as well

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>

---------

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>
Co-authored-by: Aikawa <yu.croco@gmail.com>
2023-05-11 09:09:33 +09:00
PidgeyBE
cc64b0c9f5
fix(argo-workflows): fix clusterworkflowtemplates disabled flag (#2033)
* fix clusterworkflowtemplates disabled flag

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>

* Bump chart version and add artifacthub changes

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>

---------

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
2023-05-10 19:16:14 +09:00
ryanpark0203
c8b47cf060
fix(argo-workflows): Fix Helm chart to correctly reference Kubernetes version in conditional check for HPA apiVersion (#2029)
* add a fix for argo workflows hpa

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

* add description for the fix

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

* update readme

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

* remove apiVersionOverrides from readme

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

* fix linting

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

---------

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
2023-05-09 12:41:54 +09:00
Jason Meridth
2197c8e040
fix(argo-workflows): Drop .Values.useDefaultArtifactRepo flag to simplify usage (#2002)
Fixes #1140

- [x] remove `.Values.useDefaultArtifactRepo` to ensure if items populated they get into the configmap.
- [x] change structure of `.Values.customArtifactRepository` to only include the custom information

Signed-off-by: jmeridth <jmeridth@gmail.com>
2023-05-05 09:30:53 -05:00
Jason Meridth
513df3df8f
fix(argo-workflows): Add missing argo-workflows.apiVersion.autoscaling helper function for HPA configuration (#2001)
fix: Add missing argo-workflows.apiVersion.autoscaling helper function for HPA configuration

Signed-off-by: jmeridth <jmeridth@gmail.com>
2023-05-05 15:13:41 +01:00
Stefan Tertan
00e585342a
feat(argo-workflows): add Prometheus ServiceMonitor relabelings, metricRelabelings & targetLabels (#1977)
* feat(argo-workflows): add Prometheus ServiceMonitor relabelings, metricRelabelings & targetLabels

Signed-off-by: Stefan Tertan <stefan.tertan@fundingcircle.com>

* chore(argo-workflows): bump Helm chart patch version

Signed-off-by: Stefan Tertan <stefan.tertan@fundingcircle.com>

* docs(argo-workflows): update README.md via `helm-docs`

Signed-off-by: Stefan Tertan <stefan.tertan@fundingcircle.com>

* chore(argo-workflows): update changelog via chart annotation

Signed-off-by: Stefan Tertan <stefan.tertan@fundingcircle.com>

* chore(argo-workflows): remove URLs from README

Signed-off-by: Stefan Tertan <stefan.tertan@fundingcircle.com>

---------

Signed-off-by: Stefan Tertan <stefan.tertan@fundingcircle.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
2023-04-24 11:57:36 -05:00
Anton Gilgur
aef554340f
feat(argo-workflows): add optional HPA to Server (#1974) 2023-04-24 00:47:18 -05:00
Tim Collins
22356c77af
feat(argo-workflows): Add option for controller to read all secrets (#1967) 2023-04-14 08:53:40 -05:00
Aikawa
7eeb70f711
fix(argo-workflows): Add namespace field to all namespace scoped resources (#1956)
Reason: `helm template` doesn't add the namespace field automatically

* fix(argo-workflows): Add namespace field to all namespace scoped resources because `helm template` doesn't add the namespace filed automatically
Signed-off-by: yu-croco <yu.croco@gmail.com>

* chore(argo-workflows): bump minor version
Signed-off-by: yu-croco <yu.croco@gmail.com>

* refactor(argo-workflows): reflect review points
Signed-off-by: yu-croco <yu.croco@gmail.com>
2023-04-13 11:25:06 +02:00
Justin Sievenpiper
56136f6518
feat(argo-workflows): add the ability to declare initContainers (#1923)
feat(argo-workflows): add the ability to declare initContainers to server and controller deployments

Signed-off-by: Justin Sievenpiper <justin@sievenpiper.co>
2023-04-07 08:43:01 +09:00
Emil Smoleński
2d193be5c0
feat(argo-workflows): Add ability to use memoization (#1924) 2023-03-23 02:09:03 -05:00
Jonathan Muller
f66c40319a
chore(argo-workflows): expose option to control the log format/level (#1855)
* Allow to change the log format to json

Signed-off-by: Jonathan Muller <koren@pukogames.com>

* Documentation, version

Signed-off-by: Jonathan Muller <koren@pukogames.com>

---------

Signed-off-by: Jonathan Muller <koren@pukogames.com>
2023-02-24 15:56:41 -06:00
Vlad Losev
c08fc230d7
fix(argo-workflows): clean subresource permissions (#1835) 2023-02-09 23:31:49 -06:00
Jason Meridth
7992b5d04b
feat(argo-workflows): Add helper function to determine image value, minus tag (#1754)
We have a situation where we want to exclude the registry so that images can
be pulled from in-network mirrors. Currently when you exclude the registry,
you get stuck with a prefixing forward slash.

Had to keep the tags in the manifest files because helm template requires
a colon in the image value.  Otherwise I'd move it into the helper function.

image entries changed: server, controller, executor

Signed-off-by: jmeridth <jmeridth@gmail.com>

Signed-off-by: jmeridth <jmeridth@gmail.com>
2023-01-09 18:03:26 -06:00
Aikawa
4b8703db75
chore(argo-workflows): Support podGCDeleteDelayDuration and podGCGracePeriodSeconds (#1728)
Signed-off-by: yu-croco <yu.croco@gmail.com>
2023-01-03 10:46:01 +09:00
huiwq1990
5bd70fbd24
feat(argo-workflows): add envFrom for main container (#1736)
Signed-off-by: huiwq1990 <huiwq1990@163.com>

Signed-off-by: huiwq1990 <huiwq1990@163.com>
2022-12-29 23:20:47 -06:00
Aikawa
10e3af1bcf
chore(argo-workflows): Remove legacy API versions for PDBs (#1741)
Signed-off-by: yu-croco <yu.croco@gmail.com>

Co-authored-by: Petr Drastil <petr.drastil@gmail.com>
2022-12-29 17:31:39 +01:00
Aikawa
56f3b77fd1
chore(argo-workflows): Support missing configurations to workflow controller cm (#1716)
Signed-off-by: yu-croco <yu.croco@gmail.com>
2022-12-19 18:07:44 +09:00
Aikawa
3c8ad7be89
feat(argo-workflows): Support images property to workflow-controller-configmap for emissary executor (#1708)
* feat(argo-workflows): Support images property to workflow-controller-configmap for emissary executor
Signed-off-by: yu-croco <yu.croco@gmail.com>

* chore(argo-workflows): adopt concise name
Signed-off-by: yu-croco <yu.croco@gmail.com>
2022-12-19 08:41:56 +09:00
Pedro
5b15810e2d
fix(argo-workflows): avoid label exceeding maximum length (#1692)
fix(argo-workflows): generated value for app.kubernetes.io/version label for argo-workflows will not exceed maximum length and support image tags with a SHA digest.

Signed-off-by: Pedro Salgado <steenzout@users.noreply.github.com>

Signed-off-by: Pedro Salgado <steenzout@users.noreply.github.com>
2022-12-09 15:50:05 +09:00
Daniel Iziourov
216a52d341
fix(argo-workflows): missing artifact GC rbac (#1680)
According to the documentation:
https://argoproj.github.io/argo-workflows/walk-through/artifacts/#artifact-garbage-collection

Signed-off-by: danmx <daniel@iziourov.info>

Signed-off-by: danmx <daniel@iziourov.info>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
2022-12-02 22:49:50 +09:00
Daniel Iziourov
48e16abc42
chore(argo-workflows): removed deprecated Role rbac (#1681)
Signed-off-by: danmx <daniel@iziourov.info>

Signed-off-by: danmx <daniel@iziourov.info>
2022-12-02 19:29:25 +09:00
Aikawa
77d8a11dd8
chore(argo-workflows): Support workflow retention (#1668)
Signed-off-by: yu-croco <yu.croco@gmail.com>
2022-11-26 10:08:11 +09:00
Eugene Lugovtsov
062417e30d
feat(argo-workflows): Add labels for ServiceAccounts (#1665)
* Add labels for ServiceAccounts

Signed-off-by: Eugene Lugovtsov <lug.zhenia@gmail.com>

* fix workflow serviceaccount labels

Signed-off-by: Eugene Lugovtsov <lug.zhenia@gmail.com>

* fix docs

Signed-off-by: Eugene Lugovtsov <lug.zhenia@gmail.com>

Signed-off-by: Eugene Lugovtsov <lug.zhenia@gmail.com>
2022-11-25 09:35:40 +09:00
emmayylu
16cf7af98b
feat(argo-workflows): Allow controller to whitelist secrets (#1646)
* allow users to whitelist secrets

Signed-off-by: emmayylu <84873428+yolu-kxs@users.noreply.github.com>

* remove unnecessary if-statement

Signed-off-by: emmayylu <44856279+emmayylu@users.noreply.github.com>

* use square bracket for array

Signed-off-by: emmayylu <44856279+emmayylu@users.noreply.github.com>

* fix typo and update readme

Signed-off-by: emmayylu <44856279+emmayylu@users.noreply.github.com>

Signed-off-by: emmayylu <84873428+yolu-kxs@users.noreply.github.com>
Signed-off-by: emmayylu <44856279+emmayylu@users.noreply.github.com>
Co-authored-by: emmayylu <84873428+yolu-kxs@users.noreply.github.com>
2022-11-23 16:17:56 +09:00
Aikawa
050027ad65
fix(argo-workflows): Added missing attribute for sso (#1641)
Signed-off-by: yu-croco <yu.croco@gmail.com>
2022-11-14 20:20:11 +09:00
Max Kochubey
826ae0f177
Allow to add custom artifact repository (#1453)
Signed-off-by: Max Kochubey <20810306+maxkochubey@users.noreply.github.com>

Signed-off-by: Max Kochubey <20810306+maxkochubey@users.noreply.github.com>
2022-11-10 09:36:13 +09:00
Nick Fisher
55b8b34d20
fix(argo-workflows): serviceaccount rbac when sso is enabled (#1586)
Signed-off-by: Nick Fisher <nxf5025@gmail.com>

Signed-off-by: Nick Fisher <nxf5025@gmail.com>
2022-10-27 10:04:37 +09:00
Aikawa
3a431395d0
chore(argo-workflows): Enable to set different imagePullPolicy for mainContainer and executor (#1570)
Signed-off-by: yu-croco <yu.croco@gmail.com>
2022-10-25 15:18:59 +09:00
Kiyoshi Muranaka
2626b31b69
feat(argo-workflows): Add support for topologySpreadConstraints (#1496)
Signed-off-by: Kiyoshi Muranaka <hxhgkkrgi@gmail.com>

Signed-off-by: Kiyoshi Muranaka <hxhgkkrgi@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
2022-10-22 16:37:31 +09:00
Keigo Hattori
107695e738
feat(argo-workflows): Add extra manifests to deploy within the chart (#1495)
Signed-off-by: Keigo Hattori <keigoht@gmail.com>
2022-09-28 15:50:45 +02:00
Aikawa
57d64df546
fix(argo-workflows): Helm syntax on SSO configuration (#1493)
Signed-off-by: yu-croco <yu.croco@gmail.com>
2022-09-27 21:43:48 +09:00
Aikawa
99aadc56c4
fix(argo-workflows): sso configuration (#1492)
Signed-off-by: yu-croco <yu.croco@gmail.com>
2022-09-27 18:53:04 +09:00
Aikawa
ab2ab593b3
feat(argo-workflows): Support Azure Blob Storage for artifact (#1488)
* feat(argo-workflows): Support Azure Blob Storage for artifact
Signed-off-by: yu-croco <yu.croco@gmail.com>

* chore(argo-workflows): refactor, from if/else to with
Signed-off-by: yu-croco <yu.croco@gmail.com>
2022-09-26 13:11:00 +09:00
Aikawa
fd0f2c92e1
fix(argo-workflows): Set only used values on SSO configuration (#1483)
Signed-off-by: yu-croco <yu.croco@gmail.com>
2022-09-24 09:03:36 +09:00
JM
6099bbb256
fix(argo-workflows): move crds folder into templates folder (#1472)
Fixes #1430 #1468

Due to multiple instances where new/changed CRDs for argo-workflows do not
get installed/updated I believe it is time to move the crds folder into
the templates folder like our other helm charts.

I'm aware helm 3 is supposed to handle the crds folder but it seems there
are a few known issues currently [here](https://github.com/hashicorp/terraform-provider-helm/issues/944), [here](https://github.com/helm/helm/issues/11321) and [here](https://github.com/helm/helm/pull/11330) that show that may still
need some work.

Signed-off-by: jmeridth <jmeridth@gmail.com>

Signed-off-by: jmeridth <jmeridth@gmail.com>
2022-09-21 05:34:39 -05:00
Aikawa
87d6e396a7
chore(argo-workflows): upgrade version v3.4.0 (#1463)
* chore(argo-workflows): upgrade version v3.4.0
Signed-off-by: yu-croco <yu.croco@gmail.com>

* fix(argo-workflows): Remove unsupported attributes on metricsConfig and telemetryConfig, from workflow-controller-configmap
Signed-off-by: yu-croco <yu.croco@gmail.com>

* fix(argo-workflows): update CRDs
Signed-off-by: yu-croco <yu.croco@gmail.com>

* fix(argo-workflows): upgrade CRDs
Signed-off-by: yu-croco <yu.croco@gmail.com>
2022-09-20 01:10:20 +09:00
Aikawa
334d8ae728
feat(argo-workflows): Add global tag (#1377)
* feat(argo-workflows): Moved `.Values.images` values to global
Signed-off-by: yu-croco <yuki.kita22@gmail.com>

* Revert "feat(argo-workflows): Moved `.Values.images` values to global"
This reverts commit 67b4294675.
Signed-off-by: yu-croco <yuki.kita22@gmail.com>

* feat(argo-workflows): Add global tag
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
2022-07-27 09:50:42 +09:00
Tadayuki Onishi
e01c613046
feat(argo-workflows): Assign common labels to some resources (#1369)
* feat(argo-workflows): Assign common labels to controller resources

Signed-off-by: kenchan0130 <tt.tanishi100@gmail.com>

* feat(argo-workflows): Assign common labels to the server sa resource

Signed-off-by: kenchan0130 <tt.tanishi100@gmail.com>

* Update argo-workflows Chart.yaml

Signed-off-by: kenchan0130 <tt.tanishi100@gmail.com>
2022-07-13 09:10:34 +09:00