We have a situation where we want to exclude the registry so that images can
be pulled from in-network mirrors. Currently when you exclude the registry,
you get stuck with a prefixing forward slash.
Had to keep the tags in the manifest files because helm template requires
a colon in the image value. Otherwise I'd move it into the helper function.
image entries changed: server, controller, executor
Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: jmeridth <jmeridth@gmail.com>
fix(argo-workflows): generated value for app.kubernetes.io/version label for argo-workflows will not exceed maximum length and support image tags with a SHA digest.
Signed-off-by: Pedro Salgado <steenzout@users.noreply.github.com>
Signed-off-by: Pedro Salgado <steenzout@users.noreply.github.com>
* feat(argo-workflows): Moved `.Values.images` values to global
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
* Revert "feat(argo-workflows): Moved `.Values.images` values to global"
This reverts commit 67b4294675.
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
* feat(argo-workflows): Add global tag
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
* feat(argo-workflows): add support for Deployment annotations
bump version and add changelog
update documentation
Signed-off-by: snooyen <sean@bright.ai>
* Apply suggestions from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Added short tag function and updated templates
Signed-off-by: John Clark <clark.john.d@outlook.com>
* Chart.yaml update (version, changes)
Signed-off-by: John Clark <clark.john.d@outlook.com>
* Removed unnecessary conditional logic
Signed-off-by: John Clark <clark.john.d@outlook.com>
* Final newline to _helpers
Signed-off-by: John Clark <clark.john.d@outlook.com>
* Rework without template function
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat(argo-workflows): Add controller volumes
Signed-off-by: John Clark <clark.john.d@outlook.com>
* Chart.yaml mispelling (paramaters > parameters)
Signed-off-by: John Clark <clark.john.d@outlook.com>
* Apply suggestions from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Allow setting the metrics port name
Here, we scrape every pod that has a .*-metrics port here
But the helm chart is locked to `metrics` which our Prometheus doesn't see
This PR will make it configurable with a default value of `metrics`
Signed-off-by: Julien Duchesne <julien.duchesne@grafana.com>
* Bump version
Signed-off-by: Julien Duchesne <julien.duchesne@grafana.com>
* Bump minor version
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat: Add support for extra containers in server & controller deployment
Signed-off-by: Mike Bryant <mikebryant@bulb.co.uk>
* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>
* Update charts/argo-workflows/templates/server/server-deployment.yaml
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
