4 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Sanjay Tiwari
|
dbd8c20e1f
|
fix(argo-workflows): RBAC for namespaced workflows (#962)
* Fix to add sa role and rolebinding in case of seperate workflow namespace * Update Chart version to 0.7.2 Signed-off-by: Sanjay Tiwari <sanjay.180505@gmail.com> * Update Contribution file Signed-off-by: Sanjay Tiwari <sanjay.180505@gmail.com> * ADO SignOff Signed-off-by: Sanjay Tiwari <sanjay.180505@gmail.com> * ADO SignOff Signed-off-by: Sanjay Tiwari <sanjay.180505@gmail.com> * Update Chart with change log Signed-off-by: Sanjay Tiwari <sanjay.180505@gmail.com> * Restore Contribution.md Co-authored-by: Vlad Losev <vladlosev@users.noreply.github.com> |
||
|
Rein van 't Veer
|
fa7ba522e0
|
fix(argo-workflows): Fix typo reported in #876 (#881)
* fix typo. Fixes #876 Signed-off-by: reinvantveer <reinvantveer@gmail.com> * change notes and version bump Signed-off-by: reinvantveer <reinvantveer@gmail.com> * fix typos in role and service account Signed-off-by: reinvantveer <reinvantveer@gmail.com> * update change notes Signed-off-by: reinvantveer <reinvantveer@gmail.com> |
||
|
Rein van 't Veer
|
37277315ce
|
feat(argo-workflows): Multiple workflow namespaces (#824)
* allow workflow to be run in multiple namespaces, bump chart version
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* update helm install instructions
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* fix indents
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* add newlines
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* bump chart version
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* default to "argo" namespace for workflow service account
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* simplify setting service account, fix syntactical error in defaulting to "argo" namespace
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* Bump only the chart version, revert bumping the controller version: 3.0.8 does not exist yet as a workflow-controller image version
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* don't set a namespace if there isn't one provided
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* bump version
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* re-use controller.workflowNamespaces instead of introducing workflow.namespaces
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* re-use controller.workflowNamespaces instead of introducing workflow.namespaces
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* re-use controller.workflowNamespaces instead of introducing workflow.namespaces
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* re-use controller.workflowNamespaces instead of introducing workflow.namespaces, add additional inline comments on rbac.create effect
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* compress namespaces from controller.workflowNamespaces and workflow.namespace into single loop iteration
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* compress namespaces from controller.workflowNamespaces and workflow.namespace into single loop iteration
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* compress namespaces from controller.workflowNamespaces and workflow.namespace into single loop iteration
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* dro now-redundant branch for controller.workflowNamespaces
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* use template helper "argo-workflows.fullname" instead of release name in order to be able to override the service account name
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* add missing "template" keyword
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* drop redundant $namespace assignment that was already moved inside the "range" function
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* replace "define" templates with simple values now that controller.workflowNamespaces and workflow.namespace are unified into a single "range" iteration
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* drop redundant $namespace assignment that was already moved inside the "range" function
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* inline "define" templates with simple values now that controller.workflowNamespaces and workflow.namespace are unified into a single "range" iteration
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* inline "define" templates with simple values now that controller.workflowNamespaces and workflow.namespace are unified into a single "range" iteration
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* add missing "$" to denote target for templating the workflows fullname helper
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* restore `with` blocks for service account name and service account annotations
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* drop validations: considering cases of `workflowNamespaces`, `namespace` and `singleNamespace`
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* include case for single namespaces with default ("") namespace, otherwise (ternary) combine the workflow namespace and workflowNamespaces from the controller settings into a list to iterate over
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* wrap namespace configuration in `with` block to prevent setting it to ""
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* fix append vs. concat bug: append workflowNamespace to (possibly 0-lenght) list of controller.workflowNamespaces
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* fix namespace range with additional check for either single namespace being false, or append to the workflow namespaces: the first non-null (coalesce) from the workflow namespace or the namespace Argo is being deployed to.
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* add changelog entries
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* unwrap (inline) with-block for service account name
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
Co-authored-by: Vlad Losev <vladlosev@users.noreply.github.com>
|
||
|
chgl
|
82b655dadc
|
feat(argo-workflows): added new argo-workflows chart and deprecated argo chart (#668)
* feat: added new argo-workflows chart and deprecated argo chart Signed-off-by: chgl <chgl@users.noreply.github.com> * fix: removed maintainers from deprecated argo chart Signed-off-by: chgl <chgl@users.noreply.github.com> * docs: rm pullPolicy from snippet since the global images.pullPolicy is actually used Signed-off-by: chgl <chgl@users.noreply.github.com> * use Chart.AppVersion as the default image tag Signed-off-by: chgl <chgl@users.noreply.github.com> * updated various links Signed-off-by: chgl <chgl@users.noreply.github.com> * enabled metrics endpoint and liveness probe by default Signed-off-by: chgl <chgl@users.noreply.github.com> * fix: use new-style labels Signed-off-by: chgl <chgl@users.noreply.github.com> * fix: set securitycontext for server to something more secure Signed-off-by: chgl <chgl@users.noreply.github.com> * Update charts/argo-workflows/templates/_helpers.tpl Signed-off-by: chgl <chgl@users.noreply.github.com> Co-authored-by: Brandon Mayfield <563214+bmayfi3ld@users.noreply.github.com> Signed-off-by: chgl <chgl@users.noreply.github.com> * bumped argo chart version Signed-off-by: chgl <chgl@users.noreply.github.com> * Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com> Signed-off-by: chgl <chgl@users.noreply.github.com> * Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com> Signed-off-by: chgl <chgl@users.noreply.github.com> * Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com> Signed-off-by: chgl <chgl@users.noreply.github.com> * Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com> Signed-off-by: chgl <chgl@users.noreply.github.com> * Update charts/argo-workflows/templates/controller/workflow-controller-service.yaml Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com> Signed-off-by: chgl <chgl@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Brandon Mayfield <563214+bmayfi3ld@users.noreply.github.com> Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com> Signed-off-by: chgl <chgl@users.noreply.github.com> * used ingress from argo-cd Signed-off-by: chgl <chgl@users.noreply.github.com> * Update charts/argo-workflows/templates/server/server-deployment.yaml Signed-off-by: chgl <chgl@users.noreply.github.com> Co-authored-by: Brandon Mayfield <mayfield.brandon.a@gmail.com> * updated argo-wf to v3.0.2 Signed-off-by: chgl <chgl@users.noreply.github.com> * aligned serviceAccount configuration with argo-cd values Signed-off-by: chgl <chgl@users.noreply.github.com> * docs: updated breaking changes in README Signed-off-by: chgl <chgl@users.noreply.github.com> * fix: use .Capabilities.APIVersions.Has in Ingress template Signed-off-by: chgl <chgl@users.noreply.github.com> Co-authored-by: Brandon Mayfield <563214+bmayfi3ld@users.noreply.github.com> Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com> Co-authored-by: Brandon Mayfield <mayfield.brandon.a@gmail.com> |