Commit graph

13 commits

Author SHA1 Message Date
Aikawa
1af4bf5f48
feat(argo-workflows): Add ability to set .Values.namespaceOverride (#2564) 2024-03-03 13:12:41 -06:00
Aikawa
2c046f9a9a
fix(argo-workflows): Add missing permission to workflow role (#2367) 2023-12-05 05:55:10 +00:00
Daniel Iziourov
216a52d341
fix(argo-workflows): missing artifact GC rbac (#1680)
According to the documentation:
https://argoproj.github.io/argo-workflows/walk-through/artifacts/#artifact-garbage-collection

Signed-off-by: danmx <daniel@iziourov.info>

Signed-off-by: danmx <daniel@iziourov.info>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
2022-12-02 22:49:50 +09:00
Daniel Iziourov
48e16abc42
chore(argo-workflows): removed deprecated Role rbac (#1681)
Signed-off-by: danmx <daniel@iziourov.info>

Signed-off-by: danmx <daniel@iziourov.info>
2022-12-02 19:29:25 +09:00
Tadayuki Onishi
e01c613046
feat(argo-workflows): Assign common labels to some resources (#1369)
* feat(argo-workflows): Assign common labels to controller resources

Signed-off-by: kenchan0130 <tt.tanishi100@gmail.com>

* feat(argo-workflows): Assign common labels to the server sa resource

Signed-off-by: kenchan0130 <tt.tanishi100@gmail.com>

* Update argo-workflows Chart.yaml

Signed-off-by: kenchan0130 <tt.tanishi100@gmail.com>
2022-07-13 09:10:34 +09:00
Aikawa
5f33394042
fix(argo-workflows): add missing rules for workflow role to run HTTP templates (#1291)
* fix(argo-workflows): add missing rules for workflow role to run HTTP/plugin templates

Signed-off-by: yu-croco <yuki.kita22@gmail.com>

* chore(argo-workflows): refactor role rules simpler

Signed-off-by: yu-croco <yuki.kita22@gmail.com>
2022-05-25 10:51:50 +02:00
Hironori Yamamoto
e9a8cd6420
Add missing create verb to pod/exec for the workflow role (#1231)
Signed-off-by: Hironori Yamamoto <mr.nikoru918@gmail.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2022-05-09 22:36:15 +02:00
sondre engen
0869e629f4
fix(argo-workflows): Add missing workflow permission (#1247)
* feat(argo-events): Adding additional RBAC for leader election (#1242)

* Issue 1565: Adding additional RBAC for leader election

Signed-off-by: David Collom <david.collom@jetstack.io>

* Adding Additional RBAC for Events

Signed-off-by: David Collom <david.collom@jetstack.io>

* Use consistent indent style

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

* Bump minor chart version and add changelog

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Sondre Engen <corastweb94@hotmail.com>

* Add missing permission to workflow sa

Signed-off-by: Sondre Engen <corastweb94@hotmail.com>

* chore(argo-cd): Document how to upgrade CRDs (#1251)

* chore(argo-cd): Document how to upgrade CRDs

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* feat(argo-cd): Update chart version and changelog

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
Signed-off-by: Sondre Engen <corastweb94@hotmail.com>

* Update chart version

Signed-off-by: Sondre Engen <corastweb94@hotmail.com>

* Added changelog

Signed-off-by: Sondre Engen <corastweb94@hotmail.com>

Co-authored-by: David Collom <david@collom.co.uk>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Petr Drastil <petr.drastil@gmail.com>
2022-05-01 13:44:32 +02:00
Vlad Losev
c1e7213cdc
fix(argo-workflows): Restore RBAC permission and clarify namespace settings. (#989)
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
2021-11-01 21:12:45 +03:00
Sanjay Tiwari
dbd8c20e1f
fix(argo-workflows): RBAC for namespaced workflows (#962)
* Fix to add sa role and rolebinding in case of seperate workflow namespace

* Update Chart version to 0.7.2

Signed-off-by: Sanjay Tiwari <sanjay.180505@gmail.com>

* Update Contribution file

Signed-off-by: Sanjay Tiwari <sanjay.180505@gmail.com>

* ADO SignOff

Signed-off-by: Sanjay Tiwari <sanjay.180505@gmail.com>

* ADO SignOff

Signed-off-by: Sanjay Tiwari <sanjay.180505@gmail.com>

* Update Chart with change log

Signed-off-by: Sanjay Tiwari <sanjay.180505@gmail.com>

* Restore Contribution.md

Co-authored-by: Vlad Losev <vladlosev@users.noreply.github.com>
2021-10-15 12:41:54 +03:00
Rein van 't Veer
fa7ba522e0
fix(argo-workflows): Fix typo reported in #876 (#881)
* fix typo. Fixes #876

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* change notes and version bump

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* fix typos in role and service account

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* update change notes

Signed-off-by: reinvantveer <reinvantveer@gmail.com>
2021-08-20 09:24:23 -07:00
Rein van 't Veer
37277315ce
feat(argo-workflows): Multiple workflow namespaces (#824)
* allow workflow to be run in multiple namespaces, bump chart version

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* update helm install instructions

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* fix indents

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* add newlines

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* bump chart version

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* default to "argo" namespace for workflow service account

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* simplify setting service account, fix syntactical error in defaulting to "argo" namespace

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* Bump only the chart version, revert bumping the controller version: 3.0.8 does not exist yet as a workflow-controller image version

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* don't set a namespace if there isn't one provided

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* bump version

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* re-use controller.workflowNamespaces instead of introducing workflow.namespaces

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* re-use controller.workflowNamespaces instead of introducing workflow.namespaces

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* re-use controller.workflowNamespaces instead of introducing workflow.namespaces

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* re-use controller.workflowNamespaces instead of introducing workflow.namespaces, add additional inline comments on rbac.create effect

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* compress namespaces from controller.workflowNamespaces and workflow.namespace into single loop iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* compress namespaces from controller.workflowNamespaces and workflow.namespace into single loop iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* compress namespaces from controller.workflowNamespaces and workflow.namespace into single loop iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* dro now-redundant branch for controller.workflowNamespaces

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* use template helper "argo-workflows.fullname" instead of release name in order to be able to override the service account name

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* add missing "template" keyword

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* drop redundant $namespace assignment that was already moved inside the "range" function

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* replace "define" templates with simple values now that controller.workflowNamespaces and workflow.namespace are unified into a single "range" iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* drop redundant $namespace assignment that was already moved inside the "range" function

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* inline "define" templates with simple values now that controller.workflowNamespaces and workflow.namespace are unified into a single "range" iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* inline "define" templates with simple values now that controller.workflowNamespaces and workflow.namespace are unified into a single "range" iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* add missing "$" to denote target for templating the workflows fullname helper

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* restore `with` blocks for service account name and service account annotations

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* drop validations: considering cases of `workflowNamespaces`, `namespace` and `singleNamespace`

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* include case for single namespaces with default ("") namespace, otherwise (ternary) combine the workflow namespace and workflowNamespaces from the controller settings into a list to iterate over

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* wrap namespace configuration in `with` block to prevent setting it to ""

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* fix append vs. concat bug: append workflowNamespace to (possibly 0-lenght) list of controller.workflowNamespaces

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* fix namespace range with additional check for either single namespace being false, or append to the workflow namespaces: the first non-null (coalesce) from the workflow namespace or the namespace Argo is being deployed to.

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* add changelog entries

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* unwrap (inline) with-block for service account name

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

Co-authored-by: Vlad Losev <vladlosev@users.noreply.github.com>
2021-07-20 11:18:26 -07:00
chgl
82b655dadc
feat(argo-workflows): added new argo-workflows chart and deprecated argo chart (#668)
* feat: added new argo-workflows chart and deprecated argo chart

Signed-off-by: chgl <chgl@users.noreply.github.com>

* fix: removed maintainers from deprecated argo chart

Signed-off-by: chgl <chgl@users.noreply.github.com>

* docs: rm pullPolicy from snippet since the global images.pullPolicy is actually used

Signed-off-by: chgl <chgl@users.noreply.github.com>

* use Chart.AppVersion as the default image tag

Signed-off-by: chgl <chgl@users.noreply.github.com>

* updated various links

Signed-off-by: chgl <chgl@users.noreply.github.com>

* enabled metrics endpoint and liveness probe by default

Signed-off-by: chgl <chgl@users.noreply.github.com>

* fix: use new-style labels

Signed-off-by: chgl <chgl@users.noreply.github.com>

* fix: set securitycontext for server to something more secure

Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/_helpers.tpl

Signed-off-by: chgl <chgl@users.noreply.github.com>

Co-authored-by: Brandon Mayfield <563214+bmayfi3ld@users.noreply.github.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* bumped argo chart version

Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-service.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Brandon Mayfield <563214+bmayfi3ld@users.noreply.github.com>
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* used ingress from argo-cd

Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/server/server-deployment.yaml

Signed-off-by: chgl <chgl@users.noreply.github.com>

Co-authored-by: Brandon Mayfield <mayfield.brandon.a@gmail.com>

* updated argo-wf to v3.0.2

Signed-off-by: chgl <chgl@users.noreply.github.com>

* aligned serviceAccount configuration with argo-cd values

Signed-off-by: chgl <chgl@users.noreply.github.com>

* docs: updated breaking changes in README

Signed-off-by: chgl <chgl@users.noreply.github.com>

* fix: use .Capabilities.APIVersions.Has in Ingress template

Signed-off-by: chgl <chgl@users.noreply.github.com>

Co-authored-by: Brandon Mayfield <563214+bmayfi3ld@users.noreply.github.com>
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Co-authored-by: Brandon Mayfield <mayfield.brandon.a@gmail.com>
2021-05-21 14:19:05 +02:00