Commit graph

18 commits

Author SHA1 Message Date
Ujin
a67424d0c4
feat(argo-workflows): Updated supported workers parameters (#2297)
* feat(argo-workflows): Updated supported workers parameters

Change
------
Based on argo-workflows [scaling documents](https://argoproj.github.io/argo-workflows/scaling/)
it's possible to set following workers values: `--workflow-workers`, `--workflow-ttl-workers`, `--pod-cleanup-workers`
and statring 3.5 `--cron-workflow-workers`. This change allows chart
consumers to take advatage of _all_ these parameters.

Testing
-------
```
helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep workers

helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers
          - "--workflow-workers"
          - "10"

helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers
          - "--workflow-workers"
          - "10"
          - "--workflow-ttl-workers"
          - "20"

helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers
          - "--workflow-workers"
          - "10"
          - "--workflow-ttl-workers"
          - "20"
          - "--pod-cleanup-workers"
          - "30"

helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers
          - "--workflow-workers"
          - "10"
          - "--workflow-ttl-workers"
          - "20"
          - "--pod-cleanup-workers"
          - "30"
          - "--cron-workflow-workers"
          - "40"
```

Signed-off-by: Evgeny Khatko <owen.tko@gmail.com>
Signed-off-by: Evgeny Khatko <ekhatko@paypal.com>

* Addressing PR feedback.

Signed-off-by: Evgeny Khatko <ekhatko@paypal.com>

* newline

Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com>

* Update Chart.yaml

Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com>

* Update Chart.yaml

Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com>

---------

Signed-off-by: Evgeny Khatko <owen.tko@gmail.com>
Signed-off-by: Evgeny Khatko <ekhatko@paypal.com>
Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com>
Co-authored-by: Evgeny Khatko <ekhatko@paypal.com>
Co-authored-by: Tim Collins <45351296+tico24@users.noreply.github.com>
2023-10-24 13:34:49 +01:00
PidgeyBE
f6d44750b8
fix(argo-workflows): Fix templating in several places (#2026)
* Add artifacthub changes

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>

* fix templating list of yamls

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>

* Bump version and fix templating for gcs and azure as well

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>

---------

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>
Co-authored-by: Aikawa <yu.croco@gmail.com>
2023-05-11 09:09:33 +09:00
Aikawa
7eeb70f711
fix(argo-workflows): Add namespace field to all namespace scoped resources (#1956)
Reason: `helm template` doesn't add the namespace field automatically

* fix(argo-workflows): Add namespace field to all namespace scoped resources because `helm template` doesn't add the namespace filed automatically
Signed-off-by: yu-croco <yu.croco@gmail.com>

* chore(argo-workflows): bump minor version
Signed-off-by: yu-croco <yu.croco@gmail.com>

* refactor(argo-workflows): reflect review points
Signed-off-by: yu-croco <yu.croco@gmail.com>
2023-04-13 11:25:06 +02:00
Justin Sievenpiper
56136f6518
feat(argo-workflows): add the ability to declare initContainers (#1923)
feat(argo-workflows): add the ability to declare initContainers to server and controller deployments

Signed-off-by: Justin Sievenpiper <justin@sievenpiper.co>
2023-04-07 08:43:01 +09:00
Jonathan Muller
f66c40319a
chore(argo-workflows): expose option to control the log format/level (#1855)
* Allow to change the log format to json

Signed-off-by: Jonathan Muller <koren@pukogames.com>

* Documentation, version

Signed-off-by: Jonathan Muller <koren@pukogames.com>

---------

Signed-off-by: Jonathan Muller <koren@pukogames.com>
2023-02-24 15:56:41 -06:00
Jason Meridth
7992b5d04b
feat(argo-workflows): Add helper function to determine image value, minus tag (#1754)
We have a situation where we want to exclude the registry so that images can
be pulled from in-network mirrors. Currently when you exclude the registry,
you get stuck with a prefixing forward slash.

Had to keep the tags in the manifest files because helm template requires
a colon in the image value.  Otherwise I'd move it into the helper function.

image entries changed: server, controller, executor

Signed-off-by: jmeridth <jmeridth@gmail.com>

Signed-off-by: jmeridth <jmeridth@gmail.com>
2023-01-09 18:03:26 -06:00
Pedro
5b15810e2d
fix(argo-workflows): avoid label exceeding maximum length (#1692)
fix(argo-workflows): generated value for app.kubernetes.io/version label for argo-workflows will not exceed maximum length and support image tags with a SHA digest.

Signed-off-by: Pedro Salgado <steenzout@users.noreply.github.com>

Signed-off-by: Pedro Salgado <steenzout@users.noreply.github.com>
2022-12-09 15:50:05 +09:00
Kiyoshi Muranaka
2626b31b69
feat(argo-workflows): Add support for topologySpreadConstraints (#1496)
Signed-off-by: Kiyoshi Muranaka <hxhgkkrgi@gmail.com>

Signed-off-by: Kiyoshi Muranaka <hxhgkkrgi@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
2022-10-22 16:37:31 +09:00
Aikawa
334d8ae728
feat(argo-workflows): Add global tag (#1377)
* feat(argo-workflows): Moved `.Values.images` values to global
Signed-off-by: yu-croco <yuki.kita22@gmail.com>

* Revert "feat(argo-workflows): Moved `.Values.images` values to global"
This reverts commit 67b4294675.
Signed-off-by: yu-croco <yuki.kita22@gmail.com>

* feat(argo-workflows): Add global tag
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
2022-07-27 09:50:42 +09:00
Aikawa
35f9ea8149
fix(argo-workflows): Remove unsupported value (#1302)
* fix(argo-workflows): Add comment about removed flag

Signed-off-by: yu-croco <yuki.kita22@gmail.com>

* fix(argo-workflows): Remove unsupported value
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
2022-06-01 19:56:20 +02:00
Sean Nguyen
0cf7cad2c2
feat(argo-workflows): add support for Deployment annotations (#1198)
* feat(argo-workflows): add support for Deployment annotations

  bump version and add changelog

  update documentation

Signed-off-by: snooyen <sean@bright.ai>

* Apply suggestions from code review

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2022-05-09 22:45:28 +02:00
John Clark
645f70ff98
fix(argo-workflows): Quick fix for failing deployment when using image digests (#1206)
* Added short tag function and updated templates

Signed-off-by: John Clark <clark.john.d@outlook.com>

* Chart.yaml update (version, changes)

Signed-off-by: John Clark <clark.john.d@outlook.com>

* Removed unnecessary conditional logic

Signed-off-by: John Clark <clark.john.d@outlook.com>

* Final newline to _helpers

Signed-off-by: John Clark <clark.john.d@outlook.com>

* Rework without template function

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2022-05-09 22:24:14 +02:00
John Clark
4464f2a526
feat(argo-workflows): Add volume and volumeMount parameters to controller (#1147)
* feat(argo-workflows): Add controller volumes

Signed-off-by: John Clark <clark.john.d@outlook.com>

* Chart.yaml mispelling (paramaters > parameters)

Signed-off-by: John Clark <clark.john.d@outlook.com>

* Apply suggestions from code review

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2022-03-01 10:52:55 +01:00
Julien Duchesne
c7584ab51d
feat(argo-workflows): Allow setting the metrics port name (#934)
* Allow setting the metrics port name
Here, we scrape every pod that has a .*-metrics port here
But the helm chart is locked to `metrics` which our Prometheus doesn't see

This PR will make it configurable with a default value of `metrics`

Signed-off-by: Julien Duchesne <julien.duchesne@grafana.com>

* Bump version

Signed-off-by: Julien Duchesne <julien.duchesne@grafana.com>

* Bump minor version

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2021-09-17 21:51:13 +02:00
Mike Bryant
07c1cf092c
feat(argo-workflows): Add support for extra containers in server & controller deployment (#841)
* feat: Add support for extra containers in server & controller deployment

Signed-off-by: Mike Bryant <mikebryant@bulb.co.uk>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>

* Update charts/argo-workflows/templates/server/server-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
2021-08-11 09:32:11 +02:00
Alex Sears
0180e943ff
chore(argo-workflows): update workflows version to most 3.0.7 (#811)
* chore(argo-workflows): update workflows version to most 3.0.7

Signed-off-by: Alex Sears <me@alexsears.com>

* chore(argo-worflows): update controller liveness probe

Signed-off-by: Alex Sears <me@alexsears.com>

* chore(argo-workflows): templatize controller liveness probe

Signed-off-by: Alex Sears <me@alexsears.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2021-06-25 08:15:43 +02:00
Marco Kilchhofer
f2e530ea7e
fix(argo-workflows): Fix indentation when using extraEnv (#773)
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2021-05-31 18:31:44 +02:00
chgl
82b655dadc
feat(argo-workflows): added new argo-workflows chart and deprecated argo chart (#668)
* feat: added new argo-workflows chart and deprecated argo chart

Signed-off-by: chgl <chgl@users.noreply.github.com>

* fix: removed maintainers from deprecated argo chart

Signed-off-by: chgl <chgl@users.noreply.github.com>

* docs: rm pullPolicy from snippet since the global images.pullPolicy is actually used

Signed-off-by: chgl <chgl@users.noreply.github.com>

* use Chart.AppVersion as the default image tag

Signed-off-by: chgl <chgl@users.noreply.github.com>

* updated various links

Signed-off-by: chgl <chgl@users.noreply.github.com>

* enabled metrics endpoint and liveness probe by default

Signed-off-by: chgl <chgl@users.noreply.github.com>

* fix: use new-style labels

Signed-off-by: chgl <chgl@users.noreply.github.com>

* fix: set securitycontext for server to something more secure

Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/_helpers.tpl

Signed-off-by: chgl <chgl@users.noreply.github.com>

Co-authored-by: Brandon Mayfield <563214+bmayfi3ld@users.noreply.github.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* bumped argo chart version

Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-service.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Brandon Mayfield <563214+bmayfi3ld@users.noreply.github.com>
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* used ingress from argo-cd

Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/server/server-deployment.yaml

Signed-off-by: chgl <chgl@users.noreply.github.com>

Co-authored-by: Brandon Mayfield <mayfield.brandon.a@gmail.com>

* updated argo-wf to v3.0.2

Signed-off-by: chgl <chgl@users.noreply.github.com>

* aligned serviceAccount configuration with argo-cd values

Signed-off-by: chgl <chgl@users.noreply.github.com>

* docs: updated breaking changes in README

Signed-off-by: chgl <chgl@users.noreply.github.com>

* fix: use .Capabilities.APIVersions.Has in Ingress template

Signed-off-by: chgl <chgl@users.noreply.github.com>

Co-authored-by: Brandon Mayfield <563214+bmayfi3ld@users.noreply.github.com>
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Co-authored-by: Brandon Mayfield <mayfield.brandon.a@gmail.com>
2021-05-21 14:19:05 +02:00