Most users of ArgoCD may use `Ingress` (and soon `HTTPRoute`), but for those who may want to use `Service` of type `LoadBalancer`, this would be useful.
The `loadBalancerClass` field would allow for a `CloudProvider` agnostic way of offloading the reconciliation for Kubernetes Service resources of type `LoadBalancer` to an external controller.
Signed-off-by: Gazal Gafoor <gazal.gafoor@rea-group.com>
Signed-off-by: Gazal <gazal.gafoor@rea-group.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
* docs(github): comment out notational pieces of PR template (#1969)
github: comment out notational pieces of PR template
- the DCO and publishing sentences are not filled out during PRs
and are purely notational
- comment them out with HTML comments, as is common practice
- example from a repo I maintain: f6db59613a/.github/issue_template.md (L2)
- I copied that from other repos too
- these comments are still visible to the PR author, just not visible
when rendered, keeping the PR more concise
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Tal Yitzhak <talyi@jfrog.com>
* Added missing permissions for argo rollouts dashboard cluster role - for config map, should be able to get
Signed-off-by: Tal Yitzhak <talyi@jfrog.com>
* Added missing permissions for argo rollouts dashboard cluster role - for config map, should be able to get
Signed-off-by: Tal Yitzhak <talyi@jfrog.com>
---------
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Tal Yitzhak <talyi@jfrog.com>
Signed-off-by: Tal Yitzhak <yitzhtal@gmail.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Tal Yitzhak <talyi@jfrog.com>
* feat(argo-rollouts): deployment annotations for controller, dashboard
Signed-off-by: Michael Weber <michael.weber@jumpcloud.com>
* chore: Apply changes from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
---------
Signed-off-by: Michael Weber <michael.weber@jumpcloud.com>
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat(argo-rollouts): Add flag to optionally disable the creation of cluster roles (even when running in cluster mode)
Signed-off-by: Joshua Helton <jdoghelton@gmail.com>
* fix README.md with helm-docs.sh
Signed-off-by: Joshua Helton <jdoghelton@gmail.com>
Signed-off-by: Joshua Helton <jdoghelton@gmail.com>
Co-authored-by: JM <jmeridth@gmail.com>
* feat(argo-rollouts) Add controller.extraEnv
Ability to specify environment variables for rollouts-controller from values.yaml
Signed-off-by: Ben Hayden <hayden767@gmail.com>
* Also implement extraEnv for dashboard component
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Reword changelog line
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat(argo-rollouts): add dashboard permission on Deployments
- needed for Rollouts with workload referencing
Signed-off-by: Ben Poland <ben.poland@faire.com>
* Add podtemplates to match controller role
Signed-off-by: Ben Poland <ben.poland@faire.com>
* feat(argo-rollouts): Add ability to define dashboard service node port
Signed-off-by: Jean Mainguy <9969006+jhandguy@users.noreply.github.com>
* Apply changes from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat(argo-rollouts): +LB service.type for dashboard svc
Signed-off-by: Maciej Lasyk <maciej@lasyk.info>
* Apply changes from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat: Allow setting the type for the dashboard service. (We have a requirement
to run it as NodePort). Default to what it is if not set.
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Bump Chart version.
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Add serviceType into values.yaml
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Address review comments:
Remove old changes annotation.
Rename serviceType to service.type.
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Bump Chart version.
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Fix typo
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* FIx indentation (lint error)
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Update README
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Update charts/argo-rollouts/README.md
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Apply suggestions from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* fix changelog
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* docs: Add warning about exposing the Dashboard via Service type
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat(argo-rollouts): Support extraArgs for controller and dashboard
Adding support for additional arguments that are passed to the controller and the dashboard.
Following the pattern of other Argo charts by re-using the name `extraArgs` for the value.
Refs: https://github.com/argoproj/argo-helm/issues/969
Signed-off-by: Sebastian J <zeeman@zeeman.de>
* Update charts/argo-rollouts/templates/controller/deployment.yaml
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Sebastian J <zeeman@zeeman.de>
* Update charts/argo-rollouts/templates/dashboard/deployment.yaml
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Sebastian J <zeeman@zeeman.de>
* PR comments
Signed-off-by: Sebastian J <zeeman@zeeman.de>
* Fix newly added parameters in README
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Fix changelog keyword
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat(argo-rollouts): add dashboard deployment and service
credit: the implemention is inspired by the work from
Andrii Perenesenko <andrii.perenesenko@gmail.com>.
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
* Apply suggestions from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Add components to selectlabels
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
* Bump major version and add upgrading note
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
* fix: Documentation on dashboard values, change annotations
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
* feat: Enable dashboard during chart testing
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Hui Kang <hui.kang@salesforce.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
