Forgejo Helm chart
Find a file
Michael Kriese 076193b909 fix(deps): update forgejo docker tag to v1.18.2-1 (#48)
Co-authored-by: Michael Kriese <michael.kriese@gmx.de>
Reviewed-on: https://codeberg.org/forgejo-contrib/forgejo-helm/pulls/48
2023-01-30 07:52:04 +00:00
.gitea Improve contribution part of this repository (#328) 2022-06-13 03:35:24 +08:00
.woodpecker chore(deps): update ghcr.io/visualon/renovate docker tag to v34.116.1 2023-01-29 00:06:16 +00:00
templates feat!: upstream changes (#47) 2023-01-19 13:45:32 +00:00
tools build: add more changelog types 2023-01-04 16:00:59 +01:00
unittests feat!: upstream changes (#47) 2023-01-19 13:45:32 +00:00
.drone.yml feat!: upstream changes (#47) 2023-01-19 13:45:32 +00:00
.gitignore feat!: upstream changes (#47) 2023-01-19 13:45:32 +00:00
.helmignore feat!: upstream changes (#47) 2023-01-19 13:45:32 +00:00
.markdownlint.yaml Increase line length linter to 200 (#355) 2022-09-25 23:21:52 +08:00
.markdownlintignore feat!: upstream changes (#47) 2023-01-19 13:45:32 +00:00
.npmrc Improve contribution part of this repository (#328) 2022-06-13 03:35:24 +08:00
artifacthub-repo.yml chore: add artifact hub config 2023-01-03 20:33:02 +01:00
artifacthub.config.json chore: add artifact hub config 2023-01-03 20:33:02 +01:00
Chart.lock fix(deps): update helm release postgresql to v12.1.11 2023-01-28 00:15:02 +00:00
Chart.yaml fix(deps): update forgejo docker tag to v1.18.2-1 (#48) 2023-01-30 07:52:04 +00:00
CONTRIBUTING.md feat!: upstream changes (#47) 2023-01-19 13:45:32 +00:00
LICENSE Integrate NOVUM-RGI chart into the official helm chart. (#7) 2020-08-23 17:56:55 +00:00
Makefile feat!: upstream changes (#47) 2023-01-19 13:45:32 +00:00
package-lock.json chore(deps): update dependency markdownlint-cli to ^0.33.0 (#22) 2023-01-15 13:09:09 +00:00
package.json chore(deps): update dependency markdownlint-cli to ^0.33.0 (#22) 2023-01-15 13:09:09 +00:00
README.md feat!: upstream changes (#47) 2023-01-19 13:45:32 +00:00
renovate.json chore(renovate): disable unused managers 2023-01-19 13:02:36 +01:00
values.yaml feat!: upstream changes (#47) 2023-01-19 13:45:32 +00:00

Forgejo Helm Chart

Forgejo is a community managed lightweight code hosting solution written in Go. It is published under the MIT license.

Introduction

This helm chart is based on official Gitea helm chart. Additionally, this chart provides LDAP and admin user configuration with values, as well as being deployed as a statefulset to retain stored repositories.

Dependencies

Forgejo can be run with an external database and cache. This chart provides those dependencies, which can be enabled, or disabled via configuration.

Dependencies:

Installing

helm install oci://codeberg.org/forgejo-contrib/forgejo

When upgrading, please refer to the Upgrading section at the bottom of this document for major and breaking changes.

Prerequisites

  • Kubernetes 1.12+
  • Helm 3.0+
  • PV provisioner for persistent data support

Examples

Forgejo Configuration

Forgejo offers lots of configuration options. This is fully described in the Gitea Cheat Sheet.

gitea:
  config:
    APP_NAME: 'Forgejo: With a cup of tea.'
    repository:
      ROOT: '~/gitea-repositories'
    repository.pull-request:
      WORK_IN_PROGRESS_PREFIXES: 'WIP:,[WIP]:'

Default Configuration

This chart will set a few defaults in the Forgejo configuration based on the service and ingress settings. All defaults can be overwritten in gitea.config.

INSTALL_LOCK is always set to true, since we want to configure Forgejo with this helm chart and everything is taken care of.

All default settings are made directly in the generated app.ini, not in the Values.

Database defaults

If a builtIn database is enabled the database configuration is set automatically. For example, PostgreSQL builtIn will appear in the app.ini as:

[database]
DB_TYPE = postgres
HOST = RELEASE-NAME-postgresql.default.svc.cluster.local:5432
NAME = gitea
PASSWD = gitea
USER = gitea

Memcached defaults

Memcached is handled the exact same way as database builtIn. Once Memcached builtIn is enabled, this chart will generate the following part in the app.ini:

[cache]
ADAPTER = memcache
ENABLED = true
HOST = RELEASE-NAME-memcached.default.svc.cluster.local:11211

Server defaults

The server defaults are a bit more complex. If ingress is enabled, the ROOT_URL, DOMAIN and SSH_DOMAIN will be set accordingly. HTTP_PORT always defaults to 3000 as well as SSH_PORT to 22.

[server]
APP_DATA_PATH = /data
DOMAIN = git.example.com
HTTP_PORT = 3000
PROTOCOL = http
ROOT_URL = http://git.example.com
SSH_DOMAIN = git.example.com
SSH_LISTEN_PORT = 22
SSH_PORT = 22
ENABLE_PPROF = false

Metrics defaults

The Prometheus /metrics endpoint is disabled by default.

[metrics]
ENABLED = false

Additional app.ini settings

The generic section cannot be defined that way.

Some settings inside app.ini (like passwords or whole authentication configurations) must be considered sensitive and therefore should not be passed via plain text inside the values.yaml file. In times of GitOps the values.yaml could be stored in a Git repository where sensitive data should never be accessible.

The Helm Chart supports this approach and let the user define custom sources like Kubernetes Secrets to be loaded as environment variables during app.ini creation or update.

gitea:
  additionalConfigSources:
    - secret:
        secretName: gitea-app-ini-oauth
    - configMap:
        name: gitea-app-ini-plaintext

This would mount the two additional volumes (oauth and some-additionals) from different sources to the init containerwhere the app.ini gets updated. All files mounted that way will be read and converted to environment variables and then added to the app.ini using environment-to-ini.

The key of such additional source represents the section inside the app.ini. The value for each key can be multiline ini-like definitions.

In example, the referenced gitea-app-ini-plaintext could look like this.

apiVersion: v1
kind: ConfigMap
metadata:
  name: gitea-app-ini-plaintext
data:
  session: |
    PROVIDER=memory
    SAME_SITE=strict    
  cron.archive_cleanup: |
    ENABLED=true    

Or when using a Kubernetes secret, having the same data structure:

apiVersion: v1
kind: Secret
metadata:
  name: gitea-security-related-configuration
type: Opaque
stringData:
  security: |
    PASSWORD_COMPLEXITY=off    
  session: |
    SAME_SITE=strict    

User defined environment variables in app.ini

Users are able to define their own environment variables, which are loaded into the containers. We also support to directly interact with the generated app.ini.

To inject self defined variables into the app.ini a certain format needs to be honored. This is described in detail on the env-to-ini page.

Note that the Prefix on this helm chart is ENV_TO_INI.

For example a database setting needs to have the following format:

gitea:
  additionalConfigFromEnvs:
    - name: ENV_TO_INI__DATABASE__HOST
      value: my.own.host
    - name: ENV_TO_INI__DATABASE__PASSWD
      valueFrom:
        secretKeyRef:
          name: postgres-secret
          key: password

Priority (highest to lowest) for defining app.ini variables:

  1. Environment variables prefixed with ENV_TO_INI
  2. Additional config sources
  3. Values defined in gitea.config

External Database

An external Database can be used instead of builtIn PostgreSQL or MySQL.

gitea:
  config:
    database:
      DB_TYPE: mysql
      HOST: 127.0.0.1:3306
      NAME: gitea
      USER: root
      PASSWD: gitea
      SCHEMA: gitea

postgresql:
  enabled: false

Ports and external url

By default port 3000 is used for web traffic and 22 for ssh. Those can be changed:

service:
  http:
    port: 3000
  ssh:
    port: 22

This helm chart automatically configures the clone urls to use the correct ports. You can change these ports by hand using the gitea.config dict. However you should know what you're doing.

ClusterIP

By default the clusterIP will be set to None, which is the default for headless services. However if you want to omit the clusterIP field in the service, use the following values:

service:
  http:
    type: ClusterIP
    port: 3000
    clusterIP:
  ssh:
    type: ClusterIP
    port: 22
    clusterIP:

SSH and Ingress

If you're using ingress and want to use SSH, keep in mind, that ingress is not able to forward SSH Ports. You will need a LoadBalancer like metallb and a setting in your ssh service annotations.

service:
  ssh:
    annotations:
      metallb.universe.tf/allow-shared-ip: test

SSH on crio based kubernetes cluster

If you use crio as container runtime it is not possible to read from a remote repository. You should get an error message like this:

$ git clone git@k8s-demo.internal:admin/test.git
Cloning into 'test'...
Connection reset by 192.168.179.217 port 22
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

To solve this problem add the capability SYS_CHROOT to the securityContext. More about this issue here.

Cache

This helm chart can use a built in cache. The default is Memcached from bitnami.

memcached:
  enabled: true

If the built in cache should not be used simply configure the cache in gitea.config.

gitea:
  config:
    cache:
      ENABLED: true
      ADAPTER: memory
      INTERVAL: 60
      HOST: 127.0.0.1:9090

Persistence

Forgejo will be deployed as a statefulset. By simply enabling the persistence and setting the storage class according to your cluster everything else will be taken care of. The following example will create a PVC as a part of the statefulset. This PVC will not be deleted even if you uninstall the chart.

Please note, that an empty storageClass in the persistence will result in kubernetes using your default storage class.

If you want to use your own storageClass define it as followed:

persistence:
  enabled: true
  storageClass: myOwnStorageClass

When using PostgreSQL as dependency, this will also be deployed as a statefulset by default.

If you want to manage your own PVC you can simply pass the PVC name to the chart.

persistence:
  enabled: true
  existingClaim: MyAwesomeGiteaClaim

In case that peristence has been disabled it will simply use an empty dir volume.

PostgreSQL handles the persistence in the exact same way. You can interact with the postgres settings as displayed in the following example:

postgresql:
  primary:
    persistence:
      enabled: true
      existingClaim: MyAwesomeGiteaPostgresClaim

MySQL also handles persistence the same, even though it is not deployed as a statefulset. You can interact with the postgres settings as displayed in the following example:

mysql:
  primary:
    persistence:
      enabled: true
      existingClaim: MyAwesomeGiteaMysqlClaim

Admin User

This chart enables you to create a default admin user. It is also possible to update the password for this user by upgrading or redeloying the chart. It is not possible to delete an admin user after it has been created. This has to be done in the ui. You cannot use admin as username.

gitea:
  admin:
    username: 'MyAwesomeForgejoAdmin'
    password: 'AReallyAwesomeForgejoPassword'
    email: 'forge@jo.com'

You can also use an existing Secret to configure the admin user:

apiVersion: v1
kind: Secret
metadata:
  name: gitea-admin-secret
type: Opaque
stringData:
  username: MyAwesomeGiteaAdmin
  password: AReallyAwesomeGiteaPassword
gitea:
  admin:
    existingSecret: gitea-admin-secret

LDAP Settings

Like the admin user the LDAP settings can be updated. All LDAP values from https://docs.gitea.io/en-us/command-line/#admin are available.

Multiple LDAP sources can be configured with additional LDAP list items.

gitea:
  ldap:
    - name: MyAwesomeGiteaLdap
      securityProtocol: unencrypted
      host: '127.0.0.1'
      port: '389'
      userSearchBase: ou=Users,dc=example,dc=com
      userFilter: sAMAccountName=%s
      adminFilter: CN=Admin,CN=Group,DC=example,DC=com
      emailAttribute: mail
      bindDn: CN=ldap read,OU=Spezial,DC=example,DC=com
      bindPassword: JustAnotherBindPw
      usernameAttribute: CN
      publicSSHKeyAttribute: publicSSHKey

You can also use an existing secret to set the bindDn and bindPassword:

apiVersion: v1
kind: Secret
metadata:
  name: gitea-ldap-secret
type: Opaque
stringData:
  bindDn: CN=ldap read,OU=Spezial,DC=example,DC=com
  bindPassword: JustAnotherBindPw
gitea:
  ldap:
    - existingSecret: gitea-ldap-secret

⚠️ Some options are just flags and therefore don't have any values. If they are defined in gitea.ldap configuration, they will be passed to the Gitea CLI without any value. Affected options:

  • notActive
  • skipTlsVerify
  • allowDeactivateAll
  • synchronizeUsers
  • attributesInBind

OAuth2 Settings

Like the admin user, OAuth2 settings can be updated and disabled but not deleted. Deleting OAuth2 settings has to be done in the ui. All OAuth2 values, which are documented here, are available.

Multiple OAuth2 sources can be configured with additional OAuth list items.

gitea:
  oauth:
    - name: 'MyAwesomeGiteaOAuth'
      provider: 'openidConnect'
      key: 'hello'
      secret: 'world'
      autoDiscoverUrl: 'https://gitea.example.com/.well-known/openid-configuration'
      #useCustomUrls:
      #customAuthUrl:
      #customTokenUrl:
      #customProfileUrl:
      #customEmailUrl:

You can also use an existing secret to set the key and secret:

apiVersion: v1
kind: Secret
metadata:
  name: gitea-oauth-secret
type: Opaque
stringData:
  key: hello
  secret: world
gitea:
  oauth:
    - name: 'MyAwesomeGiteaOAuth'
      existingSecret: gitea-oauth-secret

Configure commit signing

When using the rootless image the gpg key folder is not persistent by default. If you consider using signed commits for internal Gitea activities (e.g. initial commit), you'd need to provide a signing key. Prior to PR186, imported keys had to be re-imported once the container got replaced by another.

The mentioned PR introduced a new configuration object signing allowing you to configure prerequisites for commit signing. By default this section is disabled to maintain backwards compatibility.

signing:
  enabled: false
  gpgHome: /data/git/.gnupg

Regardless of the used container image the signing object allows to specify a private gpg key. Either using the signing.privateKey to define the key inline, or refer to an existing secret containing the key data by using signing.existingKey.

apiVersion: v1
kind: Secret
metadata:
  name: custom-gitea-gpg-key
type: Opaque
stringData:
  privateKey: |-
    -----BEGIN PGP PRIVATE KEY BLOCK-----
    ...
    -----END PGP PRIVATE KEY BLOCK-----    
signing:
  existingSecret: custom-gitea-gpg-key

To use the gpg key, Gitea needs to be configured accordingly. A detailed description can be found in the official Gitea documentation.

Metrics and profiling

A Prometheus /metrics endpoint on the HTTP_PORT and pprof profiling endpoints on port 6060 can be enabled under gitea. Beware that the metrics endpoint is exposed via the ingress, manage access using ingress annotations for example.

To deploy the ServiceMonitor, you first need to ensure that you have deployed prometheus-operator and its CRDs.

gitea:
  metrics:
    enabled: true
    serviceMonitor:
      enabled: true

  config:
    server:
      ENABLE_PPROF: true

Pod Annotations

Annotations can be added to the Forgejo pod.

gitea:
  podAnnotations: {}

Parameters

Global

Name Description Value
global.imageRegistry global image registry override ""
global.imagePullSecrets global image pull secrets override; can be extended by imagePullSecrets []
global.storageClass global storage class override ""
replicaCount number of replicas for the statefulset 1
clusterDomain cluster domain cluster.local

Image

Name Description Value
image.registry image registry, e.g. gcr.io,docker.io codeberg.org
image.repository Image to start for this pod forgejo/forgejo
image.tag Visit: Image tag. Defaults to appVersion within Chart.yaml. ""
image.pullPolicy Image pull policy Always
image.rootless Wether or not to pull the rootless version of Forgejo, only works on Forgejo 1.14.x or higher false
imagePullSecrets Secret to use for pulling the image []

Security

Name Description Value
podSecurityContext.fsGroup Set the shared file system group for all containers in the pod. 1000
containerSecurityContext Security context {}
securityContext Run init and Forgejo containers as a specific securityContext {}

Service

Name Description Value
service.http.type Kubernetes service type for web traffic ClusterIP
service.http.port Port number for web traffic 3000
service.http.clusterIP ClusterIP setting for http autosetup for statefulset is None None
service.http.loadBalancerIP LoadBalancer IP setting nil
service.http.nodePort NodePort for http service nil
service.http.externalTrafficPolicy If service.http.type is NodePort or LoadBalancer, set this to Local to enable source IP preservation nil
service.http.externalIPs External IPs for service nil
service.http.ipFamilyPolicy HTTP service dual-stack policy nil
service.http.ipFamilies HTTP service dual-stack familiy selection,for dual-stack parameters see official kubernetes dual-stack concept documentation. nil
service.http.loadBalancerSourceRanges Source range filter for http loadbalancer []
service.http.annotations HTTP service annotations {}
service.ssh.type Kubernetes service type for ssh traffic ClusterIP
service.ssh.port Port number for ssh traffic 22
service.ssh.clusterIP ClusterIP setting for ssh autosetup for statefulset is None None
service.ssh.loadBalancerIP LoadBalancer IP setting nil
service.ssh.nodePort NodePort for ssh service nil
service.ssh.externalTrafficPolicy If service.ssh.type is NodePort or LoadBalancer, set this to Local to enable source IP preservation nil
service.ssh.externalIPs External IPs for service nil
service.ssh.ipFamilyPolicy SSH service dual-stack policy nil
service.ssh.ipFamilies SSH service dual-stack familiy selection,for dual-stack parameters see official kubernetes dual-stack concept documentation. nil
service.ssh.hostPort HostPort for ssh service nil
service.ssh.loadBalancerSourceRanges Source range filter for ssh loadbalancer []
service.ssh.annotations SSH service annotations {}

Ingress

Name Description Value
ingress.enabled Enable ingress false
ingress.className Ingress class name nil
ingress.annotations Ingress annotations {}
ingress.hosts[0].host Default Ingress host git.example.com
ingress.hosts[0].paths[0].path Default Ingress path /
ingress.hosts[0].paths[0].pathType Ingress path type Prefix
ingress.tls Ingress tls settings []
ingress.apiVersion Specify APIVersion of ingress object. Mostly would only be used for argocd.

StatefulSet

Name Description Value
resources Kubernetes resources {}
schedulerName Use an alternate scheduler, e.g. "stork" ""
nodeSelector NodeSelector for the statefulset {}
tolerations Tolerations for the statefulset []
affinity Affinity for the statefulset {}
dnsConfig dnsConfig for the statefulset {}
statefulset.env Additional environment variables to pass to containers []
statefulset.terminationGracePeriodSeconds How long to wait until forcefully kill the pod 60
statefulset.labels Labels for the statefulset {}
statefulset.annotations Annotations for the Forgejo StatefulSet to be created {}

Persistence

Name Description Value
persistence.enabled Enable persistent storage true
persistence.existingClaim Use an existing claim to store repository information nil
persistence.size Size for persistence to store repo information 10Gi
persistence.accessModes AccessMode for persistence ["ReadWriteOnce"]
persistence.labels Labels for the persistence volume claim to be created {}
persistence.annotations Annotations for the persistence volume claim to be created {}
persistence.storageClass Name of the storage class to use nil
persistence.subPath Subdirectory of the volume to mount at nil
extraVolumes Additional volumes to mount to the Forgejo statefulset []
extraContainerVolumeMounts Mounts that are only mapped into the Forgejo runtime/main container, to e.g. override custom templates. []
extraInitVolumeMounts Mounts that are only mapped into the init-containers. Can be used for additional preconfiguration. []
extraVolumeMounts DEPRECATED Additional volume mounts for init containers and the Forgejo main container []

Init

Name Description Value
initPreScript Bash shell script copied verbatim to the start of the init-container. ""

Signing

Name Description Value
signing.enabled Enable commit/action signing false
signing.gpgHome GPG home directory /data/git/.gnupg
signing.privateKey Inline private gpg key for signed Forgejo actions ""
signing.existingSecret Use an existing secret to store the value of signing.privateKey ""

Gitea

Name Description Value
gitea.admin.username Username for the Forgejo admin user gitea_admin
gitea.admin.existingSecret Use an existing secret to store admin user credentials nil
gitea.admin.password Password for the Forgejo admin user r8sA8CPHD9!bt6d
gitea.admin.email Email for the Forgejo admin user gitea@local.domain
gitea.metrics.enabled Enable Forgejo metrics false
gitea.metrics.serviceMonitor.enabled Enable Forgejo metrics service monitor false
gitea.ldap LDAP configuration []
gitea.oauth OAuth configuration []
gitea.config Configuration for the Forgejo server,ref: config-cheat-sheet {}
gitea.additionalConfigSources Additional configuration from secret or configmap []
gitea.additionalConfigFromEnvs Additional configuration sources from environment variables []
gitea.podAnnotations Annotations for the Forgejo pod {}

LivenessProbe

Name Description Value
gitea.livenessProbe.enabled Enable liveness probe true
gitea.livenessProbe.tcpSocket.port Port to probe for liveness http
gitea.livenessProbe.initialDelaySeconds Initial delay before liveness probe is initiated 200
gitea.livenessProbe.timeoutSeconds Timeout for liveness probe 1
gitea.livenessProbe.periodSeconds Period for liveness probe 10
gitea.livenessProbe.successThreshold Success threshold for liveness probe 1
gitea.livenessProbe.failureThreshold Failure threshold for liveness probe 10

ReadinessProbe

Name Description Value
gitea.readinessProbe.enabled Enable readiness probe true
gitea.readinessProbe.tcpSocket.port Port to probe for readiness http
gitea.readinessProbe.initialDelaySeconds Initial delay before readiness probe is initiated 5
gitea.readinessProbe.timeoutSeconds Timeout for readiness probe 1
gitea.readinessProbe.periodSeconds Period for readiness probe 10
gitea.readinessProbe.successThreshold Success threshold for readiness probe 1
gitea.readinessProbe.failureThreshold Failure threshold for readiness probe 3

StartupProbe

Name Description Value
gitea.startupProbe.enabled Enable startup probe false
gitea.startupProbe.tcpSocket.port Port to probe for startup http
gitea.startupProbe.initialDelaySeconds Initial delay before startup probe is initiated 60
gitea.startupProbe.timeoutSeconds Timeout for startup probe 1
gitea.startupProbe.periodSeconds Period for startup probe 10
gitea.startupProbe.successThreshold Success threshold for startup probe 1
gitea.startupProbe.failureThreshold Failure threshold for startup probe 10

Memcached

Memcached is loaded as a dependency from Bitnami if enabled in the values. Complete Configuration can be taken from their website.

Name Description Value
memcached.enabled Enable Memcached true
memcached.service.ports.memcached Port for Memcached 11211

PostgreSQL

PostgreSQL is loaded as a dependency from Bitnami if enabled in the values. Complete Configuration can be taken from their website.

Name Description Value
postgresql.enabled Enable PostgreSQL true
postgresql.auth.database PostgreSQL database gitea
postgresql.auth.username PostgreSQL username gitea
postgresql.auth.password PostgreSQL username gitea
postgresql.auth.postgresPassword PostgreSQL admin password gitea
postgresql.primary.service.ports.postgresql Port to connect to PostgreSQL service 5432
postgresql.primary.persistence.size PVC Storage Request for PostgreSQL volume 10Gi

MySQL

MySQL is loaded as a dependency from Bitnami if enabled in the values. Complete Configuration can be taken from their website.

Name Description Value
mysql.enabled Enable MySQL false
mysql.auth.database Name for new database to create. gitea
mysql.auth.username Username of new user to create. gitea
mysql.auth.password Password for the new user.Ignored if existing secret is provided gitea
mysql.auth.rootPassword Password for the root user. Ignored if existing secret is provided gitea
mysql.primary.service.ports.mysql Port to connect to MySQL service 3306
mysql.primary.persistence.size PVC Storage Request for MySQL volume 10Gi

MariaDB

MariaDB is loaded as a dependency from Bitnami if enabled in the values. Complete Configuration can be taken from their website.

Name Description Value
mariadb.enabled Enable MariaDB false
mariadb.auth.database Name of the database to create. gitea
mariadb.auth.username Username of the new user to create. gitea
mariadb.auth.password Password for the new user. Ignored if existing secret is provided gitea
mariadb.auth.rootPassword Password for the root user. gitea
mariadb.primary.service.ports.mysql Port to connect to MariaDB service 3306
mariadb.primary.persistence.size Persistence size for MariaDB 10Gi

Advanced

Name Description Value
checkDeprecation Set it to false to skip this basic validation check. true

Contributing

Expected workflow is: Fork -> Patch -> Push -> Pull Request

See CONTRIBUTORS GUIDE for details.

Upgrading

This section lists major and breaking changes of each Helm Chart version. Please read them carefully to upgrade successfully.