ingress-nginx-helm/cmd/plugin/commands/lint/main.go

235 lines
5.9 KiB
Go
Raw Normal View History

2019-03-23 02:41:20 +00:00
/*
Copyright 2019 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package lint
import (
"fmt"
"github.com/spf13/cobra"
appsv1 "k8s.io/api/apps/v1"
Release v1 (#7470) * Drop v1beta1 from ingress nginx (#7156) * Drop v1beta1 from ingress nginx Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix intorstr logic in controller Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * fixing admission Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * more intorstr fixing * correct template rendering Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix e2e tests for v1 api Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix gofmt errors * This is finally working...almost there... Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Re-add removed validation of AdmissionReview * Prepare for v1.0.0-alpha.1 release Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Update changelog and matrix table for v1.0.0-alpha.1 (#7274) Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * add docs for syslog feature (#7219) * Fix link to e2e-tests.md in developer-guide (#7201) * Use ENV expansion for namespace in args (#7146) Update the DaemonSet namespace references to use the `POD_NAMESPACE` environment variable in the same way that the Deployment does. * chart: using Helm builtin capabilities check (#7190) Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com> * Update proper default value for HTTP2MaxConcurrentStreams in Docs (#6944) It should be 128 as documented in https://github.com/kubernetes/ingress-nginx/blob/master/internal/ingress/controller/config/config.go#L780 * Fix MaxWorkerOpenFiles calculation on high cores nodes (#7107) * Fix MaxWorkerOpenFiles calculation on high cores nodes * Add e2e test for rlimit_nofile * Fix doc for max-worker-open-files * ingress/tcp: add additional error logging on failed (#7208) * Add file containing stable release (#7313) * Handle named (non-numeric) ports correctly (#7311) Signed-off-by: Carlos Panato <ctadeu@gmail.com> * Updated v1beta1 to v1 as its deprecated (#7308) * remove mercurial from build (#7031) * Retry to download maxmind DB if it fails (#7242) * Retry to download maxmind DB if it fails. Signed-off-by: Sergey Shakuto <sshakuto@infoblox.com> * Add retries count arg, move retry logic into DownloadGeoLite2DB function Signed-off-by: Sergey Shakuto <sshakuto@infoblox.com> * Reorder parameters in DownloadGeoLite2DB Signed-off-by: Sergey Shakuto <sshakuto@infoblox.com> * Remove hardcoded value Signed-off-by: Sergey Shakuto <sshakuto@infoblox.com> * Release v1.0.0-alpha.1 * Add changelog for v1.0.0-alpha.2 * controller: ignore non-service backends (#7332) * controller: ignore non-service backends Signed-off-by: Carlos Panato <ctadeu@gmail.com> * update per feedback Signed-off-by: Carlos Panato <ctadeu@gmail.com> * fix: allow scope/tcp/udp configmap namespace to altered (#7161) * Lower webhook timeout for digital ocean (#7319) * Lower webhook timeout for digital ocean * Set Digital Ocean value controller.admissionWebhooks.timeoutSeconds to 29 * update OWNERS and aliases files (#7365) (#7366) Signed-off-by: Carlos Panato <ctadeu@gmail.com> * Downgrade Lua modules for s390x (#7355) Downgrade Lua modules to last known working version. * Fix IngressClass logic for newer releases (#7341) * Fix IngressClass logic for newer releases Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Change e2e tests for the new IngressClass presence * Fix chart and admission tests Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix helm chart test Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix reviews * Remove ingressclass code from admission * update tag to v1.0.0-beta.1 * update readme and changelog for v1.0.0-beta.1 * Release v1.0.0-beta.1 - helm and manifests (#7422) * Change the order of annotation just to trigger a new helm release (#7425) * [cherry-pick] Add dev-v1 branch into helm releaser (#7428) * Add dev-v1 branch into helm releaser (#7424) * chore: add link for artifacthub.io/prerelease annotations Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com> Co-authored-by: Ricardo Katz <rikatz@users.noreply.github.com> * k8s job ci pipeline for dev-v1 br v1.22.0 (#7453) * k8s job ci pipeline for dev-v1 br v1.22.0 Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com> * k8s job ci pipeline for dev-v1 br v1.21.2 Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com> * remove v1.21.1 version Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com> * Add controller.watchIngressWithoutClass config option (#7459) Signed-off-by: Akshit Grover <akshit.grover2016@gmail.com> * Release new helm chart with certgen fixed (#7478) * Update go version, modules and remove ioutil * Release new helm chart with certgen fixed * changed appversion, chartversion, TAG, image (#7490) * Fix CI conflict * Fix CI conflict * Fix build.sh from rebase process * Fix controller_test post rebase Co-authored-by: Tianhao Guo <rggth09@gmail.com> Co-authored-by: Ray <61553+rctay@users.noreply.github.com> Co-authored-by: Bill Cassidy <cassid4@gmail.com> Co-authored-by: Jintao Zhang <tao12345666333@163.com> Co-authored-by: Sathish Ramani <rsathishx87@gmail.com> Co-authored-by: Mansur Marvanov <nanorobocop@gmail.com> Co-authored-by: Matt1360 <568198+Matt1360@users.noreply.github.com> Co-authored-by: Carlos Tadeu Panato Junior <ctadeu@gmail.com> Co-authored-by: Kundan Kumar <kundan.kumar@india.nec.com> Co-authored-by: Tom Hayward <thayward@infoblox.com> Co-authored-by: Sergey Shakuto <sshakuto@infoblox.com> Co-authored-by: Tore <tore.lonoy@gmail.com> Co-authored-by: Bouke Versteegh <info@boukeversteegh.nl> Co-authored-by: Shahid <shahid@us.ibm.com> Co-authored-by: James Strong <strong.james.e@gmail.com> Co-authored-by: Long Wu Yuan <longwuyuan@gmail.com> Co-authored-by: Jintao Zhang <zhangjintao9020@gmail.com> Co-authored-by: Neha Lohia <nehapithadiya444@gmail.com> Co-authored-by: Akshit Grover <akshit.grover2016@gmail.com>
2021-08-21 20:42:00 +00:00
networking "k8s.io/api/networking/v1"
2019-03-23 02:41:20 +00:00
kmeta "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/cli-runtime/pkg/genericclioptions"
2019-03-23 02:41:20 +00:00
"k8s.io/ingress-nginx/cmd/plugin/lints"
"k8s.io/ingress-nginx/cmd/plugin/request"
"k8s.io/ingress-nginx/cmd/plugin/util"
"k8s.io/ingress-nginx/version"
)
// CreateCommand creates and returns this cobra subcommand
func CreateCommand(flags *genericclioptions.ConfigFlags) *cobra.Command {
var opts *lintOptions
cmd := &cobra.Command{
Use: "lint",
Short: "Inspect kubernetes resources for possible issues",
RunE: func(_ *cobra.Command, _ []string) error {
2019-03-23 02:41:20 +00:00
err := opts.Validate()
if err != nil {
return err
}
fmt.Println("Checking ingresses...")
err = ingresses(*opts)
if err != nil {
util.PrintError(err)
}
fmt.Println("Checking deployments...")
err = deployments(*opts)
if err != nil {
util.PrintError(err)
}
return nil
},
}
opts = addCommonOptions(flags, cmd)
cmd.AddCommand(createSubcommand(flags, []string{"ingresses", "ingress", "ing"}, "Check ingresses for possible issues", ingresses))
cmd.AddCommand(createSubcommand(flags, []string{"deployments", "deployment", "dep"}, "Check deployments for possible issues", deployments))
return cmd
}
func createSubcommand(flags *genericclioptions.ConfigFlags, names []string, short string, f func(opts lintOptions) error) *cobra.Command {
var opts *lintOptions
cmd := &cobra.Command{
Use: names[0],
Aliases: names[1:],
Short: short,
RunE: func(_ *cobra.Command, _ []string) error {
2019-03-23 02:41:20 +00:00
err := opts.Validate()
if err != nil {
return err
}
util.PrintError(f(*opts))
return nil
},
}
opts = addCommonOptions(flags, cmd)
return cmd
}
func addCommonOptions(flags *genericclioptions.ConfigFlags, cmd *cobra.Command) *lintOptions {
out := lintOptions{
flags: flags,
}
cmd.Flags().BoolVar(&out.allNamespaces, "all-namespaces", false, "Check resources in all namespaces")
cmd.Flags().BoolVar(&out.showAll, "show-all", false, "Show all resources, not just the ones with problems")
cmd.Flags().BoolVarP(&out.verbose, "verbose", "v", false, "Show extra information about the lints")
cmd.Flags().StringVarP(&out.versionFrom, "from-version", "f", "0.0.0", "Use lints added for versions starting with this one")
cmd.Flags().StringVarP(&out.versionTo, "to-version", "t", version.RELEASE, "Use lints added for versions up to and including this one")
return &out
}
type lintOptions struct {
flags *genericclioptions.ConfigFlags
allNamespaces bool
showAll bool
verbose bool
versionFrom string
versionTo string
}
func (opts *lintOptions) Validate() error {
//nolint:dogsled // Ignore 3 blank identifiers
2019-03-23 02:41:20 +00:00
_, _, _, err := util.ParseVersionString(opts.versionFrom)
if err != nil {
return err
}
//nolint:dogsled // Ignore 3 blank identifiers
2019-03-23 02:41:20 +00:00
_, _, _, err = util.ParseVersionString(opts.versionTo)
if err != nil {
return err
}
return nil
}
type lint interface {
Check(obj kmeta.Object) bool
Message() string
Link() string
Version() string
}
func checkObjectArray(allLints []lint, objects []kmeta.Object, opts lintOptions) {
2019-03-23 02:41:20 +00:00
usedLints := make([]lint, 0)
for _, lint := range allLints {
2019-03-23 02:41:20 +00:00
lintVersion := lint.Version()
if lint.Version() == "" {
lintVersion = "0.0.0"
}
if util.InVersionRangeInclusive(opts.versionFrom, lintVersion, opts.versionTo) {
usedLints = append(usedLints, lint)
}
}
for _, obj := range objects {
objName := obj.GetName()
if opts.allNamespaces {
objName = obj.GetNamespace() + "/" + obj.GetName()
}
failedLints := make([]lint, 0)
for _, lint := range usedLints {
if lint.Check(obj) {
failedLints = append(failedLints, lint)
}
}
if len(failedLints) != 0 {
fmt.Printf("✗ %v\n", objName)
for _, lint := range failedLints {
fmt.Printf(" - %v\n", lint.Message())
if opts.verbose && lint.Version() != "" {
fmt.Printf(" Lint added for version %v\n", lint.Version())
}
if opts.verbose && lint.Link() != "" {
fmt.Printf(" %v\n", lint.Link())
}
}
fmt.Println("")
continue
}
if opts.showAll {
fmt.Printf("✓ %v\n", objName)
}
}
}
func ingresses(opts lintOptions) error {
var ings []networking.Ingress
2019-03-23 02:41:20 +00:00
var err error
if opts.allNamespaces {
ings, err = request.GetIngressDefinitions(opts.flags, "")
} else {
ings, err = request.GetIngressDefinitions(opts.flags, util.GetNamespace(opts.flags))
}
if err != nil {
return err
}
iLints := lints.GetIngressLints()
2019-03-23 02:41:20 +00:00
genericLints := make([]lint, len(iLints))
for i := range iLints {
genericLints[i] = iLints[i]
}
objects := make([]kmeta.Object, 0)
for i := range ings {
objects = append(objects, &ings[i])
}
checkObjectArray(genericLints, objects, opts)
return nil
}
func deployments(opts lintOptions) error {
var deps []appsv1.Deployment
var err error
if opts.allNamespaces {
deps, err = request.GetDeployments(opts.flags, "")
} else {
deps, err = request.GetDeployments(opts.flags, util.GetNamespace(opts.flags))
}
if err != nil {
return err
}
iLints := lints.GetDeploymentLints()
2019-03-23 02:41:20 +00:00
genericLints := make([]lint, len(iLints))
for i := range iLints {
genericLints[i] = iLints[i]
}
objects := make([]kmeta.Object, 0)
for i := range deps {
objects = append(objects, &deps[i])
}
checkObjectArray(genericLints, objects, opts)
return nil
}