From 003039f23c060675d98890898e06938616f6fb58 Mon Sep 17 00:00:00 2001 From: Naseem Date: Wed, 26 Feb 2020 23:27:28 -0500 Subject: [PATCH] Use recommended labels and label helpers Signed-off-by: Naseem --- charts/ingress-nginx/templates/_helpers.tpl | 22 ++++++++++++++++++- .../templates/addheaders-configmap.yaml | 9 +++----- .../job-patch/clusterrole.yaml | 11 ++++------ .../job-patch/clusterrolebinding.yaml | 13 +++++------ .../job-patch/job-createSecret.yaml | 20 ++++++----------- .../job-patch/job-patchWebhook.yaml | 22 +++++++------------ .../admission-webhooks/job-patch/psp.yaml | 9 +++----- .../admission-webhooks/job-patch/role.yaml | 9 +++----- .../job-patch/rolebinding.yaml | 13 +++++------ .../job-patch/serviceaccount.yaml | 9 +++----- .../validating-webhook.yaml | 9 +++----- .../ingress-nginx/templates/clusterrole.yaml | 7 ++---- .../templates/clusterrolebinding.yaml | 9 +++----- .../templates/controller-configmap.yaml | 11 ++++------ .../templates/controller-daemonset.yaml | 22 ++++++++----------- .../templates/controller-deployment.yaml | 20 +++++++---------- .../templates/controller-hpa.yaml | 7 ++---- .../templates/controller-metrics-service.yaml | 12 ++++------ .../controller-poddisruptionbudget.yaml | 12 ++++------ .../templates/controller-prometheusrules.yaml | 7 ++---- .../templates/controller-psp.yaml | 8 +++---- .../templates/controller-role.yaml | 10 ++++----- .../templates/controller-rolebinding.yaml | 10 ++++----- .../templates/controller-service.yaml | 12 ++++------ .../templates/controller-serviceaccount.yaml | 6 ++--- .../templates/controller-servicemonitor.yaml | 12 ++++------ .../templates/controller-webhook-service.yaml | 12 ++++------ .../templates/default-backend-deployment.yaml | 16 +++++--------- .../default-backend-poddisruptionbudget.yaml | 12 ++++------ .../templates/default-backend-psp.yaml | 8 +++---- .../templates/default-backend-role.yaml | 10 ++++----- .../default-backend-rolebinding.yaml | 10 ++++----- .../templates/default-backend-service.yaml | 12 ++++------ .../default-backend-serviceaccount.yaml | 6 ++--- .../templates/proxyheaders-configmap.yaml | 9 +++----- .../templates/tcp-configmap.yaml | 9 +++----- .../templates/udp-configmap.yaml | 9 +++----- 37 files changed, 164 insertions(+), 260 deletions(-) diff --git a/charts/ingress-nginx/templates/_helpers.tpl b/charts/ingress-nginx/templates/_helpers.tpl index 036025323..81ae72ed4 100644 --- a/charts/ingress-nginx/templates/_helpers.tpl +++ b/charts/ingress-nginx/templates/_helpers.tpl @@ -61,6 +61,26 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this {{- printf "%s-%s" (include "nginx-ingress.fullname" .) .Values.defaultBackend.name | trunc 63 | trimSuffix "-" -}} {{- end -}} +{{/* +Common labels +*/}} +{{- define "nginx-ingress.labels" -}} +helm.sh/chart: {{ include "nginx-ingress.chart" . }} +{{ include "nginx-ingress.selectorLabels" . }} +{{- if .Chart.AppVersion }} +app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} +{{- end }} +app.kubernetes.io/managed-by: {{ .Release.Service }} +{{- end -}} + +{{/* +Selector labels +*/}} +{{- define "nginx-ingress.selectorLabels" -}} +app.kubernetes.io/name: {{ include "nginx-ingress.name" . }} +app.kubernetes.io/instance: {{ .Release.Name }} +{{- end -}} + {{/* Create the name of the controller service account to use */}} @@ -114,4 +134,4 @@ Return the appropriate apiVersion for podSecurityPolicy. {{- else -}} {{- print "extensions/v1beta1" -}} {{- end -}} -{{- end -}} \ No newline at end of file +{{- end -}} diff --git a/charts/ingress-nginx/templates/addheaders-configmap.yaml b/charts/ingress-nginx/templates/addheaders-configmap.yaml index 04a04aa4e..f29f8ba7f 100644 --- a/charts/ingress-nginx/templates/addheaders-configmap.yaml +++ b/charts/ingress-nginx/templates/addheaders-configmap.yaml @@ -3,12 +3,9 @@ apiVersion: v1 kind: ConfigMap metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} - name: {{ template "nginx-ingress.fullname" . }}-custom-add-headers + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} + name: {{ include "nginx-ingress.fullname" . }}-custom-add-headers data: {{ toYaml .Values.controller.addHeaders | indent 2 }} {{- end }} diff --git a/charts/ingress-nginx/templates/admission-webhooks/job-patch/clusterrole.yaml b/charts/ingress-nginx/templates/admission-webhooks/job-patch/clusterrole.yaml index 97d7a2a41..3151a78ea 100644 --- a/charts/ingress-nginx/templates/admission-webhooks/job-patch/clusterrole.yaml +++ b/charts/ingress-nginx/templates/admission-webhooks/job-patch/clusterrole.yaml @@ -2,16 +2,13 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: - name: {{ template "nginx-ingress.fullname" . }}-admission + name: {{ include "nginx-ingress.fullname" . }}-admission annotations: "helm.sh/hook": pre-install,pre-upgrade,post-install,post-upgrade "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} rules: - apiGroups: - admissionregistration.k8s.io @@ -25,6 +22,6 @@ rules: resources: ['podsecuritypolicies'] verbs: ['use'] resourceNames: - - {{ template "nginx-ingress.fullname" . }}-admission + - {{ include "nginx-ingress.fullname" . }}-admission {{- end }} {{- end }} diff --git a/charts/ingress-nginx/templates/admission-webhooks/job-patch/clusterrolebinding.yaml b/charts/ingress-nginx/templates/admission-webhooks/job-patch/clusterrolebinding.yaml index 57c21049d..ebd62bd72 100644 --- a/charts/ingress-nginx/templates/admission-webhooks/job-patch/clusterrolebinding.yaml +++ b/charts/ingress-nginx/templates/admission-webhooks/job-patch/clusterrolebinding.yaml @@ -2,22 +2,19 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRoleBinding metadata: - name: {{ template "nginx-ingress.fullname" . }}-admission + name: {{ include "nginx-ingress.fullname" . }}-admission annotations: "helm.sh/hook": pre-install,pre-upgrade,post-install,post-upgrade "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} roleRef: apiGroup: rbac.authorization.k8s.io kind: ClusterRole - name: {{ template "nginx-ingress.fullname" . }}-admission + name: {{ include "nginx-ingress.fullname" . }}-admission subjects: - kind: ServiceAccount - name: {{ template "nginx-ingress.fullname" . }}-admission + name: {{ include "nginx-ingress.fullname" . }}-admission namespace: {{ .Release.Namespace }} {{- end }} diff --git a/charts/ingress-nginx/templates/admission-webhooks/job-patch/job-createSecret.yaml b/charts/ingress-nginx/templates/admission-webhooks/job-patch/job-createSecret.yaml index 4e4b6b55b..54e4ec514 100644 --- a/charts/ingress-nginx/templates/admission-webhooks/job-patch/job-createSecret.yaml +++ b/charts/ingress-nginx/templates/admission-webhooks/job-patch/job-createSecret.yaml @@ -2,16 +2,13 @@ apiVersion: batch/v1 kind: Job metadata: - name: {{ template "nginx-ingress.fullname" . }}-admission-create + name: {{ include "nginx-ingress.fullname" . }}-admission-create annotations: "helm.sh/hook": pre-install,pre-upgrade "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} spec: {{- if .Capabilities.APIVersions.Has "batch/v1alpha1" }} # Alpha feature since k8s 1.12 @@ -19,17 +16,14 @@ spec: {{- end }} template: metadata: - name: {{ template "nginx-ingress.fullname" . }}-admission-create + name: {{ include "nginx-ingress.fullname" . }}-admission-create {{- with .Values.controller.admissionWebhooks.patch.podAnnotations }} annotations: {{ toYaml . | indent 8 }} {{- end }} labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 8 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} spec: {{- if .Values.controller.admissionWebhooks.patch.priorityClassName }} priorityClassName: {{ .Values.controller.admissionWebhooks.patch.priorityClassName }} @@ -44,7 +38,7 @@ spec: - --namespace={{ .Release.Namespace }} - --secret-name={{ template "nginx-ingress.fullname". }}-admission restartPolicy: OnFailure - serviceAccountName: {{ template "nginx-ingress.fullname" . }}-admission + serviceAccountName: {{ include "nginx-ingress.fullname" . }}-admission {{- with .Values.controller.admissionWebhooks.patch.nodeSelector }} nodeSelector: {{ toYaml . | indent 8 }} diff --git a/charts/ingress-nginx/templates/admission-webhooks/job-patch/job-patchWebhook.yaml b/charts/ingress-nginx/templates/admission-webhooks/job-patch/job-patchWebhook.yaml index 2182e534d..2c548c525 100644 --- a/charts/ingress-nginx/templates/admission-webhooks/job-patch/job-patchWebhook.yaml +++ b/charts/ingress-nginx/templates/admission-webhooks/job-patch/job-patchWebhook.yaml @@ -2,16 +2,13 @@ apiVersion: batch/v1 kind: Job metadata: - name: {{ template "nginx-ingress.fullname" . }}-admission-patch + name: {{ include "nginx-ingress.fullname" . }}-admission-patch annotations: "helm.sh/hook": post-install,post-upgrade "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} spec: {{- if .Capabilities.APIVersions.Has "batch/v1alpha1" }} # Alpha feature since k8s 1.12 @@ -19,17 +16,14 @@ spec: {{- end }} template: metadata: - name: {{ template "nginx-ingress.fullname" . }}-admission-patch + name: {{ include "nginx-ingress.fullname" . }}-admission-patch {{- with .Values.controller.admissionWebhooks.patch.podAnnotations }} annotations: {{ toYaml . | indent 8 }} {{- end }} labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 8 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} spec: {{- if .Values.controller.admissionWebhooks.patch.priorityClassName }} priorityClassName: {{ .Values.controller.admissionWebhooks.patch.priorityClassName }} @@ -40,13 +34,13 @@ spec: imagePullPolicy: {{ .Values.controller.admissionWebhooks.patch.pullPolicy }} args: - patch - - --webhook-name={{ template "nginx-ingress.fullname" . }}-admission + - --webhook-name={{ include "nginx-ingress.fullname" . }}-admission - --namespace={{ .Release.Namespace }} - --patch-mutating=false - --secret-name={{ template "nginx-ingress.fullname". }}-admission - --patch-failure-policy={{ .Values.controller.admissionWebhooks.failurePolicy }} restartPolicy: OnFailure - serviceAccountName: {{ template "nginx-ingress.fullname" . }}-admission + serviceAccountName: {{ include "nginx-ingress.fullname" . }}-admission {{- with .Values.controller.admissionWebhooks.patch.nodeSelector }} nodeSelector: {{ toYaml . | indent 8 }} diff --git a/charts/ingress-nginx/templates/admission-webhooks/job-patch/psp.yaml b/charts/ingress-nginx/templates/admission-webhooks/job-patch/psp.yaml index 3b69e00df..6d75f4c8d 100644 --- a/charts/ingress-nginx/templates/admission-webhooks/job-patch/psp.yaml +++ b/charts/ingress-nginx/templates/admission-webhooks/job-patch/psp.yaml @@ -2,16 +2,13 @@ apiVersion: policy/v1beta1 kind: PodSecurityPolicy metadata: - name: {{ template "nginx-ingress.fullname" . }}-admission + name: {{ include "nginx-ingress.fullname" . }}-admission annotations: "helm.sh/hook": pre-install,pre-upgrade,post-install,post-upgrade "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} spec: allowPrivilegeEscalation: false fsGroup: diff --git a/charts/ingress-nginx/templates/admission-webhooks/job-patch/role.yaml b/charts/ingress-nginx/templates/admission-webhooks/job-patch/role.yaml index 455766296..08c3494db 100644 --- a/charts/ingress-nginx/templates/admission-webhooks/job-patch/role.yaml +++ b/charts/ingress-nginx/templates/admission-webhooks/job-patch/role.yaml @@ -2,16 +2,13 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: Role metadata: - name: {{ template "nginx-ingress.fullname" . }}-admission + name: {{ include "nginx-ingress.fullname" . }}-admission annotations: "helm.sh/hook": pre-install,pre-upgrade,post-install,post-upgrade "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} rules: - apiGroups: - "" diff --git a/charts/ingress-nginx/templates/admission-webhooks/job-patch/rolebinding.yaml b/charts/ingress-nginx/templates/admission-webhooks/job-patch/rolebinding.yaml index 0e0907db8..eeaa3d254 100644 --- a/charts/ingress-nginx/templates/admission-webhooks/job-patch/rolebinding.yaml +++ b/charts/ingress-nginx/templates/admission-webhooks/job-patch/rolebinding.yaml @@ -2,22 +2,19 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: RoleBinding metadata: - name: {{ template "nginx-ingress.fullname" . }}-admission + name: {{ include "nginx-ingress.fullname" . }}-admission annotations: "helm.sh/hook": pre-install,pre-upgrade,post-install,post-upgrade "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} roleRef: apiGroup: rbac.authorization.k8s.io kind: Role - name: {{ template "nginx-ingress.fullname" . }}-admission + name: {{ include "nginx-ingress.fullname" . }}-admission subjects: - kind: ServiceAccount - name: {{ template "nginx-ingress.fullname" . }}-admission + name: {{ include "nginx-ingress.fullname" . }}-admission namespace: {{ .Release.Namespace }} {{- end }} diff --git a/charts/ingress-nginx/templates/admission-webhooks/job-patch/serviceaccount.yaml b/charts/ingress-nginx/templates/admission-webhooks/job-patch/serviceaccount.yaml index 11d249c1b..5fef6ab95 100644 --- a/charts/ingress-nginx/templates/admission-webhooks/job-patch/serviceaccount.yaml +++ b/charts/ingress-nginx/templates/admission-webhooks/job-patch/serviceaccount.yaml @@ -2,14 +2,11 @@ apiVersion: v1 kind: ServiceAccount metadata: - name: {{ template "nginx-ingress.fullname" . }}-admission + name: {{ include "nginx-ingress.fullname" . }}-admission annotations: "helm.sh/hook": pre-install,pre-upgrade,post-install,post-upgrade "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} {{- end }} diff --git a/charts/ingress-nginx/templates/admission-webhooks/validating-webhook.yaml b/charts/ingress-nginx/templates/admission-webhooks/validating-webhook.yaml index 53f37b273..56d8d0c31 100644 --- a/charts/ingress-nginx/templates/admission-webhooks/validating-webhook.yaml +++ b/charts/ingress-nginx/templates/admission-webhooks/validating-webhook.yaml @@ -3,12 +3,9 @@ apiVersion: admissionregistration.k8s.io/v1beta1 kind: ValidatingWebhookConfiguration metadata: labels: - app: {{ template "nginx-ingress.name" . }}-admission - chart: {{ template "nginx-ingress.chart" . }} - component: "admission-webhook" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} - name: {{ template "nginx-ingress.fullname" . }}-admission + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: admission-webhook + name: {{ include "nginx-ingress.fullname" . }}-admission webhooks: - name: validate.nginx.ingress.kubernetes.io rules: diff --git a/charts/ingress-nginx/templates/clusterrole.yaml b/charts/ingress-nginx/templates/clusterrole.yaml index 507260301..9f237a8be 100644 --- a/charts/ingress-nginx/templates/clusterrole.yaml +++ b/charts/ingress-nginx/templates/clusterrole.yaml @@ -3,11 +3,8 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} - name: {{ template "nginx-ingress.fullname" . }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + name: {{ include "nginx-ingress.fullname" . }} rules: - apiGroups: - "" diff --git a/charts/ingress-nginx/templates/clusterrolebinding.yaml b/charts/ingress-nginx/templates/clusterrolebinding.yaml index 1f6976a04..d0955f093 100644 --- a/charts/ingress-nginx/templates/clusterrolebinding.yaml +++ b/charts/ingress-nginx/templates/clusterrolebinding.yaml @@ -3,15 +3,12 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRoleBinding metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} - name: {{ template "nginx-ingress.fullname" . }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + name: {{ include "nginx-ingress.fullname" . }} roleRef: apiGroup: rbac.authorization.k8s.io kind: ClusterRole - name: {{ template "nginx-ingress.fullname" . }} + name: {{ include "nginx-ingress.fullname" . }} subjects: - kind: ServiceAccount name: {{ template "nginx-ingress.serviceAccountName" . }} diff --git a/charts/ingress-nginx/templates/controller-configmap.yaml b/charts/ingress-nginx/templates/controller-configmap.yaml index 16f0beb53..a4cee6207 100644 --- a/charts/ingress-nginx/templates/controller-configmap.yaml +++ b/charts/ingress-nginx/templates/controller-configmap.yaml @@ -3,20 +3,17 @@ apiVersion: v1 kind: ConfigMap metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} annotations: {{ toYaml .Values.controller.configAnnotations | indent 4}} name: {{ template "nginx-ingress.controller.fullname" . }} data: {{- if .Values.controller.addHeaders }} - add-headers: {{ .Release.Namespace }}/{{ template "nginx-ingress.fullname" . }}-custom-add-headers + add-headers: {{ .Release.Namespace }}/{{ include "nginx-ingress.fullname" . }}-custom-add-headers {{- end }} {{- if or .Values.controller.proxySetHeaders .Values.controller.headers }} - proxy-set-headers: {{ .Release.Namespace }}/{{ template "nginx-ingress.fullname" . }}-custom-proxy-headers + proxy-set-headers: {{ .Release.Namespace }}/{{ include "nginx-ingress.fullname" . }}-custom-proxy-headers {{- end }} {{- if .Values.controller.config }} {{ toYaml .Values.controller.config | indent 2 }} diff --git a/charts/ingress-nginx/templates/controller-daemonset.yaml b/charts/ingress-nginx/templates/controller-daemonset.yaml index 36517c466..0a4b8ccb0 100644 --- a/charts/ingress-nginx/templates/controller-daemonset.yaml +++ b/charts/ingress-nginx/templates/controller-daemonset.yaml @@ -5,19 +5,16 @@ apiVersion: {{ template "deployment.apiVersion" . }} kind: DaemonSet metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} name: {{ template "nginx-ingress.controller.fullname" . }} - annotations: + annotations: {{ toYaml .Values.controller.deploymentAnnotations | indent 4}} spec: selector: matchLabels: - app: {{ template "nginx-ingress.name" . }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.selectorLabels" . | nindent 6 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} revisionHistoryLimit: {{ .Values.revisionHistoryLimit }} updateStrategy: {{ toYaml .Values.controller.updateStrategy | indent 4 }} @@ -31,9 +28,8 @@ spec: {{- end }} {{- end }} labels: - app: {{ template "nginx-ingress.name" . }} - component: "{{ .Values.controller.name }}" - release: {{ .Release.Name }} + {{- include "nginx-ingress.selectorLabels" . | nindent 8 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} {{- if .Values.controller.podLabels }} {{ toYaml .Values.controller.podLabels | indent 8}} {{- end }} @@ -88,10 +84,10 @@ spec: - --nginx-configmap={{ .Release.Namespace }}/{{ template "nginx-ingress.controller.fullname" . }} {{- end }} {{- if .Values.tcp }} - - --tcp-services-configmap={{ .Release.Namespace }}/{{ template "nginx-ingress.fullname" . }}-tcp + - --tcp-services-configmap={{ .Release.Namespace }}/{{ include "nginx-ingress.fullname" . }}-tcp {{- end }} {{- if .Values.udp }} - - --udp-services-configmap={{ .Release.Namespace }}/{{ template "nginx-ingress.fullname" . }}-udp + - --udp-services-configmap={{ .Release.Namespace }}/{{ include "nginx-ingress.fullname" . }}-udp {{- end }} {{- if .Values.controller.scope.enabled }} - --watch-namespace={{ default .Release.Namespace .Values.controller.scope.namespace }} diff --git a/charts/ingress-nginx/templates/controller-deployment.yaml b/charts/ingress-nginx/templates/controller-deployment.yaml index 1a00a4b8e..06aefd76f 100644 --- a/charts/ingress-nginx/templates/controller-deployment.yaml +++ b/charts/ingress-nginx/templates/controller-deployment.yaml @@ -3,19 +3,16 @@ apiVersion: {{ template "deployment.apiVersion" . }} kind: Deployment metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} name: {{ template "nginx-ingress.controller.fullname" . }} annotations: {{ toYaml .Values.controller.deploymentAnnotations | indent 4}} spec: selector: matchLabels: - app: {{ template "nginx-ingress.name" . }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.selectorLabels" . | nindent 6 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} {{- if not .Values.controller.autoscaling.enabled }} replicas: {{ .Values.controller.replicaCount }} {{- end }} @@ -32,9 +29,8 @@ spec: {{- end }} {{- end }} labels: - app: {{ template "nginx-ingress.name" . }} - component: "{{ .Values.controller.name }}" - release: {{ .Release.Name }} + {{- include "nginx-ingress.selectorLabels" . | nindent 8 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} {{- if .Values.controller.podLabels }} {{ toYaml .Values.controller.podLabels | indent 8 }} {{- end }} @@ -89,10 +85,10 @@ spec: - --nginx-configmap={{ default .Release.Namespace .Values.controller.configMapNamespace }}/{{ template "nginx-ingress.controller.fullname" . }} {{- end }} {{- if .Values.tcp }} - - --tcp-services-configmap={{ default .Release.Namespace .Values.controller.tcp.configMapNamespace }}/{{ template "nginx-ingress.fullname" . }}-tcp + - --tcp-services-configmap={{ default .Release.Namespace .Values.controller.tcp.configMapNamespace }}/{{ include "nginx-ingress.fullname" . }}-tcp {{- end }} {{- if .Values.udp }} - - --udp-services-configmap={{ default .Release.Namespace .Values.controller.udp.configMapNamespace }}/{{ template "nginx-ingress.fullname" . }}-udp + - --udp-services-configmap={{ default .Release.Namespace .Values.controller.udp.configMapNamespace }}/{{ include "nginx-ingress.fullname" . }}-udp {{- end }} {{- if .Values.controller.scope.enabled }} - --watch-namespace={{ default .Release.Namespace .Values.controller.scope.namespace }} diff --git a/charts/ingress-nginx/templates/controller-hpa.yaml b/charts/ingress-nginx/templates/controller-hpa.yaml index dc993ebae..cb6420609 100644 --- a/charts/ingress-nginx/templates/controller-hpa.yaml +++ b/charts/ingress-nginx/templates/controller-hpa.yaml @@ -4,11 +4,8 @@ apiVersion: autoscaling/v2beta1 kind: HorizontalPodAutoscaler metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} name: {{ template "nginx-ingress.controller.fullname" . }} spec: scaleTargetRef: diff --git a/charts/ingress-nginx/templates/controller-metrics-service.yaml b/charts/ingress-nginx/templates/controller-metrics-service.yaml index f38dca01d..6adab8dcd 100644 --- a/charts/ingress-nginx/templates/controller-metrics-service.yaml +++ b/charts/ingress-nginx/templates/controller-metrics-service.yaml @@ -12,11 +12,8 @@ metadata: {{- if .Values.controller.metrics.service.labels }} {{ toYaml .Values.controller.metrics.service.labels | indent 4 }} {{- end }} - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} name: {{ template "nginx-ingress.controller.fullname" . }}-metrics spec: {{- if not .Values.controller.metrics.service.omitClusterIP }} @@ -40,8 +37,7 @@ spec: port: {{ .Values.controller.metrics.service.servicePort }} targetPort: metrics selector: - app: {{ template "nginx-ingress.name" . }} - component: "{{ .Values.controller.name }}" - release: {{ .Release.Name }} + {{- include "nginx-ingress.selectorLabels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} type: "{{ .Values.controller.metrics.service.type }}" {{- end }} diff --git a/charts/ingress-nginx/templates/controller-poddisruptionbudget.yaml b/charts/ingress-nginx/templates/controller-poddisruptionbudget.yaml index 70a59c103..1b5b581cc 100644 --- a/charts/ingress-nginx/templates/controller-poddisruptionbudget.yaml +++ b/charts/ingress-nginx/templates/controller-poddisruptionbudget.yaml @@ -3,17 +3,13 @@ apiVersion: policy/v1beta1 kind: PodDisruptionBudget metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} name: {{ template "nginx-ingress.controller.fullname" . }} spec: selector: matchLabels: - app: {{ template "nginx-ingress.name" . }} - release: {{ .Release.Name }} - component: "{{ .Values.controller.name }}" + {{- include "nginx-ingress.selectorLabels" . | nindent 6 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} minAvailable: {{ .Values.controller.minAvailable }} {{- end }} diff --git a/charts/ingress-nginx/templates/controller-prometheusrules.yaml b/charts/ingress-nginx/templates/controller-prometheusrules.yaml index 9cee0e990..6cc80b035 100644 --- a/charts/ingress-nginx/templates/controller-prometheusrules.yaml +++ b/charts/ingress-nginx/templates/controller-prometheusrules.yaml @@ -7,11 +7,8 @@ metadata: namespace: {{ .Values.controller.metrics.prometheusRule.namespace }} {{- end }} labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} {{- if .Values.controller.metrics.prometheusRule.additionalLabels }} {{ toYaml .Values.controller.metrics.prometheusRule.additionalLabels | indent 4 }} {{- end }} diff --git a/charts/ingress-nginx/templates/controller-psp.yaml b/charts/ingress-nginx/templates/controller-psp.yaml index b91ecba22..2e0c1903f 100644 --- a/charts/ingress-nginx/templates/controller-psp.yaml +++ b/charts/ingress-nginx/templates/controller-psp.yaml @@ -2,12 +2,10 @@ apiVersion: {{ template "podSecurityPolicy.apiVersion" . }} kind: PodSecurityPolicy metadata: - name: {{ template "nginx-ingress.fullname" . }} + name: {{ include "nginx-ingress.fullname" . }} labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} spec: allowedCapabilities: - NET_BIND_SERVICE diff --git a/charts/ingress-nginx/templates/controller-role.yaml b/charts/ingress-nginx/templates/controller-role.yaml index 9e53929db..d4a84f9c3 100644 --- a/charts/ingress-nginx/templates/controller-role.yaml +++ b/charts/ingress-nginx/templates/controller-role.yaml @@ -3,11 +3,9 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: Role metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} - name: {{ template "nginx-ingress.fullname" . }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} + name: {{ include "nginx-ingress.fullname" . }} rules: - apiGroups: - "" @@ -85,7 +83,7 @@ rules: - apiGroups: ['{{ template "podSecurityPolicy.apiGroup" . }}'] resources: ['podsecuritypolicies'] verbs: ['use'] - resourceNames: [{{ template "nginx-ingress.fullname" . }}] + resourceNames: [{{ include "nginx-ingress.fullname" . }}] {{- end }} {{- end -}} diff --git a/charts/ingress-nginx/templates/controller-rolebinding.yaml b/charts/ingress-nginx/templates/controller-rolebinding.yaml index 3e96a31c5..15bbeecc0 100644 --- a/charts/ingress-nginx/templates/controller-rolebinding.yaml +++ b/charts/ingress-nginx/templates/controller-rolebinding.yaml @@ -3,15 +3,13 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: RoleBinding metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} - name: {{ template "nginx-ingress.fullname" . }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} + name: {{ include "nginx-ingress.fullname" . }} roleRef: apiGroup: rbac.authorization.k8s.io kind: Role - name: {{ template "nginx-ingress.fullname" . }} + name: {{ include "nginx-ingress.fullname" . }} subjects: - kind: ServiceAccount name: {{ template "nginx-ingress.serviceAccountName" . }} diff --git a/charts/ingress-nginx/templates/controller-service.yaml b/charts/ingress-nginx/templates/controller-service.yaml index 5961fc159..c1490f341 100644 --- a/charts/ingress-nginx/templates/controller-service.yaml +++ b/charts/ingress-nginx/templates/controller-service.yaml @@ -12,11 +12,8 @@ metadata: {{- if .Values.controller.service.labels }} {{ toYaml .Values.controller.service.labels | indent 4 }} {{- end }} - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} name: {{ template "nginx-ingress.controller.fullname" . }} spec: {{- if not .Values.controller.service.omitClusterIP }} @@ -87,8 +84,7 @@ spec: {{- end }} {{- end }} selector: - app: {{ template "nginx-ingress.name" . }} - component: "{{ .Values.controller.name }}" - release: {{ .Release.Name }} + {{- include "nginx-ingress.selectorLabels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} type: "{{ .Values.controller.service.type }}" {{- end }} diff --git a/charts/ingress-nginx/templates/controller-serviceaccount.yaml b/charts/ingress-nginx/templates/controller-serviceaccount.yaml index 4ad90638e..aa5ed0d28 100644 --- a/charts/ingress-nginx/templates/controller-serviceaccount.yaml +++ b/charts/ingress-nginx/templates/controller-serviceaccount.yaml @@ -3,9 +3,7 @@ apiVersion: v1 kind: ServiceAccount metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} name: {{ template "nginx-ingress.serviceAccountName" . }} {{- end -}} diff --git a/charts/ingress-nginx/templates/controller-servicemonitor.yaml b/charts/ingress-nginx/templates/controller-servicemonitor.yaml index e082b2f77..d174cbced 100644 --- a/charts/ingress-nginx/templates/controller-servicemonitor.yaml +++ b/charts/ingress-nginx/templates/controller-servicemonitor.yaml @@ -7,11 +7,8 @@ metadata: namespace: {{ .Values.controller.metrics.serviceMonitor.namespace }} {{- end }} labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} {{- if .Values.controller.metrics.serviceMonitor.additionalLabels }} {{ toYaml .Values.controller.metrics.serviceMonitor.additionalLabels | indent 4 }} {{- end }} @@ -32,7 +29,6 @@ spec: {{- end }} selector: matchLabels: - app: {{ template "nginx-ingress.name" . }} - component: "{{ .Values.controller.name }}" - release: {{ .Release.Name }} + {{- include "nginx-ingress.selectorLabels" . | nindent 6 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} {{- end }} diff --git a/charts/ingress-nginx/templates/controller-webhook-service.yaml b/charts/ingress-nginx/templates/controller-webhook-service.yaml index 0b2a4ca79..e9921dc32 100644 --- a/charts/ingress-nginx/templates/controller-webhook-service.yaml +++ b/charts/ingress-nginx/templates/controller-webhook-service.yaml @@ -9,11 +9,8 @@ metadata: {{- end }} {{- end }} labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} name: {{ template "nginx-ingress.controller.fullname" . }}-admission spec: {{- if not .Values.controller.admissionWebhooks.service.omitClusterIP }} @@ -37,8 +34,7 @@ spec: port: 443 targetPort: webhook selector: - app: {{ template "nginx-ingress.name" . }} - component: "{{ .Values.controller.name }}" - release: {{ .Release.Name }} + {{- include "nginx-ingress.selectorLabels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} type: "{{ .Values.controller.admissionWebhooks.service.type }}" {{- end }} diff --git a/charts/ingress-nginx/templates/default-backend-deployment.yaml b/charts/ingress-nginx/templates/default-backend-deployment.yaml index 835a73706..8ea176fbb 100644 --- a/charts/ingress-nginx/templates/default-backend-deployment.yaml +++ b/charts/ingress-nginx/templates/default-backend-deployment.yaml @@ -3,17 +3,14 @@ apiVersion: {{ template "deployment.apiVersion" . }} kind: Deployment metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.defaultBackend.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }} name: {{ template "nginx-ingress.defaultBackend.fullname" . }} spec: selector: matchLabels: - app: {{ template "nginx-ingress.name" . }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.selectorLabels" . | nindent 6 }} + app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }} replicas: {{ .Values.defaultBackend.replicaCount }} revisionHistoryLimit: {{ .Values.revisionHistoryLimit }} template: @@ -25,9 +22,8 @@ spec: {{- end }} {{- end }} labels: - app: {{ template "nginx-ingress.name" . }} - component: "{{ .Values.defaultBackend.name }}" - release: {{ .Release.Name }} + {{- include "nginx-ingress.selectorLabels" . | nindent 8 }} + app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }} {{- if .Values.defaultBackend.podLabels }} {{ toYaml .Values.defaultBackend.podLabels | indent 8 }} {{- end }} diff --git a/charts/ingress-nginx/templates/default-backend-poddisruptionbudget.yaml b/charts/ingress-nginx/templates/default-backend-poddisruptionbudget.yaml index af0ec7372..bb405899d 100644 --- a/charts/ingress-nginx/templates/default-backend-poddisruptionbudget.yaml +++ b/charts/ingress-nginx/templates/default-backend-poddisruptionbudget.yaml @@ -3,17 +3,13 @@ apiVersion: policy/v1beta1 kind: PodDisruptionBudget metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.defaultBackend.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }} name: {{ template "nginx-ingress.defaultBackend.fullname" . }} spec: selector: matchLabels: - app: {{ template "nginx-ingress.name" . }} - release: {{ .Release.Name }} - component: "{{ .Values.defaultBackend.name }}" + {{- include "nginx-ingress.selectorLabels" . | nindent 6 }} + app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }} minAvailable: {{ .Values.defaultBackend.minAvailable }} {{- end }} diff --git a/charts/ingress-nginx/templates/default-backend-psp.yaml b/charts/ingress-nginx/templates/default-backend-psp.yaml index beed24908..7e377d58e 100644 --- a/charts/ingress-nginx/templates/default-backend-psp.yaml +++ b/charts/ingress-nginx/templates/default-backend-psp.yaml @@ -2,12 +2,10 @@ apiVersion: {{ template "podSecurityPolicy.apiVersion" . }} kind: PodSecurityPolicy metadata: - name: {{ template "nginx-ingress.fullname" . }}-backend + name: {{ include "nginx-ingress.fullname" . }}-backend labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }} spec: allowPrivilegeEscalation: false fsGroup: diff --git a/charts/ingress-nginx/templates/default-backend-role.yaml b/charts/ingress-nginx/templates/default-backend-role.yaml index 184ac815b..63ba4698e 100644 --- a/charts/ingress-nginx/templates/default-backend-role.yaml +++ b/charts/ingress-nginx/templates/default-backend-role.yaml @@ -3,14 +3,12 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: Role metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} - name: {{ template "nginx-ingress.fullname" . }}-backend + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }} + name: {{ include "nginx-ingress.fullname" . }}-backend rules: - apiGroups: ['{{ template "podSecurityPolicy.apiGroup" . }}'] resources: ['podsecuritypolicies'] verbs: ['use'] - resourceNames: [{{ template "nginx-ingress.fullname" . }}-backend] + resourceNames: [{{ include "nginx-ingress.fullname" . }}-backend] {{- end -}} diff --git a/charts/ingress-nginx/templates/default-backend-rolebinding.yaml b/charts/ingress-nginx/templates/default-backend-rolebinding.yaml index 27c3e10df..a5b624cff 100644 --- a/charts/ingress-nginx/templates/default-backend-rolebinding.yaml +++ b/charts/ingress-nginx/templates/default-backend-rolebinding.yaml @@ -3,15 +3,13 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: RoleBinding metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} - name: {{ template "nginx-ingress.fullname" . }}-backend + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }} + name: {{ include "nginx-ingress.fullname" . }}-backend roleRef: apiGroup: rbac.authorization.k8s.io kind: Role - name: {{ template "nginx-ingress.fullname" . }}-backend + name: {{ include "nginx-ingress.fullname" . }}-backend subjects: - kind: ServiceAccount name: {{ template "nginx-ingress.defaultBackend.serviceAccountName" . }} diff --git a/charts/ingress-nginx/templates/default-backend-service.yaml b/charts/ingress-nginx/templates/default-backend-service.yaml index c7d336eea..90bbe1629 100644 --- a/charts/ingress-nginx/templates/default-backend-service.yaml +++ b/charts/ingress-nginx/templates/default-backend-service.yaml @@ -9,11 +9,8 @@ metadata: {{- end }} {{- end }} labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.defaultBackend.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }} name: {{ template "nginx-ingress.defaultBackend.fullname" . }} spec: {{- if not .Values.defaultBackend.service.omitClusterIP }} @@ -38,8 +35,7 @@ spec: protocol: TCP targetPort: http selector: - app: {{ template "nginx-ingress.name" . }} - component: "{{ .Values.defaultBackend.name }}" - release: {{ .Release.Name }} + {{- include "nginx-ingress.selectorLabels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }} type: "{{ .Values.defaultBackend.service.type }}" {{- end }} diff --git a/charts/ingress-nginx/templates/default-backend-serviceaccount.yaml b/charts/ingress-nginx/templates/default-backend-serviceaccount.yaml index 39d3c653a..a1c857da5 100644 --- a/charts/ingress-nginx/templates/default-backend-serviceaccount.yaml +++ b/charts/ingress-nginx/templates/default-backend-serviceaccount.yaml @@ -3,9 +3,7 @@ apiVersion: v1 kind: ServiceAccount metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }} name: {{ template "nginx-ingress.defaultBackend.serviceAccountName" . }} {{- end }} diff --git a/charts/ingress-nginx/templates/proxyheaders-configmap.yaml b/charts/ingress-nginx/templates/proxyheaders-configmap.yaml index 725e12065..0272e8afa 100644 --- a/charts/ingress-nginx/templates/proxyheaders-configmap.yaml +++ b/charts/ingress-nginx/templates/proxyheaders-configmap.yaml @@ -3,12 +3,9 @@ apiVersion: v1 kind: ConfigMap metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} - name: {{ template "nginx-ingress.fullname" . }}-custom-proxy-headers + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} + name: {{ include "nginx-ingress.fullname" . }}-custom-proxy-headers data: {{- if .Values.controller.proxySetHeaders }} {{ toYaml .Values.controller.proxySetHeaders | indent 2 }} diff --git a/charts/ingress-nginx/templates/tcp-configmap.yaml b/charts/ingress-nginx/templates/tcp-configmap.yaml index 73bc30b91..e8c374cc3 100644 --- a/charts/ingress-nginx/templates/tcp-configmap.yaml +++ b/charts/ingress-nginx/templates/tcp-configmap.yaml @@ -3,14 +3,11 @@ apiVersion: v1 kind: ConfigMap metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} annotations: {{ toYaml .Values.controller.tcp.annotations | indent 4}} - name: {{ template "nginx-ingress.fullname" . }}-tcp + name: {{ include "nginx-ingress.fullname" . }}-tcp data: {{ tpl (toYaml .Values.tcp) . | indent 2 }} {{- end }} diff --git a/charts/ingress-nginx/templates/udp-configmap.yaml b/charts/ingress-nginx/templates/udp-configmap.yaml index b363e705e..dd0550211 100644 --- a/charts/ingress-nginx/templates/udp-configmap.yaml +++ b/charts/ingress-nginx/templates/udp-configmap.yaml @@ -3,14 +3,11 @@ apiVersion: v1 kind: ConfigMap metadata: labels: - app: {{ template "nginx-ingress.name" . }} - chart: {{ template "nginx-ingress.chart" . }} - component: "{{ .Values.controller.name }}" - heritage: {{ .Release.Service }} - release: {{ .Release.Name }} + {{- include "nginx-ingress.labels" . | nindent 4 }} + app.kubernetes.io/component: {{ .Values.controller.name | quote }} annotations: {{ toYaml .Values.controller.udp.annotations | indent 4}} - name: {{ template "nginx-ingress.fullname" . }}-udp + name: {{ include "nginx-ingress.fullname" . }}-udp data: {{ tpl (toYaml .Values.udp) . | indent 2 }} {{- end }}