From 010342aa589daba28c7ad5b5411df53d17c97f4f Mon Sep 17 00:00:00 2001 From: Manuel de Brito Fontes Date: Tue, 24 Jul 2018 10:53:46 -0400 Subject: [PATCH] Do not allow invalid latency values in metrics --- internal/ingress/metric/collectors/socket.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/internal/ingress/metric/collectors/socket.go b/internal/ingress/metric/collectors/socket.go index 981224212..b3f0e6532 100644 --- a/internal/ingress/metric/collectors/socket.go +++ b/internal/ingress/metric/collectors/socket.go @@ -236,11 +236,13 @@ func (sc *SocketCollector) handleMessage(msg []byte) { requestsMetric.Inc() } - latencyMetric, err := sc.upstreamLatency.GetMetricWith(latencyLabels) - if err != nil { - glog.Errorf("Error fetching latency metric: %v", err) - } else { - latencyMetric.Observe(stats.Latency) + if stats.Latency != -1 { + latencyMetric, err := sc.upstreamLatency.GetMetricWith(latencyLabels) + if err != nil { + glog.Errorf("Error fetching latency metric: %v", err) + } else { + latencyMetric.Observe(stats.Latency) + } } if stats.RequestTime != -1 {