From 0311a99d3e647b2f71b78dd9ae9a521e0f31b8fd Mon Sep 17 00:00:00 2001 From: rvkubiak Date: Wed, 14 Feb 2018 14:10:42 -0800 Subject: [PATCH] Update Makefile to allow specifying tag from command line (#2092) The usage text in the Makefile suggests that you can specify TAG=1.4 to your make command to build with the specified tag. This does not work, since TAG is hard coded in the Makefile and overwrites any value you pass on the command line. $ GOPATH=/go TAG=notagforyou make container docker build --pull -t gcr.io/google_containers/defaultbackend-amd64:1.4 . Sending build context to Docker daemon 5.921MB Step 1/4 : FROM scratch ---> Step 2/4 : USER 65534:65534 ---> Using cache ---> 0f38024aa24e Step 3/4 : COPY server / ---> f8509ce4595d Step 4/4 : ENTRYPOINT /server ---> Running in 29b31420e648 ---> 65818e326440 Removing intermediate container 29b31420e648 Successfully built 65818e326440 Successfully tagged gcr.io/google_containers/defaultbackend-amd64:1.4 Update the TAG variable to work as documented. --- images/404-server/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/images/404-server/Makefile b/images/404-server/Makefile index e46815c41..89bbcba91 100644 --- a/images/404-server/Makefile +++ b/images/404-server/Makefile @@ -20,7 +20,7 @@ all: push -TAG=1.4 +TAG?=1.4 PREFIX?=gcr.io/google_containers/defaultbackend ARCH?=amd64