DevFW-CICD/ingress-nginx-helm
14
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #5091 from BrianKopp/protect-against-no-user-agent

Browse source 
Add case for when user agent is nil
This commit is contained in:
Kubernetes Prow Robot 2020-02-17 03:03:28 -08:00 committed by GitHub
commit 074351ae00
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
rootfs/etc/nginx/lua/test/util/same_site_test.lua
View file

@ -1,4 +1,8 @@
describe("same_site_compatible_test", function()
it("returns true for nil user agent", function()
local same_site = require("util.same_site")
assert.True(same_site.same_site_none_compatible(nil))
end)
it("returns false for chrome 4", function()
local same_site = require("util.same_site")
assert.False(same_site.same_site_none_compatible("Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2704.103 Safari/537.36"))

4
rootfs/etc/nginx/lua/util/same_site.lua
View file

@ -13,7 +13,9 @@ local _M = {}
-- browsers which will reject SameSite=None cookies.
-- reference: https://www.chromium.org/updates/same-site/incompatible-clients
function _M.same_site_none_compatible(user_agent)
if string.match(user_agent, "Chrome/4") then
if not user_agent then
return true
elseif string.match(user_agent, "Chrome/4") then
return false
elseif string.match(user_agent, "Chrome/5") then
return false