From 08906ef8f2c4d59b6bb5d4b81fbd0812ce127de5 Mon Sep 17 00:00:00 2001 From: Elvin Efendi Date: Thu, 4 Jul 2019 18:39:29 -0400 Subject: [PATCH] add comment to the test --- test/e2e/lua/dynamic_certificates.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/e2e/lua/dynamic_certificates.go b/test/e2e/lua/dynamic_certificates.go index dd374143b..e66c7e8d6 100644 --- a/test/e2e/lua/dynamic_certificates.go +++ b/test/e2e/lua/dynamic_certificates.go @@ -130,6 +130,11 @@ var _ = framework.IngressNginxDescribe("Dynamic Certificate", func() { ensureHTTPSRequest(f.GetURL(framework.HTTPS), host, host) }) + /* + TODO(elvinefendi): this test currently does not work as expected + because Go transport code strips (https://github.com/golang/go/blob/431b5c69ca214ce4291f008c1ce2a50b22bc2d2d/src/crypto/tls/handshake_messages.go#L424) + trailing dot from SNI as suggest by the standard (https://tools.ietf.org/html/rfc6066#section-3). + */ It("supports requests with domain with trailing dot", func() { ensureHTTPSRequest(f.GetURL(framework.HTTPS), host+".", host) })