From 0cc43d5e5295a769fa6e9428004a70378b632e9b Mon Sep 17 00:00:00 2001 From: Long Wu Yuan Date: Thu, 21 Jul 2022 06:27:44 +0530 Subject: [PATCH] added fixes for make dev-env (#8804) --- Makefile | 3 ++- build/build.sh | 1 + build/run-in-docker.sh | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index bafddeef2..5ba8e8ed5 100644 --- a/Makefile +++ b/Makefile @@ -54,8 +54,9 @@ ifneq ($(PLATFORM),) endif MAC_OS = $(shell uname -s) + ifeq ($(MAC_OS), Darwin) - MAC_DOCKER_FLAGS="--load" + MAC_DOCKER_FLAGS= else MAC_DOCKER_FLAGS= endif diff --git a/build/build.sh b/build/build.sh index 210a8e10f..3b51d665e 100755 --- a/build/build.sh +++ b/build/build.sh @@ -49,6 +49,7 @@ echo "Building targets for ${ARCH}, generated targets in ${TARGETS_DIR} director echo "Building ${PKG}/cmd/nginx" +git config --add safe.directory /go/src/k8s.io/ingress-nginx ${GO_BUILD_CMD} \ -trimpath -ldflags="-buildid= -w -s \ -X ${PKG}/version.RELEASE=${TAG} \ diff --git a/build/run-in-docker.sh b/build/run-in-docker.sh index d2cfe9552..3cb1f8ef5 100755 --- a/build/run-in-docker.sh +++ b/build/run-in-docker.sh @@ -65,12 +65,14 @@ fi USER=${USER:-nobody} +MAC_OS="`uname -s`" MAC_OS="${MAC_OS:-}" if [[ ${MAC_OS} == "Darwin" ]]; then MAC_DOCKER_FLAGS="" else MAC_DOCKER_FLAGS="-u $(id -u ${USER}):$(id -g ${USER})" #idk why mac/git fails on the gobuild if these are presented to dockerrun.sh script fi +echo "MAC_OS = ${MAC_OS}, MAC_OS_FLAGS = ${MAC_DOCKER_FLAGS}" echo "..printing env & other vars to stdout" echo "HOSTNAME=`hostname`"